Topic/otel shlib #347

dharshini555 · 2026-02-04T07:48:52Z

No description provided.

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Copilot

Pull request overview

This pull request adds OpenTelemetry (OTLP) instrumentation to the tr69hostif component for distributed tracing and metrics collection. The changes integrate the rdk_otel_instrumentation library to track parameter get/set operations with timing metrics and span tracing.

Changes:

Adds OpenTelemetry initialization and instrumentation calls to track GET/SET operations in the message handler
Removes duplicate getCurrentTime function from hostIf_utils.cpp (keeping the implementation in webpa_adapter.cpp)
Updates build configuration to link against the new rdk_otlp shared library
Modifies format specifiers for time values and removes unused stub header file

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/unittest/stubs/rdk_debug.h	Removes unused stub header file for unit tests
src/hostif/src/hostIf_utils.cpp	Removes getCurrentTime function (implementation exists elsewhere)
src/hostif/src/hostIf_main.cpp	Initializes OpenTelemetry instrumentation at startup
src/hostif/parodusClient/pal/mock-parodus/Makefile.am	Adds -lrdk_otlp library to test mock build
src/hostif/parodusClient/pal/Makefile.am	Minor formatting change to library flags
src/hostif/handlers/src/hostIf_msgHandler.cpp	Instruments GET/SET handlers with tracing spans and metrics
src/Makefile.am	Adds include path and library link for RDK OTLP instrumentation
cov_build.sh	Updates RFC clone to use topic/otel_shlib branch
configure.ac	Comments out libproc package check

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T07:53:59Z

src/hostif/src/hostIf_utils.cpp

 *
 * @param[in] Time spec timer
 */
-void getCurrentTime(struct timespec *timer)
-{
-    clock_gettime(CLOCK_REALTIME, timer);
-}



The function getCurrentTime is removed from this file, but it's still called in other parts of the codebase (e.g., src/hostif/httpserver/src/http_server.cpp lines 69 and 218, src/hostif/parodusClient/pal/libpd.cpp lines 172 and 201). While the function exists in webpa_adapter.cpp, these usages may need verification to ensure they still link correctly, especially since the declaration in hostIf_utils.h (line 157) is unchanged.

Copilot · 2026-02-04T07:54:00Z

configure.ac

        ],
        [
-        PKG_CHECK_MODULES([PROCPS], [libproc >= 3.2.8])])
+######        PKG_CHECK_MODULES([PROCPS], [libproc >= 3.2.8])])


The else branch of the AC_ARG_ENABLE([morty]) block is incomplete - it has a commented-out PKG_CHECK_MODULES statement with ###### prefix and appears to be missing a closing bracket. This will cause a syntax error in the configure script. The line should either be properly uncommented and completed, or the entire else block should be removed if not needed.

Copilot · 2026-02-04T07:54:00Z

src/hostif/parodusClient/pal/Makefile.am

            -I${PKG_CONFIG_SYSROOT_DIR}$(includedir)/wrp-c $(GLIB_CFLAGS)

-libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c  -lcjson -lpthread
+libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c  -lcjson -lpthread 


The library -lrdk_otlp is added to the main build in src/Makefile.am but not to the parodus client library (libparodusclient.la) in this Makefile. This inconsistency may cause linking issues if libparodusclient needs to use the rdk_otlp functions. Verify whether this library should also be added here or if the dependency is properly handled elsewhere.

Suggested change

libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c -lcjson -lpthread

libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c -lrdk_otlp -lcjson -lpthread

Copilot · 2026-02-04T07:54:00Z

src/hostif/src/hostIf_main.cpp

+        rdk_otlp_init("tr69hostif", "1.0.0");
+        rdk_otlp_metrics_init();
+        RDK_LOG(RDK_LOG_INFO, LOG_TR69HOSTIF, "TR69HostIF OTLP instrumentation initialized\n");


The OpenTelemetry initialization (rdk_otlp_init and rdk_otlp_metrics_init) is performed at startup, but there's no corresponding cleanup or shutdown call in the exit_gracefully function (around line 603-648). This could lead to resource leaks or incomplete telemetry data. Consider adding cleanup calls like rdk_otlp_shutdown or rdk_otlp_cleanup before the application exits.

Copilot · 2026-02-04T07:54:01Z

src/hostif/handlers/src/hostIf_msgHandler.cpp

+
+            // Record metric - convert microseconds to seconds
+            double duration_seconds = timeTaken / 1000000.0;
+	    //rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "get", duration_seconds);


This line uses tabs for indentation while the surrounding code uses spaces. The inconsistent indentation should be corrected to match the rest of the file which uses spaces.

Suggested change

//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "get", duration_seconds);

//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "get", duration_seconds);

Copilot · 2026-02-04T07:54:01Z

src/hostif/handlers/src/hostIf_msgHandler.cpp

+
+        // Record metric - convert microseconds to seconds
+        double duration_seconds = timeTakenset / 1000000.0;
+	//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "set", duration_seconds);


This line uses tabs for indentation while the surrounding code uses spaces. The inconsistent indentation should be corrected to match the rest of the file which uses spaces.

Suggested change

//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "set", duration_seconds);

//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "set", duration_seconds);

Copilot · 2026-02-04T07:54:01Z

src/Makefile.am

 	-I$(top_srcdir)/src/hostif/profiles/DeviceInfo \
-	-I$(top_srcdir)/src/hostif/profiles/Device
+	-I$(top_srcdir)/src/hostif/profiles/Device \
+	-I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include


The hardcoded absolute path /mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include is problematic for portability and maintainability. Consider using a configurable path via environment variable or autoconf variable (e.g., --with-rdk-otlp-include) to make the build more flexible across different environments.

Copilot · 2026-02-04T07:54:01Z

src/hostif/parodusClient/pal/Makefile.am

            -I${PKG_CONFIG_SYSROOT_DIR}$(includedir)/wrp-c $(GLIB_CFLAGS)

-libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c  -lcjson -lpthread
+libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c  -lcjson -lpthread 


Trailing whitespace detected at the end of this line. This should be removed to maintain code cleanliness.

Copilot · 2026-02-04T07:54:01Z

src/hostif/handlers/src/hostIf_msgHandler.cpp

+    rdk_otlp_start_child_span(stMsgData->paramName, "get");
    try
    {


The rdk_otlp_start_child_span is called before the try block, which means if any exception occurs during span creation, the corresponding rdk_otlp_finish_child_span will still be called. This could lead to mismatched span start/finish calls if the start function throws an exception. Consider moving the span start inside the try block or wrapping the entire function body (including span management) in a try-catch to ensure proper cleanup.

Suggested change

rdk_otlp_start_child_span(stMsgData->paramName, "get");

try

{

try

{

rdk_otlp_start_child_span(stMsgData->paramName, "get");

Copilot · 2026-02-04T07:54:02Z

src/hostif/handlers/src/hostIf_msgHandler.cpp


-
+   // Start child span (retrieves parent context from TraceContextManager)
+    rdk_otlp_start_child_span(stMsgData->paramName, "set");


The rdk_otlp_start_child_span is called before any error handling, and rdk_otlp_finish_child_span is always called at the end. However, if an exception occurs during span creation or if the function returns early due to other conditions, this could lead to mismatched span start/finish calls. Consider using RAII pattern (e.g., a scope guard) to ensure the span is properly closed even in exceptional cases.

rdkcmf-jenkins · 2026-02-04T08:01:17Z

src/hostif/handlers/src/hostIf_msgHandler.cpp

 #endif
 #include "x_rdk_req_handler.h"
-
+#include "rdk_otlp_instrumentation.h"


Coverity Issue - Unrecoverable parse warning

cannot open source file "rdk_otlp_instrumentation.h"

Low Impact, CWE-none
PARSE_ERROR

dharshini555 added 2 commits January 5, 2026 09:40

Implement Distributed tracing with shared libs

4c68fb2

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Implement Distributed tracing

3cb4d83

dharshini555 requested a review from a team as a code owner February 4, 2026 07:48

Copilot AI review requested due to automatic review settings February 4, 2026 07:48

Copilot started reviewing on behalf of dharshini555 February 4, 2026 07:49 View session

Update hostIf_msgHandler.cpp

0f713d4

Copilot AI reviewed Feb 4, 2026

View reviewed changes

rdkcmf-jenkins reviewed Feb 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topic/otel shlib #347

Topic/otel shlib #347

Uh oh!

dharshini555 commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

rdkcmf-jenkins Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c -lcjson -lpthread
	libparodusclient_la_LDFLAGS= -llibparodus -lrdkloggers -lwdmp-c -lwrp-c -lrdk_otlp -lcjson -lpthread

	//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "get", duration_seconds);
	//rdk_otlp_metrics_record_parameter_operation(stMsgData->paramName, "get", duration_seconds);



		// Start child span (retrieves parent context from TraceContextManager)
		rdk_otlp_start_child_span(stMsgData->paramName, "set");

Topic/otel shlib #347

Are you sure you want to change the base?

Topic/otel shlib #347

Uh oh!

Conversation

dharshini555 commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins Feb 4, 2026

Choose a reason for hiding this comment

Coverity Issue - Unrecoverable parse warning

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants