[WIP] Fix L1 unit test cases for commonlib and reportgen #261
+4
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ASSERT_STREQ to verify paramValue equals "true" in getParameterValue_success_boolean test - Add ASSERT_STREQ to verify paramValue equals "false" in getParameterValue_failure_boolean test - Add free(paramValue) to both tests to prevent memory leaks - Addresses review feedback on lines 353-371 of TelemetryBusMsgSender.cpp Co-authored-by: shibu-kv <89052442+shibu-kv@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getParameterValue_success_booleantest: add assertion for "true" and free memorygetParameterValue_failure_booleantest: add assertion for "false" and free memory💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.