Skip to content

RDK-60476: Update L1 and L2 testcases for fork elimination #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yogeswaransky wants to merge 1 commit into
base: develop
Choose a base branch
from
+460 −222
Open

RDK-60476: Update L1 and L2 testcases for fork elimination #260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 46 additions & 2 deletions source/test/mocks/FileioMock.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,13 +49,14 @@ typedef struct curl_slist* (*curl_slist_append_ptr) (struct curl_slist *list, co
typedef CURL* (*curl_easy_init_ptr)();
typedef CURLcode (*curl_easy_setopt_mock_ptr) (CURL *curl, CURLoption option, void* parameter);
typedef CURLcode (*curl_easy_getinfo_mock_ptr) (CURL *curl, CURLINFO info, void* arg);
typedef CURLcode (*curl_easy_getinfo_ptr) (CURL *curl, CURLINFO info, ...);
typedef long (*ftell_ptr) (FILE *stream);
typedef int (*fscanf_ptr) (FILE *, const char *, va_list);
typedef pid_t (*fork_ptr) ();
typedef ssize_t (*write_ptr) (int fd, const void *buf, size_t count);
//typedef int (*stat_ptr) (const char *pathname, struct stat *statbuf);
typedef int (*fprintf_ptr) (FILE* stream, const char* format, va_list args);
//pedef CURLcode (*curl_easy_setopt_ptr) (CURL *curl, CURLoption option, parameter);
typedef CURLcode (*curl_easy_setopt_ptr) (CURL *curl, CURLoption option, ...);
typedef void (*curl_easy_cleanup_ptr) (CURL *handle);
typedef void (*curl_slist_free_all_ptr) (struct curl_slist *list);
typedef int (*munmap_ptr) (void *addr, size_t len);
Expand Down Expand Up @@ -102,7 +103,9 @@ curl_easy_setopt_mock_ptr curl_easy_setopt_mock_func = (curl_easy_setopt_mock_pt
curl_easy_getinfo_mock_ptr curl_easy_getinfo_mock_func = (curl_easy_getinfo_mock_ptr) dlsym(RTLD_NEXT, "curl_easy_getinfo_mock");
curl_easy_cleanup_ptr curl_easy_cleanup_func = (curl_easy_cleanup_ptr) dlsym(RTLD_NEXT, "curl_easy_cleanup");
curl_slist_free_all_ptr curl_slist_free_all_func = (curl_slist_free_all_ptr) dlsym(RTLD_NEXT, "curl_slist_free_all");
//curl_easy_setopt_ptr curl_easy_setopt_func = (curl_easy_setopt_ptr) dlsym(RTLD_NEXT, "curl_easy_setopt");
curl_easy_setopt_ptr curl_easy_setopt_func = (curl_easy_setopt_ptr) dlsym(RTLD_NEXT, "curl_easy_setopt");
curl_easy_getinfo_ptr curl_easy_getinfo_func = (curl_easy_getinfo_ptr) dlsym(RTLD_NEXT, "curl_easy_getinfo");

munmap_ptr munmap_func = (munmap_ptr) dlsym(RTLD_NEXT, "munmap");
mmap_ptr mmap_func = (mmap_ptr) dlsym(RTLD_NEXT, "mmap");
mkstemp_ptr mkstemp_func = (mkstemp_ptr) dlsym(RTLD_NEXT, "mkstemp");
Expand Down Expand Up @@ -386,6 +389,34 @@ extern "C" CURLcode curl_easy_getinfo_mock(CURL *curl, CURLINFO info, void* arg)
return g_fileIOMock->curl_easy_getinfo_mock(curl, info, arg);
}

extern "C" CURLcode curl_easy_getinfo(CURL *curl, CURLINFO info, ...)
{
if (g_fileIOMock != nullptr) {
va_list args;
va_start(args, info);
void* arg = va_arg(args, void*);
va_end(args);
return g_fileIOMock->curl_easy_getinfo_mock(curl, info, arg);
}

// Fallback to real function
if (curl_easy_getinfo_func) {
va_list args;
va_start(args, info);
void* arg = va_arg(args, void*);
va_end(args);

// Call real function with extracted argument
if (info == CURLINFO_RESPONSE_CODE) {
return curl_easy_getinfo_func(curl, info, (long*)arg);
} else {
return curl_easy_getinfo_func(curl, info, arg);
}
}

return CURLE_FAILED_INIT;
}

extern "C" struct curl_slist *curl_slist_append(struct curl_slist *list, const char * string)
{
if (g_fileIOMock == nullptr){
Expand Down Expand Up @@ -459,6 +490,19 @@ extern "C" CURLcode curl_easy_setopt(CURL *curl, CURLoption option, ...)
return result;
}
*/

extern "C" CURLcode curl_easy_setopt(CURL* handle, CURLoption option, ...) {
if (g_fileIOMock != nullptr) {
va_list args;
va_start(args, option);
void* param = va_arg(args, void*);
va_end(args);
return g_fileIOMock->curl_easy_setopt(handle, option, param);
Comment on lines +496 to +500
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl_easy_setopt is variadic, but this wrapper unconditionally reads the first vararg as void*. Many real call sites pass long values and function pointers (e.g., CURLOPT_TIMEOUT, CURLOPT_HTTPGET, CURLOPT_WRITEFUNCTION), so reading them as void* is undefined behavior and can break tests on some platforms/ABIs. Consider not extracting the argument at all for the mocked path (if tests don’t assert on it), or implement option-type-aware extraction (long vs pointer vs function pointer), and/or provide a safe fallback that forwards to the real curl_easy_setopt when g_fileIOMock is null.

Suggested change
va_list args;
va_start(args, option);
void* param = va_arg(args, void*);
va_end(args);
return g_fileIOMock->curl_easy_setopt(handle, option, param);
/* Do not read variadic arguments here to avoid undefined behavior
* when the caller passes non-pointer types (e.g., long or function
* pointers). The mock implementation should not depend on the
* concrete value of the option parameter.
*/
return g_fileIOMock->curl_easy_setopt(handle, option, nullptr);

Copilot uses AI. Check for mistakes.
}
return CURLE_FAILED_INIT;
}


extern "C" void curl_easy_cleanup(CURL *handle)
{
if (g_fileIOMock == nullptr){
Expand Down
4 changes: 2 additions & 2 deletions source/test/mocks/FileioMock.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,9 +86,9 @@ class FileMock
MOCK_METHOD(ssize_t, getline, (char** lineptr, size_t* n, FILE* stream), ());
MOCK_METHOD(pid_t, fork, (), ());
MOCK_METHOD(ssize_t, write, (int fd, const void* buf, size_t count), ());
//MOCK_METHOD(CURLcode, curl_easy_setopt, (CURL *handle, CURLoption option, parameter), ());
MOCK_METHOD(CURLcode, curl_easy_setopt, (CURL *handle, CURLoption option, void *parameter), ());
MOCK_METHOD(void, curl_easy_cleanup, (CURL *handle), ());
MOCK_METHOD(CURLcode, curl_easy_setopt_mock, (CURL *handle, CURLoption option, void* parameter), ());
MOCK_METHOD(CURLcode, curl_easy_setopt_mock, (CURL *handle, CURLoption option, void *parameter), ());
MOCK_METHOD(CURLcode, curl_easy_getinfo_mock, (CURL *curl, CURLINFO info, void* arg), ());
MOCK_METHOD(void, curl_slist_free_all, (struct curl_slist *list), ());
//MOCK_METHOD(int, stat, (const char *pathname, struct stat *statbuf), ());
Expand Down
Loading
Loading