Issue 160: Fix invalid buffer type validation in sa_process_common_encryption #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add early validation for in and out buffer_type fields to return SA_STATUS_INVALID_PARAMETER when buffer type is neither SA_BUFFER_TYPE_CLEAR nor SA_BUFFER_TYPE_SVP. This fixes the SaProcessCommonEncryptionNegativeTest.invalidInBufferType test which was incorrectly returning SA_STATUS_NULL_PARAMETER.
There was a problem hiding this comment.
Pull request overview
This PR tightens input validation in sa_process_common_encryption to correctly reject invalid buffer types, aligning client-side checks with the TA implementation and fixing a regression related to SVP disable handling.
Changes:
- Added explicit validation that
samples[i].out->buffer_typeandsamples[i].in->buffer_typemust be eitherSA_BUFFER_TYPE_CLEARorSA_BUFFER_TYPE_SVP, returningSA_STATUS_INVALID_PARAMETERotherwise. - Updated the file header to extend the copyright year to 2026.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
JRHewitt-CC
approved these changes
Jan 27, 2026
JRHewitt-CC
left a comment
JRHewitt-CC
left a comment
There was a problem hiding this comment.
The code looks fine and you can merge / release.
Is there any ticket with logs associated with this error?
mhabrat
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a bug introduced with the SVP disable flag.