Skip to content

Conversation

@im1308
Copy link
Contributor

@im1308 im1308 commented Nov 14, 2025

RDKB-61958: Parodus-Start coverity issues fix

Reason for change: High and medium risk Parodus Start coverity issues fix
Test Procedure: Build should be successful and the regression test should also succeed.
Risks: High
Priority: P1

Below referred coverity Issues fixed.

Screenshot 2025-11-13 153734

@im1308 im1308 requested review from a team as code owners November 14, 2025 10:35
@github-actions
Copy link

github-actions bot commented Nov 14, 2025

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@im1308 im1308 requested a review from apattu200 November 14, 2025 10:35
@GoutamD2905
Copy link
Contributor

Before merging, I have a few questions:

  1. Is this a Bug or a User Story (US)?
  2. If it is a User Story:
    • Please list all dependent PRs from other components, if any.
    • The commit message must include both the User Story ticket and the Subtask ticket.
    • All changes related to the User Story must be squashed and merged in a single commit.
    • Do not raise pull requests for partial User Story changes.
    • Has the code development for the User Story been completed?
      • If yes, please share the Gerrit topic or list all dependent PRs across components, including any meta-layer changes.
  3. Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?
    • If yes, please share the links to the validation comments.

@mhughesacn
Copy link

The fossid error can be ignored because it is match to our own code: fossid tells you the file with the match (1) and where the match is (i.e. file and repo with version info) (2) and (3) like this:
(1) source/parodusStart/start_parodus.c' (Match: (2) rdkb/components/generic/startParodus/rdkb/components/generic/startParodus/1, 1786 lines, url: (3) https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/generic/startParodus/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: source/parodusStart/start_parodus.c

Sriram Giridharan (Comcast) was working on excluding these but I don't know the current status of that task.

@im1308
Copy link
Contributor Author

im1308 commented Nov 20, 2025

The fossid error can be ignored because it is match to our own code: fossid tells you the file with the match (1) and where the match is (i.e. file and repo with version info) (2) and (3) like this: (1) source/parodusStart/start_parodus.c' (Match: (2) rdkb/components/generic/startParodus/rdkb/components/generic/startParodus/1, 1786 lines, url: (3) https://code.rdkcentral.com/r/plugins/gitiles/rdkb/components/generic/startParodus/+archive/RDKB-RELEASE-TEST-DUNFELL-1.tar.gz, file: source/parodusStart/start_parodus.c

Sriram Giridharan (Comcast) was working on excluding these but I don't know the current status of that task.

Thanks. we will ignore this error.

@im1308
Copy link
Contributor Author

im1308 commented Nov 21, 2025

Before merging, I have a few questions:

  1. Is this a Bug or a User Story (US)? - Yes

  2. If it is a User Story:

    • Please list all dependent PRs from other components, if any. - No dependent PRs.

    • The commit message must include both the User Story ticket and the Subtask ticket.

    • All changes related to the User Story must be squashed and merged in a single commit.

    • Do not raise pull requests for partial User Story changes.

    • Has the code development for the User Story been completed? Yes

      • If yes, please share the Gerrit topic or list all dependent PRs across components, including any meta-layer changes.
  3. Is there a validation log available in the Jira ticket for verifying builds with the updated generic-srcrev.inc across all platforms?

@im1308
Copy link
Contributor Author

im1308 commented Nov 25, 2025

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

recheck

@im1308
Copy link
Contributor Author

im1308 commented Nov 25, 2025

I have read the CLA Document and I hereby sign the CLA

@im1308
Copy link
Contributor Author

im1308 commented Nov 25, 2025

recheck

Copy link
Contributor

@apattu200 apattu200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@im1308 im1308 changed the title Feature/rdkb 61958 RDKB-61958: Parodus-Start coverity issues fix Nov 26, 2025
@im1308 im1308 merged commit 90be847 into develop Dec 2, 2025
7 of 13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants