Topic/otel shlib #165

dharshini555 · 2026-02-04T07:44:38Z

No description provided.

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Copilot

Pull request overview

This pull request integrates OpenTelemetry (OTLP) instrumentation into the RDK RFC (Remote Feature Control) codebase to enable distributed tracing and metrics collection for parameter operations.

Changes:

Added OpenTelemetry initialization and distributed tracing to tr181 and rfcMgr applications
Instrumented getRFCParameter and setRFCParameter functions with timing metrics
Updated build configuration to link against the lrdk_otlp library and include necessary headers

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
utils/tr181utils.cpp	Added OpenTelemetry initialization in main() and distributed trace span creation/completion in getAttribute/setAttribute functions
utils/Makefile.am	Added `-lrdk_otlp` library dependency and include path for OpenTelemetry headers
rfcapi/rfcapi.cpp	Added timing instrumentation to measure and record metrics for getRFCParameter and setRFCParameter operations
rfcapi/Makefile.am	Added `-lrdk_otlp` library dependency and include path for OpenTelemetry headers
rfcMgr/rfc_main.cpp	Added OpenTelemetry initialization calls at application startup
rfcMgr/Makefile.am	Added `-lrdk_otlp` library dependency to linker flags

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-04T07:49:15Z

utils/tr181utils.cpp

 */
 static int setAttribute(char * const paramName  ,char type, char * value)
 {
+   //Start distributed trace (creates parent span and stores context)


Missing space after comment slashes. The codebase convention is to use "// " with a space after the slashes for inline comments, as seen elsewhere in this file (lines 141, 172, 309).

Suggested change

//Start distributed trace (creates parent span and stores context)

// Start distributed trace (creates parent span and stores context)

Copilot · 2026-02-04T07:49:15Z

rfcapi/rfcapi.cpp

+   //auto timeTaken = std::chrono::duration_cast<std::chrono::microseconds>(endTime - startTime).count();
+   // Record metrics (convert microseconds to seconds)
+   //double duration_seconds = timeTaken / 1000000.0;
+   //rdk_otlp_metrics_record_parameter_operation(pcParameterName, "get", duration_seconds);


The operation type should be "set" not "get" for the setRFCParameter function. This will cause incorrect metrics to be recorded, making it impossible to distinguish between get and set operations in the telemetry data.

Suggested change

//rdk_otlp_metrics_record_parameter_operation(pcParameterName, "get", duration_seconds);

//rdk_otlp_metrics_record_parameter_operation(pcParameterName, "set", duration_seconds);

Copilot · 2026-02-04T07:49:16Z

rfcapi/rfcapi.cpp

   CURL *curl_handle = NULL;
   CURLcode res = CURLE_FAILED_INIT;
-
+   //auto startTime = std::chrono::high_resolution_clock::now();


The timing measurement started here will not result in metrics being recorded if the function returns early at line 481 (wildcard/NULL parameter validation failure). This creates incomplete telemetry data where failed operations won't be tracked. Consider restructuring the code to ensure metrics are recorded for all execution paths, including error cases.

Copilot · 2026-02-04T07:49:16Z

rfcapi/rfcapi.cpp

   CURL *curl_handle = NULL;
   CURLcode res = CURLE_FAILED_INIT;

+   //auto startTime = std::chrono::high_resolution_clock::now();


The timing measurement started here will not result in metrics being recorded if the function returns early at lines 279, 294, 300, 305, or 308 (validation failures or fallback to file-based retrieval). This creates incomplete telemetry data where these execution paths won't be tracked. Consider restructuring the code to ensure metrics are recorded for all execution paths, including error cases and fallback scenarios.

Copilot · 2026-02-04T07:49:16Z

rfcapi/Makefile.am

 else
-librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG)
-librfcapi_la_LIBADD = -lcurl -lcjson -lrdkloggers
+librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG) -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include


Hardcoded absolute path "/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include" makes the build non-portable and environment-specific. Consider using a configurable variable or pkg-config to locate the OpenTelemetry instrumentation headers, similar to how other dependencies are handled (e.g., cjson_CFLAGS, curl_CFLAGS).

Suggested change

librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG) -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include

librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG) $(OTEL_INSTRUMENTATION_CFLAGS)

Copilot · 2026-02-04T07:49:16Z

utils/Makefile.am

-tr181_LDADD = ../rfcapi/.libs/librfcapi.la ../tr181api/.libs/libtr181api.la
-tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c
+tr181_LDADD = ../rfcapi/.libs/librfcapi.la ../tr181api/.libs/libtr181api.la -lrdk_otlp
+tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include


Hardcoded absolute path "/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include" makes the build non-portable and environment-specific. Consider using a configurable variable or pkg-config to locate the OpenTelemetry instrumentation headers, similar to how other dependencies are handled.

Suggested change

tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include

RDK_OTEL_INSTRUMENTATION_CFLAGS ?= -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include

tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c $(RDK_OTEL_INSTRUMENTATION_CFLAGS)

Copilot · 2026-02-04T07:49:16Z

rfcMgr/Makefile.am

@@ -23,7 +23,7 @@ rfcMgr_SOURCES = rfc_main.cpp rfc_manager.cpp rfc_common.cpp mtlsUtils.cpp rfc_x
 rfcMgr_CPPFLAGS = -std=c++17 -Wall -Werror -DRDK_LOGGER -I${top_srcdir}/rfcMgr -I${top_srcdir}/rfcapi/ $(cjson_CFLAGS) $(curl_CFLAGS) $(CFLAGS)


The rfcMgr includes the "rdk_otlp_instrumentation.h" header file at line 22 and calls rdk_otlp_init and rdk_otlp_metrics_init, but the Makefile doesn't include the path to find this header. The include path should be added to rfcMgr_CPPFLAGS, similar to what was done in rfcapi/Makefile.am and utils/Makefile.am. Without this, the build will fail with a "header not found" error.

Suggested change

rfcMgr_CPPFLAGS = -std=c++17 -Wall -Werror -DRDK_LOGGER -I${top_srcdir}/rfcMgr -I${top_srcdir}/rfcapi/ $(cjson_CFLAGS) $(curl_CFLAGS) $(CFLAGS)

rfcMgr_CPPFLAGS = -std=c++17 -Wall -Werror -DRDK_LOGGER -I${top_srcdir}/rfcMgr -I${top_srcdir}/rfcapi/ -I$(PKG_CONFIG_SYSROOT_DIR)${includedir}/rdk/otlp $(cjson_CFLAGS) $(curl_CFLAGS) $(CFLAGS)

dharshini555 added 2 commits January 5, 2026 09:18

Implement Distributed tracing with shared libs

8daec99

Signed-off-by: PriyaDharshini_Kathiravan <priyakathiravan05@gmail.com>

Implement Distributed tracing

d124ab9

Copilot AI review requested due to automatic review settings February 4, 2026 07:44

dharshini555 requested a review from a team as a code owner February 4, 2026 07:44

Copilot started reviewing on behalf of dharshini555 February 4, 2026 07:44 View session

Update rfcapi.cpp

026bbdc

Copilot AI reviewed Feb 4, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Topic/otel shlib #165

Topic/otel shlib #165

dharshini555 commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Copilot AI Feb 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

	//Start distributed trace (creates parent span and stores context)
	// Start distributed trace (creates parent span and stores context)

	//rdk_otlp_metrics_record_parameter_operation(pcParameterName, "get", duration_seconds);
	//rdk_otlp_metrics_record_parameter_operation(pcParameterName, "set", duration_seconds);

	librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG) -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include
	librfcapi_la_CPPFLAGS = "-std=c++11" -DLINUX -fPIC -g -O2 -Wall -I=/usr/include/cjson -I=/usr/include/wdmp-c $(IARMBUS_EVENT_FLAG) $(OTEL_INSTRUMENTATION_CFLAGS)

	tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include
	RDK_OTEL_INSTRUMENTATION_CFLAGS ?= -I/mnt/L2_CONTAINER_SHARED_VOLUME/dtracing/rdk_otel_instrumentation/include
	tr181_CPPFLAGS = -std=c++0x -Wall -I${top_srcdir}/rfcapi/ -I${top_srcdir}/tr181api/ -I=/usr/include/wdmp-c $(RDK_OTEL_INSTRUMENTATION_CFLAGS)

		@@ -23,7 +23,7 @@ rfcMgr_SOURCES = rfc_main.cpp rfc_manager.cpp rfc_common.cpp mtlsUtils.cpp rfc_x
		rfcMgr_CPPFLAGS = -std=c++17 -Wall -Werror -DRDK_LOGGER -I${top_srcdir}/rfcMgr -I${top_srcdir}/rfcapi/ $(cjson_CFLAGS) $(curl_CFLAGS) $(CFLAGS)

Topic/otel shlib #165

Are you sure you want to change the base?

Topic/otel shlib #165

Conversation

dharshini555 commented Feb 4, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant