RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device #162

Vismalskumar0 · 2026-01-29T06:45:16Z

RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device

Reason for change :Resolved the coverity issues reported by Cov scans.

Copilot

Pull request overview

This PR modernizes C++ string initialization and improves code quality in the RFC (Runtime Feature Control) handler by converting copy initialization to direct initialization and adding proper control flow in a switch statement.

Changes:

Updated string variable initializations from copy initialization (std::string var = "value") to direct initialization (std::string var("value")) across multiple functions
Added missing break statements and a default case to the curl error code switch statement for proper control flow
Optimized string assignments by using std::move() semantics for accountId and partnerId to avoid unnecessary copies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_xconf_handler.cpp

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

nhanasi · 2026-01-29T17:01:27Z

Please share the Dev Test results for RDKV and RDKB

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-05T08:43:52Z

rfcMgr/rfc_manager.cpp

+		 rdk_logger_ext_config_t config = {
+        .pModuleName = "LOG.RDK.RFC",     /* Module name */
+        .loglevel = RDK_LOG_INFO,                 /* Default log level */
+        .output = RDKLOG_OUTPUT_CONSOLE,          /* Output to console (stdout/stderr) */
+        .format = RDKLOG_FORMAT_WITH_TS,          /* Timestamped format */
+        .pFilePolicy = NULL                       /* Not using file output, so NULL */
+    };
+
+    if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {
+        printf("RFC : ERROR - Extended logger init failed\n");
+    }
+


Mixed indentation detected: the rdk_logger_ext_config_t initialization and the if statement use spaces, but the indentation at lines 46 and 57 uses tabs. Please use consistent indentation (spaces) throughout this block to match the surrounding code style.

Copilot · 2026-02-05T08:43:53Z

rfcMgr/rfc_xconf_handler.cpp

-                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME);
+				if (errno != ENOENT)
+				{
+                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);


The error message format is inconsistent with other log messages in the same function. It should have a space after [%d] before "Failed", and a space after the comma before "errno". Compare with lines 1505 and 1510 which follow the pattern "[%s][%d] ". The message should be: "[%s][%d] Failed to remove file %s, errno=%d\n"

Suggested change

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d] Failed to remove file %s, errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME, errno);

Copilot · 2026-02-05T08:43:53Z

rfcMgr/rfc_xconf_handler.cpp

+				if (errno != ENOENT)
+				{
+                RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);
+				}


The indentation here uses tabs, which is inconsistent with the surrounding code in this file that uses spaces (see lines 1484-1522). Please use consistent indentation (spaces) to match the surrounding code style.

Suggested change

if (errno != ENOENT)

{

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

}

if (errno != ENOENT)

{

RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);

}

Copilot · 2026-02-05T08:43:53Z

rfcMgr/rfc_manager.cpp

+
        rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);	    


Initializing the extended logger with rdk_logger_ext_init and then immediately calling rdk_logger_init may cause conflicts or unexpected behavior. The rdk_logger_init call on line 58 may override the extended logger configuration. Consider whether both initializations are necessary, or if only one should be used. If both are needed, add a comment explaining why both logger initialization methods are required.

Suggested change

rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

rfcMgr/rfc_manager.cpp

Copilot · 2026-02-05T09:33:01Z

rfcMgr/rfc_manager.cpp

+    if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {
+        printf("RFC : ERROR - Extended logger init failed\n");
+    }
+


The indentation uses tabs instead of spaces, which is inconsistent with the surrounding code. Lines 47-56 use spaces for indentation. This creates mixed indentation within the same function.

Copilot · 2026-02-05T09:33:02Z

rfcMgr/rfc_manager.cpp

+
+         static char RFCMGRLOG[] = "LOG.RDK.RFCMGR";
+		 rdk_logger_ext_config_t config = {
+        .pModuleName = RFCMGRLOG,     /* Module name */
+        .loglevel = RDK_LOG_INFO,                 /* Default log level */
+        .output = RDKLOG_OUTPUT_CONSOLE,          /* Output to console (stdout/stderr) */
+        .format = RDKLOG_FORMAT_WITH_TS,          /* Timestamped format */
+        .pFilePolicy = NULL                       /* Not using file output, so NULL */
+    };
+
+    if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {
+        printf("RFC : ERROR - Extended logger init failed\n");
+    }
+
        rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);	    



Two logger initialization calls are made in sequence: rdk_logger_ext_init with console output configuration, followed immediately by rdk_logger_init with file-based configuration. If these initializers have different behaviors or override each other's settings, this could lead to unexpected logging behavior. Please verify that both initializers are necessary and that their configurations are compatible.

Suggested change

static char RFCMGRLOG[] = "LOG.RDK.RFCMGR";

rdk_logger_ext_config_t config = {

.pModuleName = RFCMGRLOG, /* Module name */

.loglevel = RDK_LOG_INFO, /* Default log level */

.output = RDKLOG_OUTPUT_CONSOLE, /* Output to console (stdout/stderr) */

.format = RDKLOG_FORMAT_WITH_TS, /* Timestamped format */

.pFilePolicy = NULL /* Not using file output, so NULL */

};

if (rdk_logger_ext_init(&config) != RDK_SUCCESS) {

printf("RFC : ERROR - Extended logger init failed\n");

}

rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);

rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Update rfc_xconf_handler.cpp

a395aee

Copilot AI review requested due to automatic review settings January 29, 2026 06:45

Vismalskumar0 requested a review from a team as a code owner January 29, 2026 06:45

Copilot started reviewing on behalf of Vismalskumar0 January 29, 2026 06:45 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

Update rfcMgr/rfc_xconf_handler.cpp

8aae2d6

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 29, 2026 07:02

Update rfcMgr/rfc_xconf_handler.cpp

095fcdd

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot started reviewing on behalf of Vismalskumar0 January 29, 2026 07:02 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

rfcMgr/rfc_xconf_handler.cpp Show resolved Hide resolved

Vismalskumar0 added 2 commits January 29, 2026 12:38

Update rfc_xconf_handler.cpp

4d843c1

Update rfc_xconf_handler.cpp

b2b4e56

Copilot AI review requested due to automatic review settings January 29, 2026 07:13

Copilot started reviewing on behalf of Vismalskumar0 January 29, 2026 07:13 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

rfcMgr/rfc_xconf_handler.cpp Outdated Show resolved Hide resolved

Update rfcMgr/rfc_xconf_handler.cpp

5b98ab9

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings January 29, 2026 07:20

Copilot started reviewing on behalf of Vismalskumar0 January 29, 2026 07:20 View session

Copilot AI reviewed Jan 29, 2026

View reviewed changes

Vismalskumar0 changed the title ~~Update rfc_xconf_handler.cpp~~ RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device Jan 29, 2026

nhanasi previously approved these changes Jan 29, 2026

View reviewed changes

Fixed the final warnings rfc_xconf_handler.cpp

4e32f18

Vismalskumar0 dismissed nhanasi’s stale review via 4e32f18 January 30, 2026 08:50

Update rfc_manager.cpp

1742b0f

Copilot AI review requested due to automatic review settings February 5, 2026 08:40

Copilot started reviewing on behalf of Vismalskumar0 February 5, 2026 08:40 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Vismalskumar0 added 2 commits February 5, 2026 14:31

Update rfc_manager.cpp

2a23678

Update rfc_manager.cpp

974c2d7

Copilot AI review requested due to automatic review settings February 5, 2026 09:28

Copilot started reviewing on behalf of Vismalskumar0 February 5, 2026 09:28 View session

Copilot AI reviewed Feb 5, 2026

View reviewed changes

Remove the logger changes

ccf730f

Copilot AI review requested due to automatic review settings February 6, 2026 12:11

Copilot started reviewing on behalf of Vismalskumar0 February 6, 2026 12:11 View session

Copilot AI reviewed Feb 6, 2026

View reviewed changes

	RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d]Failed to remove file %s,errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME,errno);
	RDK_LOG(RDK_LOG_ERROR, LOG_RFCMGR,"[%s][%d] Failed to remove file %s, errno=%d\n", __FUNCTION__, __LINE__, DIRECT_BLOCK_FILENAME, errno);


		rdk_logger_init(0 == access(OVERIDE_DEBUG_INI_FILE, R_OK) ? OVERIDE_DEBUG_INI_FILE : DEBUG_INI_FILE);

RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device #162

Are you sure you want to change the base?

RDK-60308 [tr69hostif, RFC] RDK Coverity Defect Resolution for Device #162

Uh oh!

Conversation

Vismalskumar0 commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

nhanasi commented Jan 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Vismalskumar0 commented Jan 29, 2026 •

edited

Loading