-
Notifications
You must be signed in to change notification settings - Fork 46
RDK-60409: Component independent Tool Development for Noisy Log detection #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDK-60409: Component independent Tool Development for Noisy Log detection #433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR introduces automated noisy log detection capability to the CI/CD pipeline by integrating an external log analysis tool. The changes standardize log file paths, add log level configuration, and generate HTML reports analyzing test logs for noisy patterns.
Changes:
- Standardized log file paths to
/tmp/log_*.txtpattern for consistent collection - Added
RT_LOG_LEVEL=infoenvironment variable across all test steps - Integrated NoisyLogAnalyzer tool to analyze logs and generate HTML reports
- Improved error handling with
|| truefor killall command
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets host the noise detection yml & python in cmf-actions repo so that everybody can get benefit. Pl work on that.
It can be merged for now; We can submit another change once moved.
Lets address co-pilot review comments on R157 & R162 to R165
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
karuna2git
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of capturing the log files and passing it as input to the logAnalyzer, can we just pass the gtest binary as input to the tool & let the tool exec each test case of defined in the gtest, capture the log and analyze it.
For now, merging it as initial code drop.
Reason for change: For Noisy Log detection
Test Procedure: Tested and verified
Risks: Medium
Signed-off-by: dshett549 [[DEEPTHICHANDRASHEKAR_SHETTY@comcast.com]