rbuscli: fix dead code in hints function #428
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function hints has two 'else if(num == 3)' conditions in sequence. The second one can never be reached because the first one will always catch num == 3 first, making the second condition dead code. The second condition should be 'else if(num == 4)' to handle the case when there are 4 tokens. Coverity: DEADCODE CWE-561: Dead Code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Fixed
Coverity Defect: DEADCODE
CWE: CWE-561 (Dead Code)
Severity: Medium
Function:
hintsFile: utils/rbuscli/rbuscli.c
Root Cause
The function hints has two else if conditions checking for the same value, making the second one unreachable dead code.
The second else if can never be reached because if num equals 3, the first condition will always catch it first.
Changes Made
Changed the second condition from num == 3 to num == 4 to make it reachable and handle the 4-token case properly.
Why This Fix is Correct
Testing