rbus: fixup reverse null check in rtMessage_Retain_test1 #418
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix REVERSE_INULL in rtMessage_Retain_test1
Issues Fixed
unittests/rbus_unit_test_server.cppat line 1320Root Cause
The code was checking if
msgis NULL after already dereferencing it inrtMessage_Retain(msg). This is a logic error - ifmsgwas NULL, the code would crash at line 1317 before reaching the NULL check at line 1320.Changes Made
Removed redundant NULL check:
Before:
After:
Why This Fix is Correct
rtMessage_Create()guaranteesmsgis non-NULLmsgwas NULL, the test would fail atEXPECT_EQ(err, RT_OK)rtMessage_Release()is intentional (testing double release behavior)