rbus: fixup null returns in checkmd5 #417
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix NULL_RETURNS in checkmd5
Issues Fixed
test/rbus/elementTree.cat line 58Root Cause
fopen()can return NULL if the file cannot be opened (e.g., permission denied, disk full). The original code uses the file pointer without checking for NULL, then attempts to close it, which can cause a segmentation fault.Changes Made
Added NULL check before using the file pointer returned by
fopen():Before:
After: