rbus: fix coverity RESOURCE_LEAK in src/rbus/rbus.c #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Coverity CID 110 and CID 138 Generated by RDKDevPilot AI Bot (v2) Root Cause: CID 110 (rbusObject_initFromMessage, line 754): - prop variable was uninitialized - If rbusPropertyList_initFromMessage fails, rbusProperty_Release would operate on uninitialized pointer CID 138 (rbus_getExt, line 3788): - destinations pointer was uninitialized - Error path leaked destinations array and strings - break statement caused execution to continue to cleanup code Changes: 1. CID 110: Initialize prop = NULL (line 721) 2. CID 138: Initialize destinations = NULL (line 3682) 3. CID 138: Add cleanup before error return (lines 3761-3771) 4. CID 138: Return directly instead of break to avoid use-after-free Impact: - Prevents undefined behavior from uninitialized pointers - Prevents memory leak on error path - Prevents use-after-free in cleanup code Supersedes: PR #396, #408 Bot Validation: 95/100 for both issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coverity RESOURCE_LEAK in src/rbus/rbus.c
Improved fix with enhanced bot validation. Supersedes PR #396 and #408.
Coverity Issues
This PR fixes two RESOURCE_LEAK issues in
src/rbus/rbus.c:rbusObject_initFromMessagerbus_getExtRoot Cause
CID 110:
The
propvariable was uninitialized. IfrbusPropertyList_initFromMessagefails to setprop, therbusProperty_Release(prop)call would operate on an uninitialized pointer, causing undefined behavior.CID 138:
The
destinationspointer was uninitialized and leaked when error occurred. Thebreakstatement exited the loop but execution continued to cleanup code, causing potential use-after-free.Changes
CID 110 Fix:
CID 138 Fix:
destinations = NULLImpact
✅ Prevents undefined behavior from uninitialized pointers
✅ Prevents memory leak on error path
✅ Prevents use-after-free in cleanup code
Supersedes: #396, #408