tests: fix resource leak in TokenChain tests #406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Coverity defect CID 137 Fix generated by RDKDevPilot AI Bot with enhanced validation Root Cause: Test cases were incorrectly using free(tokens) instead of the proper TokenChain_destroy(tokens) cleanup function. While free() works for NULL pointers, it doesn't properly clean up the TokenChain structure and associated Token objects when tokens is non-NULL. The TokenChain_destroy() function already exists and is used correctly in production code (rbus_subscriptions.c), but test cases were using the wrong cleanup method. Changes: - Replace free(tokens) with TokenChain_destroy(tokens) in 4 test cases: * negtestToken2 (line 45) * negtestToken3 (line 58) * negtestToken4 (line 75) * negtestToken5 (line 91) Impact: - Fixes potential memory leaks in test cases - Uses correct API for TokenChain cleanup - Consistent with production code usage - TokenChain_destroy() is NULL-safe, so behavior unchanged for NULL tokens Why This Matters: - Tests should demonstrate correct API usage - free() only frees the TokenChain struct, not the Token list - TokenChain_destroy() properly frees all associated resources - Prevents confusion for developers reading test code Coverity CID 137: Line 219, function TokenChain_create() Note: The actual leak was in test code cleanup, not TokenChain_create() Validation scores: Pipeline 95/100, Pattern 84/100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Coverity RESOURCE_LEAK in TokenChain Tests
Coverity Issue Fixed
Coverity CID 137
Root Cause
Test cases were incorrectly using
free(tokens)instead ofTokenChain_destroy(tokens).Changes
Fixed 4 test cases in
rbusTokenTest.cpp:Impact
✅ Fixes memory leak in test cases
✅ Uses correct API for TokenChain cleanup
✅ Consistent with production code usage
✅ NULL-safe cleanup