test: fix coverity RESOURCE_LEAK in testValue_InitGetSetByType

[svc-rdkeportal01]

Fix Coverity RESOURCE_LEAK in testValue_InitGetSetByType

Coverity Issues Fixed

This PR fixes 19 Coverity RESOURCE_LEAK defects in test/rbus/consumer/propertyAPI.c:

Coverity CIDs: 117, 118, 119, 120, 121, 122, 123, 124, 125, 126, 127, 128, 129, 130, 131, 132, 133, 134, 135

• Line: 388 (all issues at same line)

Note: These are Coverity defect IDs, not GitHub issue numbers.

Root Cause

Coverity static analysis limitation with variadic functions:

The original code used variadic cleanup functions:

rbusProperty_Releases(17, vbtrue, vbfalse, vi16_n1234, ...);
rbusObject_Releases(2, obj, obj2);

These functions properly release all resources, but Coverity's data flow analysis cannot track resource cleanup through variadic functions (...).

Why this happens:

• Variadic functions use va_arg() to iterate through arguments
• Static analyzers cannot determine which specific variables map to which va_arg() calls
• This causes false positive resource leak warnings
• This is a known limitation of static analysis tools

The implementation (from src/rbus/rbus_property.c):

void rbusProperty_Releases(int count, ...) {
    va_list vl;
    va_start(vl, count);
    for(i = 0; i < count; ++i) {
        rbusProperty_t prop = va_arg(vl, rbusProperty_t);
        if(prop)
            rtRetainable_release(prop, rbusProperty_Destroy);
    }
    va_end(vl);
}

Coverity cannot trace which of the 17 parameters are released by which va_arg() call.

Changes Made

Replaced variadic calls with individual release calls:

Before:

rbusProperty_Releases(17, vbtrue, vbfalse, vi16_n1234, vu16_4321, ...);
rbusObject_Releases(2, obj, obj2);

After:

// Release all properties individually for Coverity static analysis
// (Coverity cannot track variadic function arguments)
rbusProperty_Release(vbtrue);
rbusProperty_Release(vbfalse);
rbusProperty_Release(vi16_n1234);
rbusProperty_Release(vu16_4321);
// ... 13 more ...
rbusProperty_Release(prop);
rbusProperty_Release(prop2);

// Release objects individually
rbusObject_Release(obj);
rbusObject_Release(obj2);

Impact

• ✅ Functionally equivalent - Same cleanup behavior
• ✅ Makes cleanup explicit for static analysis
• ✅ Fixes all 19 Coverity issues (CID 117-135)
• ✅ No performance impact - Same number of release calls
• ✅ Better code clarity - Explicit is better than implicit

Why 19 Issues?

• 17 rbusProperty_t objects
• 2 rbusObject_t objects
• Total: 19 resources = 19 Coverity CIDs

Each resource was flagged separately because Coverity couldn't verify it was released.

---

Technical Note: This is not a bug in the original code - the variadic functions work correctly. This change is purely to satisfy static analysis tools that cannot trace variadic function arguments.

---

Coverity Defect Details:

• CIDs: 117-135 (19 issues)
• Line: 388 in test/rbus/consumer/propertyAPI.c
• Coverity Checker: RESOURCE_LEAK

[Copilot]

Pull request overview

This PR replaces variadic resource cleanup functions with individual release calls to eliminate 19 Coverity RESOURCE_LEAK false positives in the test suite. The changes address a known limitation where static analysis tools cannot track resource cleanup through variadic functions.

• Replaces rbusProperty_Releases(17, ...) with 17 individual rbusProperty_Release() calls
• Replaces rbusObject_Releases(2, ...) with 2 individual rbusObject_Release() calls
• Adds explanatory comments documenting the reason for the change

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

This line contains trailing whitespace. Remove the trailing spaces to maintain code cleanliness.

Suggested change

[svc-rdkeportal01]

✅ Fixed in commit adc389a

Removed trailing whitespace.