unittests: fix coverity RESOURCE_LEAK in rtMessage test

[svc-rdkeportal01]

Fix Coverity RESOURCE_LEAK in rtMessage Unit Test

Coverity Issues Fixed

This PR fixes two related Coverity RESOURCE_LEAK defects in unittests/rbus_unit_test_server.cpp:

• Coverity CID 115 (line 1260): TestServer_rtmsg_rtMessage_SetMessage_test1_Test::TestBody()
• Coverity CID 116 (line 1260): TestServer_rtmsg_rtMessage_SetMessage_test1_Test::TestBody()

Note: These are Coverity defect IDs, not GitHub issue numbers.

Root Cause

The test function creates an rtMessage object named item at line 1211:

rtMessage_Create(&item);

Later, at line 1233, the pointer is reassigned:

err = rtMessage_GetMessage(req, "config", &item);

This reassignment leaks the original allocation from line 1211. While the function has cleanup at the end (line 1257), it only releases the reassigned pointer, not the original allocation.

Leak Path:

1. Line 1211: rtMessage_Create(&item) - Allocates item Free the memory leaks from rbus gtest - Session & msg #1
2. Line 1233: rtMessage_GetMessage(req, "config", &item) - Overwrites pointer, leaking item Free the memory leaks from rbus gtest - Session & msg #1
3. Line 1257: rtMessage_Release(item) - Only releases item RDKB-44513 : Free the memory leaks from rbus gtest #2

Changes Made

Added rtMessage_Release(item) before the pointer reassignment:

// Line 1233 - Release original before reassignment
rtMessage_Release(item);  // Release original item before reassignment
err = rtMessage_GetMessage(req, "config", &item);

This ensures:

• ✅ Original item is properly released
• ✅ No memory leak when pointer is reassigned
• ✅ Existing cleanup at end still works for reassigned pointer

Why Both CIDs?

Coverity detected this as two separate issues (CID 115 and 116) because there are two leak paths:

1. The original allocation not being freed
2. The pointer reassignment causing the leak

Both are fixed by this single change.

---

Coverity Defect Details:

• CID 115: Line 1260 in unittests/rbus_unit_test_server.cpp
• CID 116: Line 1260 in unittests/rbus_unit_test_server.cpp
• Function: TestServer_rtmsg_rtMessage_SetMessage_test1_Test::TestBody()
• Coverity Checker: RESOURCE_LEAK

[Copilot]

Pull request overview

This PR attempts to fix Coverity RESOURCE_LEAK defects (CID 115 and 116) in the rtMessage unit test by adding an rtMessage_Release(item) call before a pointer reassignment. While the PR correctly identifies a potential memory leak path, the fix introduces a critical double-free bug.

Key Issues:

• The fix adds rtMessage_Release(item) before rtMessage_GetMessage (line 1234), which is expected to fail in this negative test case
• When rtMessage_GetMessage fails, it doesn't modify the item pointer, leaving it dangling after the release
• The existing cleanup code at line 1255 then calls rtMessage_Release(item) again on the already-freed memory, causing a double-free

Recommended Solution:
Set item = NULL after releasing it and add NULL checks in cleanup, or use a separate variable for the negative test case.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Double-free bug introduced by this fix: After releasing item here, the subsequent rtMessage_GetMessage call at line 1234 is expected to fail (returning RT_PROPERTY_NOT_FOUND). When rtMessage_GetMessage fails, it returns early without modifying the output parameter (see src/rtmessage/rtMessage.c:411-412), leaving item as a dangling pointer to already-freed memory. This dangling pointer is then passed to rtMessage_Release(item) again at line 1255, causing a double-free.

Recommended fix: Set item = NULL after releasing it, and add a NULL check before the release at line 1255:

rtMessage_Release(item);
item = NULL;  // Prevent double-free
err = rtMessage_GetMessage(req, "config", &item);
EXPECT_EQ(err, RT_PROPERTY_NOT_FOUND) << "rtMessage_GetMessage failed";

Then at line 1255:

if (item) rtMessage_Release(item);

Alternatively, use a separate variable for this negative test instead of reusing item.

Suggested change

	rtMessage_Release(item); // Release original item before reassignment
	if(item) rtMessage_Release(item); // Release original item before reassignment
	item = NULL; // Prevent double-free

[svc-rdkeportal01]

✅ Fixed in commit 5a311f0

Added:

• item = NULL; after release
• NULL check before final release

Prevents double-free when rtMessage_GetMessage fails.