[RDK-E]: NetworkconnectionRecovery.sh migration to C/C++ Module #274

udaykrishnag · 2026-02-10T20:26:17Z

No description provided.

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>

Signed-off-by: Garpathi, Uday Krishna <UdayKrishna_GARPATHI@comcast.com>

github-actions · 2026-02-10T20:26:30Z

Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.

I have read the CLA Document and I hereby sign the CLA

_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

rdkcmf-jenkins · 2026-02-10T20:34:32Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/274/rdkcentral/networkmanager
Commit: 3fd5c23

Report detail: gist'

Copilot

Pull request overview

This PR introduces a new NetworkConnectionStats Thunder/WPEFramework module (in-process plugin + out-of-process implementation) intended to replace shell-based recovery/diagnostics with a C/C++ implementation that queries NetworkManager via COM-RPC/JSON-RPC and emits telemetry.

Changes:

Adds an out-of-process diagnostics implementation that periodically generates network reports and subscribes to NetworkManager events.
Adds two NetworkManager provider implementations (COM-RPC and JSON-RPC) plus a runtime factory selector.
Integrates the new networkstats/ component into the build and adds configuration/docs assets.

Reviewed changes

Copilot reviewed 27 out of 28 changed files in this pull request and generated 24 comments.

Show a summary per file

File	Description
`networkstats/plugin/ThunderJsonRPCProvider.h`	Declares JSON-RPC-based NetworkManager provider.
`networkstats/plugin/ThunderJsonRPCProvider.cpp`	Implements NetworkManager JSON-RPC calls (GetIPSettings, Ping, event subscribe).
`networkstats/plugin/ThunderComRPCProvider.h`	Declares COM-RPC-based NetworkManager provider.
`networkstats/plugin/ThunderComRPCProvider.cpp`	Implements NetworkManager COM-RPC calls (GetIPSettings, Ping, event subscribe).
`networkstats/plugin/NetworkDataProviderFactory.h`	Factory to select COM-RPC vs JSON-RPC provider based on config.
`networkstats/plugin/NetworkConnectionStatsLogger.h`	Adds a lightweight logging wrapper/macros for the module.
`networkstats/plugin/NetworkConnectionStatsLogger.cpp`	Implements stdout/RDK logger backend for logging wrapper.
`networkstats/plugin/NetworkConnectionStatsImplementation.h`	Declares out-of-process implementation class, threading, and event handlers.
`networkstats/plugin/NetworkConnectionStatsImplementation.cpp`	Implements periodic report generation, telemetry emission, and event-driven triggers.
`networkstats/plugin/NetworkConnectionStats.h`	Declares in-process plugin shell that spawns/aggregates the implementation.
`networkstats/plugin/NetworkConnectionStats.cpp`	Implements plugin lifecycle wiring and COM-RPC aggregation.
`networkstats/plugin/NetworkConnectionStats.config`	Adds example Thunder plugin JSON configuration.
`networkstats/plugin/NetworkConnectionStats.conf.in`	Adds config template for CMake `write_config()` generation.
`networkstats/plugin/Module.h`	Adds module header wiring for Thunder build macros/includes.
`networkstats/plugin/Module.cpp`	Adds module declaration for build reference.
`networkstats/plugin/INetworkData.h`	Defines common interface for network data providers.
`networkstats/plugin/CMakeLists.txt`	Builds the plugin + implementation libraries and installs config.
`networkstats/interface/INetworkConnectionStats.h`	Defines COM-RPC interface for the out-of-process implementation.
`networkstats/interface/CMakeLists.txt`	Generates ProxyStub library for the interface.
`networkstats/definition/NetworkConnectionStats.json`	Adds JSON-RPC API definition/documentation (currently not wired into build).
`networkstats/definition/CMakeLists.txt`	Adds JsonGenerator integration for docs/stubs generation.
`networkstats/THUNDER_PLUGIN_QUICK_REFERENCE.md`	Adds quick-reference documentation for the intended architecture.
`networkstats/THUNDER_PLUGIN_CONVERSION.md`	Adds conversion notes from standalone app to Thunder module.
`networkstats/README_INTERNAL_PLUGIN.md`	Describes internal-only plugin behavior/configuration and telemetry outputs.
`networkstats/NetworkStatsDesign_ver1.md`	Provides high-level design diagrams and operational flow.
`networkstats/CMakeLists.txt`	Adds `networkstats` sub-project build entrypoint.
`CMakeLists.txt`	Adds `USE_TELEMETRY` option and includes `networkstats` in the top-level build.
`.DS_Store`	Adds an unintended macOS metadata file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-10T20:37:48Z

networkstats/plugin/ThunderJsonRPCProvider.h

+#ifndef __THUNDERPROVIDER_H__
+#define __THUNDERPROVIDER_H__


The include guard macro name starts with double underscores (THUNDERPROVIDER_H), which is reserved for the implementation in C/C++. Please rename it to a non-reserved identifier (e.g., THUNDER_JSONRPC_PROVIDER_H).

Copilot · 2026-02-10T20:37:49Z

networkstats/plugin/ThunderComRPCProvider.h

+#ifndef __THUNDERCOMRPCPROVIDER_H__
+#define __THUNDERCOMRPCPROVIDER_H__


The include guard macro (THUNDERCOMRPCPROVIDER_H) begins with double underscores, which are reserved identifiers in C/C++. Please rename it to a non-reserved macro to avoid undefined behavior/toolchain issues.

Copilot · 2026-02-10T20:37:49Z

networkstats/plugin/ThunderJsonRPCProvider.cpp

+/* @brief Get DNS server entries */
+std::string NetworkJsonRPCProvider::getDnsEntries()
+{
+    // TODO: Implement DNS entries retrieval
+    return "";
+}


getDnsEntries() is currently a stub that always returns an empty string. Since this provider can be selected at runtime via providerType=jsonrpc, this will lead to incorrect diagnostics when that provider is used; please implement DNS retrieval (or remove the method from the interface if it’s not needed).

Copilot · 2026-02-10T20:37:49Z

networkstats/plugin/NetworkConnectionStatsLogger.cpp

+        struct tm* lt;
+        const char* fileName = trimPath(file);
+
+        if (gDefaultLogLevel < level)
+            return;
+
+        gettimeofday(&tv, NULL);
+        lt = localtime(&tv.tv_sec);
+
+        printf("%.2d:%.2d:%.2d.%.6lld [%-5s] [PID=%d] [TID=%d] [%s +%d] %s : %s\n", lt->tm_hour, lt->tm_min, lt->tm_sec, (long long int)tv.tv_usec, levelMap[level], getpid(), gettid(), fileName, line, func, formattedLog);


logPrint() uses localtime(), which is not thread-safe and can cause data races/corrupted timestamps when logging from multiple threads (this plugin starts several threads). Please use localtime_r() (or gmtime_r()) with a stack-allocated tm instead.

Suggested change

struct tm* lt;

const char* fileName = trimPath(file);

if (gDefaultLogLevel < level)

return;

gettimeofday(&tv, NULL);

lt = localtime(&tv.tv_sec);

printf("%.2d:%.2d:%.2d.%.6lld [%-5s] [PID=%d] [TID=%d] [%s +%d] %s : %s\n", lt->tm_hour, lt->tm_min, lt->tm_sec, (long long int)tv.tv_usec, levelMap[level], getpid(), gettid(), fileName, line, func, formattedLog);

struct tm lt;

const char* fileName = trimPath(file);

if (gDefaultLogLevel < level)

return;

gettimeofday(&tv, NULL);

localtime_r(&tv.tv_sec, &lt);

printf("%.2d:%.2d:%.2d.%.6lld [%-5s] [PID=%d] [TID=%d] [%s +%d] %s : %s\n", lt.tm_hour, lt.tm_min, lt.tm_sec, (long long int)tv.tv_usec, levelMap[level], getpid(), gettid(), fileName, line, func, formattedLog);

Copilot · 2026-02-10T20:37:50Z

networkstats/plugin/NetworkConnectionStatsLogger.cpp

+        printf("%.2d:%.2d:%.2d.%.6lld [%-5s] [PID=%d] [TID=%d] [%s +%d] %s : %s\n", lt->tm_hour, lt->tm_min, lt->tm_sec, (long long int)tv.tv_usec, levelMap[level], getpid(), gettid(), fileName, line, func, formattedLog);
+        fflush(stdout);


This code calls gettid(), but gettid() is not a portable/POSIX API and may be unavailable depending on libc/kernel headers, causing build failures. Consider using syscall(SYS_gettid) (since you already include <sys/syscall.h>) or conditionally compiling the TID output.

Copilot · 2026-02-10T20:37:54Z

networkstats/THUNDER_PLUGIN_CONVERSION.md

+#### COM-RPC Interface
+- **INetworkConnectionStats.h** - Defines the COM-RPC interface with:
+  - INetworkConnectionStats interface with all network diagnostic methods
+  - INotification sub-interface for event notifications
+  - Proper interface IDs and stubgen annotations
+
+#### Plugin Main Class
+- **NetworkConnectionStats.h** - Plugin header with:
+  - Inherits from `PluginHost::IPlugin` and `PluginHost::JSONRPC`
+  - Notification handler for RPC connection lifecycle and events
+  - Interface aggregation for COM-RPC
+
+- **NetworkConnectionStats.cpp** - Plugin implementation with:
+  - IPlugin lifecycle methods (Initialize, Deinitialize, Information)
+  - RPC connection management
+  - JSON-RPC registration
+  - Notification forwarding


This conversion document states the plugin inherits PluginHost::JSONRPC, registers JSON-RPC methods, and provides a JSON-RPC API spec. The current codebase implements an internal-only IPlugin + COM-RPC aggregate and the networkstats/definition subdir is not built. Please update the document to reflect the implemented architecture (or implement the described JSON-RPC layer).

Copilot · 2026-02-10T20:37:54Z

networkstats/definition/NetworkConnectionStats.json

+{
+  "$schema": "interface.schema.json",
+  "jsonrpc": "2.0",
+  "info": {
+    "title": "NetworkConnectionStats API",
+    "class": "NetworkConnectionStats",
+    "description": "NetworkConnectionStats plugin for network diagnostics and monitoring"
+  },


This JSON-RPC definition describes a public API surface (methods/events) that is not implemented by the current plugin (which is internal-only and does not derive from PluginHost::JSONRPC). Please either update this spec to match the implemented interfaces, or remove/disable it to avoid generating misleading documentation/stubs later.

Copilot · 2026-02-10T20:37:54Z

networkstats/plugin/NetworkConnectionStatsImplementation.cpp

+            } else {
+                auto factoryType = NetworkDataProviderFactory::ParseProviderType(providerType);
+                std::string typeName = NetworkDataProviderFactory::GetProviderTypeName(factoryType);
+                NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());


If m_provider->Initialize() fails, Configure() returns an error but leaves m_provider allocated and in a partially initialized state. Please delete/reset m_provider (and avoid starting any threads) on this failure path to prevent leaks and accidental later use.

Suggested change

NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());

NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());

// Clean up the partially initialized provider to prevent leaks and later accidental use

delete m_provider;

m_provider = nullptr;

Copilot · 2026-02-10T20:37:55Z

networkstats/plugin/NetworkConnectionStatsImplementation.h

+#include <atomic>
+#include <queue>
+#include <mutex>
+#include <condition_variable>


NetworkConnectionStatsImplementation.h uses std::list (_notificationCallbacks) but does not include . Please add the missing standard header to avoid compile failures depending on indirect includes.

Suggested change

#include <condition_variable>

#include <condition_variable>

#include <list>

Copilot · 2026-02-10T20:37:55Z

networkstats/plugin/ThunderJsonRPCProvider.h

+#include "INetworkData.h"
+#include "Module.h"
+#include <string>
+#include <core/JSON.h>


This header declares std::shared_ptr (m_networkManagerClient) but never includes . Please include here to avoid build failures due to indirect include order.

Suggested change

#include <core/JSON.h>

#include <core/JSON.h>

#include <memory>

#include <functional>

rdkcmf-jenkins · 2026-02-11T12:02:23Z

b'## Blackduck scan failure details

Summary: 0 violations, 0 files pending approval, 1 file pending identification.

Protex Server Path: /home/blackduck/github/networkmanager/274/rdkcentral/networkmanager
Commit: 3fd5c23

Report detail: gist'

rdkcmf-jenkins · 2026-02-11T12:05:30Z

b'## WARNING: A Blackduck scan failure has been waived

A prior failure has been upvoted

Upvote reason: OK
Commit: 3fd5c23
'

mhughesacn · 2026-02-11T16:04:59Z

I have checked the fossid failures: There is one match to rdkcentral which is not of interest. The other two matches are from jmanc3/winbar and Karunakaran has pointed out that jmanc3 has used original code from rdkcentral (committed 17-Nov-24) which jmanc3 then committed several months later on 16-Jun-25. So the matches are a non-issue.

Garpathi, Uday Krishna and others added 9 commits December 10, 2025 11:37

RDK-59986 : NetworkconnectionRecovery.sh migration to C/C++ Module

08dd34c

RDK-59986 : NetworkconnectionRecovery.sh migration to C/C++ Module

ce7a8c7

Initial Skeleton.

8a6412e

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>

Initial Skeleton.

24d19c1

Signed-off-by: Balaji Punnuru <Balaji_Punnuru@comcast.com>

Update 1

11098ba

Signed-off-by: Garpathi, Uday Krishna <UdayKrishna_GARPATHI@comcast.com>

Update NetworkConnectionStats.h

3d487e3

Merge branch 'develop' into topic/RDK-59986

2b39dac

Merge branch 'develop' into topic/RDK-59986

9708046

Merge branch 'develop' into topic/RDK-59986

bd40724

udaykrishnag requested a review from a team as a code owner February 10, 2026 20:26

Copilot AI review requested due to automatic review settings February 10, 2026 20:26

Copilot started reviewing on behalf of udaykrishnag February 10, 2026 20:27 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

Merge branch 'develop' into topic/RDK-59986

b705641

udaykrishnag force-pushed the topic/RDK-59986 branch from 3fd5c23 to b705641 Compare February 11, 2026 18:50

Merge branch 'develop' into topic/RDK-59986

74dd5cb

		#ifndef __THUNDERCOMRPCPROVIDER_H__
		#define __THUNDERCOMRPCPROVIDER_H__

		printf("%.2d:%.2d:%.2d.%.6lld [%-5s] [PID=%d] [TID=%d] [%s +%d] %s : %s\n", lt->tm_hour, lt->tm_min, lt->tm_sec, (long long int)tv.tv_usec, levelMap[level], getpid(), gettid(), fileName, line, func, formattedLog);
		fflush(stdout);

-                NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());
+                NSLOG_ERROR("Failed to initialize %s provider", typeName.c_str());
+                // Clean up the partially initialized provider to prevent leaks and later accidental use
+                delete m_provider;
+                m_provider = nullptr;

	#include <condition_variable>
	#include <condition_variable>
	#include <list>

[RDK-E]: NetworkconnectionRecovery.sh migration to C/C++ Module #274

Are you sure you want to change the base?

[RDK-E]: NetworkconnectionRecovery.sh migration to C/C++ Module #274

Uh oh!

Conversation

udaykrishnag commented Feb 10, 2026

Uh oh!

github-actions bot commented Feb 10, 2026

Uh oh!

rdkcmf-jenkins commented Feb 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

rdkcmf-jenkins commented Feb 11, 2026

Uh oh!

rdkcmf-jenkins commented Feb 11, 2026

Uh oh!

mhughesacn commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants