RDKEMW-13401: Migration Device connects to Wi‑Fi instead of Ethernet

[gururaajar]

Reason for Change: As the interface type is not checked before assigning the firstconnection. Firstconnection is getting assigned with a valid wifi connection when both ethernet and wifi are connected. So even when Wired connection is activated we end in activating Wifi connection. Added interface check to avoid this
Test Procedure: Migration test scenario
Priority: P1
Risks: Medium

[Copilot]

Pull request overview

Fixes migration behavior where activating a wired interface could incorrectly fall back to a Wi‑Fi connection when both Wi‑Fi and Ethernet are available, by filtering the “first connection” fallback by interface type.

Changes:

• Only assign firstConnection when the connection type matches the requested interface (wlan vs eth).
• Add Ethernet connection handling (802-3-ethernet) alongside existing Wi‑Fi handling (802-11-wireless).

Comments suppressed due to low confidence (1)

plugin/gnome/NetworkManagerGnomeWIFI.cpp:878

• When selecting knownConnection by matching connId to knowConnectionID, the code does not verify that the connection type matches the requested interface (iface). If a Wi‑Fi profile happens to share the same connection ID as the wired profile (IDs are user-editable), this can still select and activate the wrong connection, reintroducing the migration issue. Consider additionally checking connTypStr (or re-fetching nm_connection_get_connection_type) against the expected type for iface before assigning knownConnection/breaking.

                }

                if (connId != NULL && strcmp(connId, knowConnectionID.c_str()) == 0)
                {
                    knownConnection = g_object_ref(connection);

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.