RDKEMW-13122: Wi‑Fi networks in the picker are not ordered by signal strength

[gururaajar]

Reason for change: Updated the onAvailableSSID to return strength and frequency as numbers so that the UI will do the sorting.
Test Procedure: Check the onAvailableSSID returns strength and frequency as numbers
Priority:P1
Risks: Medium
Signed-off-by: Gururaaja ESRGururaja_ErodeSriranganRamlingham@comcast.com

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

plugin/NetworkManagerImplementation.cpp:942

• RSSI clamping updates readRssi, but the exported/output strength value is not updated to reflect the clamped value. This can lead to inconsistent output/logging (and later SNR mapping uses strength), especially when RSSI is out of range. Consider assigning strength = readRssi whenever clamping occurs (similar to how noise is updated).

            /* Check the RSSI is within range between -10 and -100 dbm*/
            if (readRssi >= 0 || readRssi < -100) {
                NMLOG_WARNING("Received RSSI (%d dBm) is out of valid range (-10 to -100 dBm); Resetting to default", readRssi);
                if (readRssi >= 0) {
                    readRssi = -10;

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 23 out of 23 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

plugin/NetworkManagerImplementation.cpp:947

• After clamping readRssi to the valid range, the clamped value is not written back to the strength output parameter. This means the method can return/log an out-of-range RSSI even though SNR/quality calculations used the clamped readRssi, and the fallback path that maps invalid SNR uses the unclamped strength. Propagate the clamp result back into strength (and use the clamped value for the invalid-SNR fallback) so outputs remain consistent with the calculations.

            /* Check the RSSI is within range between -10 and -100 dbm*/
            if (readRssi >= 0 || readRssi < -100) {
                NMLOG_WARNING("Received RSSI (%d dBm) is out of valid range (-10 to -100 dBm); Resetting to default", readRssi);
                if (readRssi >= 0) {
                    readRssi = -10;
                }
                else if (readRssi < -100) {
                    readRssi = -100;
                }
            }

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[karuna2git]

Based on the discussion with RDKCentral compliance team the fossid failure on this PR is something can go ahead as we own the code. The other team which uses our code will be requested to give credit to us.

Hi Karunakaran,

This is very interesting!  The two code blocks are clearly the same, although fossid in this usage doesn't make it easy to see.  As this is your own code, you need take no action in networkmanager.  There is clearly a license violation here, because the code is used without credit, even though Apache-2 code can be sucked into GPLv3 projects.

Thanks,