feat: Enhance soft-assert log messages in reports by Rajashekaravm · Pull Request #438 · rdkcentral/firebolt-certification-suite

Rajashekaravm · 2025-06-16T11:45:58Z

No description provided.

CLAassistant · 2025-06-16T11:46:06Z

All committers have signed the CLA.

github-actions · 2025-06-16T11:46:56Z

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  805:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  806:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  808:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  810:1   error  Replace `····` with `······`                                                                                                                                                                                                                                                             prettier/prettier
  815:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  816:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  818:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  820:5   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  825:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  826:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  828:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  830:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  835:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  836:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  838:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  840:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  845:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  846:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  848:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  850:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  855:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  856:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  858:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  860:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  865:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  866:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  868:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  870:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  875:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  876:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  878:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  880:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  885:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  886:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  888:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  895:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  896:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                 prettier/prettier
  898:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  905:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  906:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                 prettier/prettier
  908:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  915:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  916:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                 prettier/prettier
  918:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  920:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  921:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  922:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  923:5   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  924:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  927:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  928:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                 prettier/prettier
  930:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  932:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  937:27  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  938:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                                                                                                                  prettier/prettier
  940:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                                                                                                        prettier/prettier
  942:25  error  Insert `·`                                                                                                                                                                                                                                                                               prettier/prettier
  947:29  error  Replace `({·functionName,·actual,·expected,·object,·haystack,·needle,·value,·expression,·message` with `⏎······({⏎········functionName,⏎········actual,⏎········expected,⏎········object,⏎········haystack,⏎········needle,⏎········value,⏎········expression,⏎········message,⏎······`  prettier/prettier
  948:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  949:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  950:7   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  951:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  952:1   error  Replace `······` with `········`                                                                                                                                                                                                                                                         prettier/prettier
  953:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  954:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  955:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  956:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  957:1   error  Replace `········` with `··········`                                                                                                                                                                                                                                                     prettier/prettier
  958:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  959:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  960:7   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  961:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  962:1   error  Replace `······` with `········`                                                                                                                                                                                                                                                         prettier/prettier
  963:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  964:1   error  Replace `······` with `········`                                                                                                                                                                                                                                                         prettier/prettier
  965:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  966:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  967:9   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  968:7   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  969:1   error  Replace `········` with `··········`                                                                                                                                                                                                                                                     prettier/prettier
  970:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  971:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  972:7   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  973:1   error  Replace `········fireLog.assert(expression,` with `··········fireLog.assert(expression,·`                                                                                                                                                                                                prettier/prettier
  974:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  975:1   error  Insert `··`                                                                                                                                                                                                                                                                              prettier/prettier
  976:7   error  Replace `}⏎·····` with `··}`                                                                                                                                                                                                                                                             prettier/prettier
  978:7   error  Replace `······` with `}`                                                                                                                                                                                                                                                                prettier/prettier
  979:5   error  Delete `}`                                                                                                                                                                                                                                                                               prettier/prettier

✖ 89 problems (89 errors, 0 warnings)
  89 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

github-actions · 2025-06-17T13:29:17Z

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
   812:6   error  Insert `·`                                                                                                                                                                                       prettier/prettier
   818:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   825:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   827:1   error  Replace `····` with `······`                                                                                                                                                                     prettier/prettier
   832:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   839:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   841:1   error  Replace `····` with `······`                                                                                                                                                                     prettier/prettier
   846:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   853:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   855:1   error  Replace `····` with `······`                                                                                                                                                                     prettier/prettier
   860:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   867:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   869:5   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   874:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   881:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   883:5   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   888:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   895:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   897:5   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   902:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   909:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   911:5   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   916:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   923:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   930:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                         prettier/prettier
   937:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   944:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                         prettier/prettier
   946:7   error  Delete `·`                                                                                                                                                                                       prettier/prettier
   951:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   958:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                         prettier/prettier
   965:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   967:1   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   968:1   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   969:5   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   970:1   error  Replace `····` with `······`                                                                                                                                                                     prettier/prettier
   971:1   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   975:7   error  Replace `(assertionType·===·'soft')` with `·(assertionType·===·'soft')·`                                                                                                                         prettier/prettier
   982:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   984:1   error  Insert `··`                                                                                                                                                                                      prettier/prettier
   989:7   error  Replace `(assertionType·==='soft')` with `·(assertionType·===·'soft')·`                                                                                                                          prettier/prettier
   992:27  error  Insert `·`                                                                                                                                                                                       prettier/prettier
   996:6   error  Replace `⏎····else` with `·else·`                                                                                                                                                                prettier/prettier
   998:25  error  Insert `·`                                                                                                                                                                                       prettier/prettier
  1003:5   error  Delete `⏎····`                                                                                                                                                                                   prettier/prettier
  1005:23  error  Replace ``Assertion·failed·with·${this.errors.length}·errors:·
${this.errors.join('
')}`);` with `⏎········`Assertion·failed·with·${this.errors.length}·errors:·
${this.errors.join('
')}``  prettier/prettier
  1006:5   error  Replace `}` with `··);`                                                                                                                                                                          prettier/prettier
  1007:5   error  Insert `}⏎`                                                                                                                                                                                      prettier/prettier
  1009:5   error  Replace `·this.errors·=·[];⏎` with `this.errors·=·[];`                                                                                                                                           prettier/prettier
  1026:26  error  Delete `⏎`                                                                                                                                                                                       prettier/prettier

✖ 49 problems (49 errors, 0 warnings)
  49 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

neeradanelxsi · 2025-06-18T18:33:31Z

-  isNotEmpty(object, message) {
-    assert.isNotEmpty(object, message);
+  isBoolean(value, message, assertionType) {
+    if (assertionType === 'soft') {


cant we use constants for 'soft'

As per the review made the changes and tested, Its working fine

github-actions · 2025-11-17T05:48:40Z

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

github-actions · 2025-11-17T05:49:31Z

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  1011:7  error  Parsing error: Identifier 'fireLog' has already been declared

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

github-actions · 2025-11-17T05:49:54Z

Build error occurred while running sample test with the following errors:

Error: Build failed with 1 error:
cypress/support/cypress-support/src/utils.js:1011:6: ERROR: The symbol "fireLog" has already been declared
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)
--
Error: Build failed with 1 error:
cypress/support/cypress-support/src/utils.js:1011:6: ERROR: The symbol "fireLog" has already been declared
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)

For more information on our testing policies, please see our Testing-Guide.

github-actions · 2025-11-17T05:51:03Z

Invalid PR title. It must start with feat: or fix: or BREAKING CHANGE: or feat(): or fix(): or BREAKING CHANGE():. Please see our Contributing-Guide.

Enhance soft-assert log message

794413d

Handling error messages

006b8dc

Resolved the lint errors

dbe98f1

neeradanelxsi reviewed Jun 18, 2025

View reviewed changes

neeradanelxsi previously approved these changes Jun 18, 2025

View reviewed changes

Addressed the review comment

cebf4d8

Rajashekaravm dismissed neeradanelxsi’s stale review via cebf4d8 June 19, 2025 07:12

jbigel previously approved these changes Jun 20, 2025

View reviewed changes

neeradanelxsi previously approved these changes Jun 20, 2025

View reviewed changes

ibrahimshuail approved these changes Jun 23, 2025

View reviewed changes

Resolve merge conflicts

e54d43b

Rajashekaravm dismissed stale reviews from neeradanelxsi and jbigel via e54d43b November 17, 2025 05:48

Rajashekaravm changed the base branch from main to dev November 17, 2025 05:50

Rajashekaravm changed the title ~~Enhance soft-assert log messages in reports~~ feat: Enhance soft-assert log messages in reports Nov 17, 2025

Update firelog

2bc8e1c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enhance soft-assert log messages in reports#438

feat: Enhance soft-assert log messages in reports#438
Rajashekaravm wants to merge 6 commits intodevfrom
EnhnceSoftAssert

Rajashekaravm commented Jun 16, 2025

Uh oh!

CLAassistant commented Jun 16, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 17, 2025

Uh oh!

neeradanelxsi Jun 18, 2025

Uh oh!

Rajashekaravm Jun 19, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

Rajashekaravm commented Jun 16, 2025

Uh oh!

CLAassistant commented Jun 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jun 16, 2025

Uh oh!

github-actions Bot commented Jun 17, 2025

Uh oh!

neeradanelxsi Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Rajashekaravm Jun 19, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

github-actions Bot commented Nov 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CLAassistant commented Jun 16, 2025 •

edited

Loading

github-actions Bot commented Nov 17, 2025 •

edited

Loading