feat: Singleton PubSub Client

[AdityaKasar]

No description provided.

[ksentak]

Why did we change from fireLog.fail to assert here?

[ksentak]

Left a couple of comments for requested changes. Also, I want to have conversations about why there needed to be changes to how parsing was done for healthcheck and report. This alerts me that something might not be right. Perhaps what we incorrectly changed how an incoming message is parsed or something so we need to make sure that isn't the case.

[AdityaKasar]

Also, I want to have conversations about why there needed to be changes to how parsing was done for healthcheck and report. This alerts me that something might not be right. Perhaps what we incorrectly changed how an incoming message is parsed or something so we need to make sure that isn't the case

Updated _handleIncomingMessage() logic in Websocket to handle response from (app) comcast.test.firecer differently.
if(data.topic.includes("comcast.test.firecert")){ callback(typeof payload === 'string' ? payload : JSON.stringify(payload), data.headers); }else{ callback(typeof data === 'string' ? data : JSON.stringify(data), data.headers); }

[ksentak]

Minimal changes requested here. Otherwise looks good!

[ksentak]

This should work without issue. In the config helper we may want to make a comment to ensure the order of the exports stays the same. Otherwise this would break. Although I dont anticipate any other transportation methods.

[AdityaKasar]

added comment in transportLayers/index.js

[kschrief]

This is problematic. It works for us but any future config modules would be blind to this issue.

This needs to be resolved before this is merged in.

[AdityaKasar]

made changes to address the review comment.

[kschrief]

This is problematic. It works for us but any future config modules would be blind to this issue.

This needs to be resolved before this is merged in.

[github-actions]

Hello feature run failed with the following errors:

  1) An uncaught error was detected outside of a test:
     TypeError: The following error originated from your test code, not from Cypress.

  > Cannot read properties of undefined (reading 'default')

When Cypress detects uncaught errors originating from your test code it will automatically fail the current test.

Cypress could not associate this error to any specific test.

We dynamically generated a new test to display this failure.
      at main_default (http://localhost:45779/__cypress/tests?p=cypress/support/e2e.js:69732:48)
      at eval (http://localhost:45779/__cypress/tests?p=cypress/support/e2e.js:71475:3)
      at eval (http://localhost:45779/__cypress/tests?p=cypress/support/e2e.js:71486:3)
      at eval (<anonymous>)

For more information on our testing policies, please see our Testing-Guide.

[kschrief]

I see no changes in the default config module. This must be taken into account before we can approve this.

[github-actions]

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/defaultModule/appTransport/index.js
  20:1  error  Delete `⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

[github-actions]

Build error occurred while running sample test with the following errors:

Error: Build failed with 1 error:
node_modules/configModule/appTransport/index.js:19:25: ERROR: Could not resolve "fcs-config-helper/transportLayers/linchpin"
    at failureErrorWithLog (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1636:15)
    at /home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1048:25
    at runOnEndCallbacks (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1471:45)
    at buildResponseToResult (/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/node_modules/esbuild/lib/main.js:1046:7)

For more information on our testing policies, please see our Testing-Guide.