Conversation
|
Issue with linting detected. For more information on our linting policies, please see our Linting-Guide. |
|
Issue with linting detected. For more information on our linting policies, please see our Linting-Guide. |
|
Issue with linting detected. For more information on our linting policies, please see our Linting-Guide. |
| GETAPPDATA: 'fcs.getAppData', | ||
| SENDKEYPRESS: 'fcs.sendKeyPress', | ||
| SENDVOICECOMMAND: 'fcs.sendVoiceCommand', | ||
| FINDLOGPATTERN: 'fcs.findLogPattern', |
There was a problem hiding this comment.
Again this seems like a good candidate for cy.callConfigModule
There was a problem hiding this comment.
As discussed earlier, this will be handled in a separate ticket (FIRECERT-3066). Since it involves multiple design changes.
| }); | ||
| } | ||
| ); | ||
|
|
There was a problem hiding this comment.
https://github.com/comcast-firebolt/fcs-config-helper/pull/145/files#diff-accef24b9eb5b3a7730f454512ad1262977c0fe8e648fbf5c4c7514e729ee0adR229
This glue code is ported into fcs-config-helper
There was a problem hiding this comment.
Why do we need to move this to configHelper? There is nothing proprietary in it.
There was a problem hiding this comment.
Initially, this glue code was placed in fcs under validations.js. However, during development, a new requirement came to create a flag enableVideoChecker which will be set as false by default so that conditionally we can skip TMagiQ validation when the flag was set to false and only execute TMagiQ validation if the flag is set to true. (feat: Continue watching implementation by Abhishk123 · Pull Request #401 · rdkcentral/firebolt-certification-suite)
Since this logic involves proprietary TMagiQ information, it was not appropriate to keep it in fcs. So, we moved it to fcs-config-helper.
Later, I noticed that logs to skip TMagiQ validation had been shifted to custom validation. (https://github.com/comcast-firebolt/fcs-config-helper/blob/11bf1e4ddb2b90bb16b8afe9288d771323ad859c/customValidations/tmagiQValidations.js#L77) Now the As per Jacob’s suggestion, it made sense to move the glue code back to fcs as it currently don't have proprietary info. So moved the glue code back to fcs.
|
Anitta Antony seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
No description provided.