Skip to content

feat: Continue watching implementation#401

Open
Abhishk123 wants to merge 28 commits intodevfrom
continueWatching
Open

feat: Continue watching implementation#401
Abhishk123 wants to merge 28 commits intodevfrom
continueWatching

Conversation

@Abhishk123
Copy link
Copy Markdown
Contributor

No description provided.

Comment thread cypress/support/step_definitions/validations.js Outdated
@github-actions
Copy link
Copy Markdown

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  2046:4  error  Insert `⏎`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/testSetup.js
  320:1  error  Delete `⏎`  prettier/prettier
  349:4  error  Insert `⏎`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  343:16  error  Delete `·`  prettier/prettier
  344:30  error  Delete `·`  prettier/prettier
  348:63  error  Delete `·`  prettier/prettier
  349:67  error  Delete `·`  prettier/prettier

✖ 7 problems (7 errors, 0 warnings)
  7 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 9, 2025

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  382:1  error  Delete `··`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 6, 2025

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  548:25  error  Insert `,`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

GETAPPDATA: 'fcs.getAppData',
SENDKEYPRESS: 'fcs.sendKeyPress',
SENDVOICECOMMAND: 'fcs.sendVoiceCommand',
FINDLOGPATTERN: 'fcs.findLogPattern',
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again this seems like a good candidate for cy.callConfigModule

Copy link
Copy Markdown
Contributor

@Anitta98 Anitta98 Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed earlier, this will be handled in a separate ticket (FIRECERT-3066). Since it involves multiple design changes.

});
}
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to move this to configHelper? There is nothing proprietary in it.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, this glue code was placed in fcs under validations.js. However, during development, a new requirement came to create a flag enableVideoChecker which will be set as false by default so that conditionally we can skip TMagiQ validation when the flag was set to false and only execute TMagiQ validation if the flag is set to true. (feat: Continue watching implementation by Abhishk123 · Pull Request #401 · rdkcentral/firebolt-certification-suite)
Since this logic involves proprietary TMagiQ information, it was not appropriate to keep it in fcs. So, we moved it to fcs-config-helper.
Later, I noticed that logs to skip TMagiQ validation had been shifted to custom validation. (https://github.com/comcast-firebolt/fcs-config-helper/blob/11bf1e4ddb2b90bb16b8afe9288d771323ad859c/customValidations/tmagiQValidations.js#L77) Now the As per Jacob’s suggestion, it made sense to move the glue code back to fcs as it currently don't have proprietary info. So moved the glue code back to fcs.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Jun 19, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 5 committers have signed the CLA.

✅ Abhishk123
✅ anjalimukundan
✅ Nandana-NNR
❌ Anitta Antony
❌ Anitta98


Anitta Antony seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants