RDKB-61836: eth1 LAN client not getting IP address when RF is disconn… #38
Conversation
…ected. Reason for change: Exclude XB9/XB10 from changes to bring down/up ethwan interface. The change is only applicable to the 3390 chipset devices. Test Procedure: Build & verify. Risks: None Priority: P1 Signed-off-by: Jayant_Rai2@comcast.com
|
Changes look good to me |
There was a problem hiding this comment.
Pull request overview
Updates platform-specific compile-time guards to prevent Ethernet WAN/LAN interface state workarounds from running on XB10, addressing the “eth1 LAN client not getting IP when RF is disconnected” scenario by avoiding interface down/up behavior on excluded platforms.
Changes:
- Exclude
_XB10_PRODUCT_REQ_from the “set LAN eth interface UP after AddToBridge” workaround path. - Exclude
_XB10_PRODUCT_REQ_from the “EthWan disabled -> force ethwan admin DOWN” workaround underWAN_MANAGER_UNIFICATION_ENABLED.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
|
|
||
| #if (defined (_XB6_PRODUCT_REQ_) || defined (_CBR2_PRODUCT_REQ_)) | ||
| #if (defined (_XB6_PRODUCT_REQ_) || defined (_CBR2_PRODUCT_REQ_)) && !defined(_XB10_PRODUCT_REQ_) |
There was a problem hiding this comment.
PR description says to exclude both XB9 and XB10 from the bring-down/bring-up workaround, but this conditional only excludes XB10_PRODUCT_REQ. Either update the description to match the actual change, or extend the guard to also exclude XB9 (if that’s intended for this fix).
There was a problem hiding this comment.
XB9 uses XB10_PRODUCT_REQ flag as well so no XB9 specific flag is needed.
|
|
||
|
|
||
| #if (defined (_XB6_PRODUCT_REQ_) || defined (_CBR2_PRODUCT_REQ_)) && defined(WAN_MANAGER_UNIFICATION_ENABLED) //Changing only the WanUnification behaviour | ||
| #if (defined (_XB6_PRODUCT_REQ_) || defined (_CBR2_PRODUCT_REQ_)) && defined(WAN_MANAGER_UNIFICATION_ENABLED) && !defined(_XB10_PRODUCT_REQ_) //Changing only the WanUnification behaviour |
There was a problem hiding this comment.
PR description mentions excluding XB9/XB10, but this guard only excludes XB10_PRODUCT_REQ. Please align the code and PR intent (either update the description or also exclude XB9 here if the workaround should not run on XB9).
3 participants
…ected.
Reason for change: Exclude XB9/XB10 from changes to bring down/up ethwan interface.
Test Procedure: Build & verify.
Risks: None
Priority: P1
Signed-off-by: Jayant_Rai2@comcast.com