Skip to content

Test #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
yuvaramachandran-gurusamy wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Test #88

yuvaramachandran-gurusamy wants to merge 22 commits into from

Conversation

@yuvaramachandran-gurusamy
Copy link
Contributor

@yuvaramachandran-gurusamy yuvaramachandran-gurusamy commented Jul 4, 2025

No description provided.

yuvaramachandran-gurusamy and others added 19 commits June 11, 2025 20:56
@yuvaramachandran-gurusamy
RDKEMW-1017: MiracastService COMRPC Support
befc47b 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017: MiracastService CMake change
4ba4e51 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1018: MiracastPlayer COMRPC Support
52042fa 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Changes as per Miracast interface files
567cc4c 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Fix build issue
b3732c6 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Merge branch 'develop' of github.com:rdkcentral/entservices-casting i…
2b9c5e5 
…nto feature/RDKEMW-1017_1018_miracast_comrpc_support
@yuvaramachandran-gurusamy
RDKEMW-1018: Fix the random crash issue and logging update
61215a4 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Updated Miracast API prototype
70d5f08 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1018: Fix the SetWesterosEnvironment issue and logging update
1cd20a0 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1018: Update MiracastPlayer.h with indentation
cbd10e9
@yuvaramachandran-gurusamy
RDKEMW-1018: Modified MiracastRTSPMsg variables order to fix SIGBUS i…
4cfedf2 
…ssue

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Removed the SetLogging and added SetEnvArugm…
c6415b9 
…ents API

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Updated as per review comments
2eef64a 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Disable l1 test for Miracast
67b9b8c 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: entservices-apis should cloned from develop
163b6c5 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Fix L1 test failures
3df1491 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Enable L1 test for Miracast plugins
c1874c1 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
RDKEMW-1017 RDKEMW-1018: Updated the L1 unittest coverage
c9c3a75 
Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>
@yuvaramachandran-gurusamy
Update MiracastServiceImplementation.cpp
334f80e 
Test
@yuvaramachandran-gurusamy yuvaramachandran-gurusamy requested a review from a team as a code owner July 4, 2025 04:19
rdkcmf-jenkins
rdkcmf-jenkins reviewed Jul 4, 2025
View reviewed changes
Miracast/MiracastPlayer/MiracastPlayerImplementation.cpp
m_video_sink_rect = {0, 0, 1920, 1080}; // Default video rectangle
m_GstPlayer = nullptr;
MIRACAST::logger_init("MiracastPlayer");
}
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Uninitialized pointer field

Non-static class member "_service" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Miracast/MiracastService/MiracastServiceImplementation.cpp
}
else
{
setEnableInternal(false);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setEnableInternal" might sleep while holding lock "lck._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.cpp
}
else
{
setEnableInternal(false);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setEnableInternal" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.cpp
{
MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-WIFI DEVICE_WIFI_STATE [CONNECTING] ####");
{lock_guard<recursive_mutex> lock(m_EventMutex);
setEnableInternal(false);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setEnableInternal" might sleep while holding lock "lck._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.cpp
{
MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-WIFI DEVICE_WIFI_STATE [CONNECTING] ####");
{lock_guard<recursive_mutex> lock(m_EventMutex);
setEnableInternal(false);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setEnableInternal" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.cpp
return;
}
lock_guard<mutex> lck(_instance->m_DiscoveryStateMutex);
_instance->setPowerStateInternal(newState);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setPowerStateInternal" might sleep while holding lock "lck._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.cpp
if ( _instance->m_isServiceEnabled )
{
MIRACASTLOG_INFO("#### MCAST-TRIAGE-OK-PWR Miracast Discovery Disabled ####");
_instance->setEnableInternal(false);
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Waiting while holding a lock

Call to "setEnableInternal" might sleep while holding lock "lock._M_device".

Medium Impact, CWE-667
SLEEP

Miracast/MiracastService/MiracastServiceImplementation.h
}

public:
static Core::ProxyType<Core::IDispatch> Create(MiracastServiceImplementation *miracastServiceImplementation, Event event, ParamsType params)
Copy link
Contributor

@rdkcmf-jenkins rdkcmf-jenkins Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coverity Issue - Big parameter passed by value

Passing parameter params of type "ParamsType" (size 136 bytes) by value, which exceeds the low threshold of 128 bytes.

Low Impact, CWE-398
PASS_BY_VALUE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rdkcmf-jenkins rdkcmf-jenkins rdkcmf-jenkins left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuvaramachandran-gurusamy @rdkcmf-jenkins