RDKEMW-11485: Fix the entservices-casting to support R5.3 #165
Conversation
Reason for change: Added entservices-casting changes to support the Thunder R5.3 Test Procedure: please refer the ticket comments Risks: Medium Signed-off-by: Thamim Razith Abbasali <tabbas651@cable.comcast.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the entservices-casting repository to support Thunder R5.3 by removing Thunder R4 conditional compilation flags and updating package references. The migration changes the top-level framework package from WPEFramework to Thunder, removes USE_THUNDER_R4 conditionals from selected CMakeLists.txt files, updates the COM-RPC package from Protocols to COM, and corrects the proxystubs path from wpeframework to thunder.
Changes:
- Updated top-level CMakeLists.txt to use
find_package(Thunder)instead offind_package(WPEFramework) - Removed USE_THUNDER_R4 conditionals from XCast and MiracastService CMakeLists.txt files, now using only COM package
- Removed USE_THUNDER_R4 preprocessor conditionals from MiracastServiceImplementation.h and MiracastPlayerImplementation.h
- Updated proxystubs library path from
wpeframework/proxystubstothunder/proxystubsin XCast/CMakeLists.txt
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeLists.txt | Changed framework package reference from WPEFramework to Thunder |
| XCast/CMakeLists.txt | Removed R4 conditionals, SecurityUtil package, updated to COM package, and changed proxystubs path |
| Miracast/MiracastService/CMakeLists.txt | Removed USE_THUNDER_R4 conditionals and switched from Protocols to COM package |
| Miracast/MiracastService/MiracastServiceImplementation.h | Removed USE_THUNDER_R4 preprocessor conditional from Job::Create method |
| Miracast/MiracastPlayer/MiracastPlayerImplementation.h | Removed USE_THUNDER_R4 preprocessor conditional from Job::Create method |
tabbas651
force-pushed
the
topic/RDKEMW-11485
branch
from
99025eb to
6411bc4
Compare
XCast/CMakeLists.txt
Outdated
| find_package(IARMBus) | ||
| find_package(CEC) | ||
| find_library(NMPROXY_LIB NAMES ${NAMESPACE}NetworkManagerProxy PATHS ${CMAKE_SYSROOT}/usr/lib/wpeframework/proxystubs) | ||
| find_library(NMPROXY_LIB NAMES ${NAMESPACE}NetworkManagerProxy PATHS ${CMAKE_SYSROOT}/usr/lib/thunder/proxystubs) |
There was a problem hiding this comment.
The library search path for NetworkManagerProxy has been updated from wpeframework/proxystubs to thunder/proxystubs. While this aligns with the Thunder R5.3 migration, please verify that this path is correct for the target deployment environment and that the proxystubs library is available at this new location. The STORAGE_DIRECTORY variable (which derives from NAMESPACE) will determine the actual path, so ensure consistency across the build configuration.
tabbas651
force-pushed
the
topic/RDKEMW-11485
branch
from
6411bc4 to
6d936bc
Compare
2 participants
Reason for change: Added entservices-casting changes to support the Thunder R5.3
Test Procedure: please refer the ticket comments
Risks: Medium