Add support for COMRPC changes in L2Tests plugin in Testframework repo #162
Conversation
Changed entservices-testframework checkout ref from develop to L2TestPlugin_COMRPC to maintain consistency with other repositories.
…deinitialization.
There was a problem hiding this comment.
Pull request overview
This PR updates the L1-tests.yml workflow to point to feature branches for testing COMRPC support in the L2Tests plugin. The changes replace stable branch references (develop) with temporary feature branch references.
Changes:
- Updated testframework repository reference from
developtoL2TestPlugin_COMRPC - Updated entservices-casting repository reference from
developtoL2TestPlugin_COMRPC - Changed entservices-apis repository reference from
${{env.INTERFACES_REF}}(which resolves to "develop") to hardcodedTest
| repository: rdkcentral/entservices-testframework | ||
| path: entservices-testframework | ||
| ref: develop | ||
| ref: L2TestPlugin_COMRPC |
There was a problem hiding this comment.
This change hardcodes a feature branch reference instead of using the stable 'develop' branch. Feature branch references in workflow files can cause issues if the branch is deleted, renamed, or if changes are not coordinated across repositories. This appears to be a temporary change for testing purposes. Consider using environment variables or workflow inputs to make this configurable, or document in the PR when these references will be reverted to 'develop'.
| ref: L2TestPlugin_COMRPC | |
| ref: develop |
| repository: rdkcentral/entservices-casting | ||
| path: entservices-casting | ||
| ref: develop | ||
| ref: L2TestPlugin_COMRPC |
There was a problem hiding this comment.
This change hardcodes a feature branch reference instead of using the stable 'develop' branch. Feature branch references in workflow files can cause issues if the branch is deleted, renamed, or if changes are not coordinated across repositories. This appears to be a temporary change for testing purposes. Consider using environment variables or workflow inputs to make this configurable, or document in the PR when these references will be reverted to 'develop'.
.github/workflows/L1-tests.yml
Outdated
| repository: rdkcentral/entservices-apis | ||
| path: entservices-apis | ||
| ref: ${{env.INTERFACES_REF}} | ||
| ref: Test |
There was a problem hiding this comment.
This change replaces the environment variable reference '${{env.INTERFACES_REF}}' (which resolves to 'develop') with a hardcoded 'Test' branch reference. This is inconsistent with the pattern used elsewhere in the workflow where INTERFACES_REF is defined as an environment variable (line 17). Hardcoding feature branch names reduces maintainability and can cause failures if the branch doesn't exist. Consider using an environment variable or workflow input for this reference as well.
| ref: Test | |
| ref: ${{ env.INTERFACES_REF }} |
.github/workflows/L1-tests.yml
Outdated
| repository: rdkcentral/entservices-apis | ||
| path: entservices-apis | ||
| ref: ${{env.INTERFACES_REF}} | ||
| ref: Test |
There was a problem hiding this comment.
The branch name 'Test' is generic and ambiguous. It doesn't clearly indicate its purpose or relationship to COMRPC changes. Consider using a more descriptive branch name like 'L2TestPlugin_COMRPC' to maintain consistency with the other branch references in this PR.
| ref: Test | |
| ref: L2TestPlugin_COMRPC |
2 participants
Reason for change: Add COMRPC Support for L2Tests Plugin
Test Procedure : Run L2 Tests to verify the changes
Version : Major
Risks: Low