Skip to content

Conversation

@smanes0213
Copy link
Contributor

@smanes0213 smanes0213 commented Dec 24, 2025

Reason for change: Resolve intermittent failures while running tests on testframework repo
Test Procedure: Run L1, L2, L2-OOP(If applicable)
Risks: Low
Priority: P0
Version:minor

@smanes0213 smanes0213 requested a review from a team as a code owner December 24, 2025 10:59
@smanes0213 smanes0213 changed the title Add cache changes for successful cache upload and cache hit Add cache changes for successful cache upload and cache hit, Add support for COMRPC L2Tests plugin Jan 9, 2026
@suppal045 suppal045 requested a review from Copilot January 9, 2026 06:26
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request modifies the L1-tests workflow to improve caching behavior and updates several repository references. The changes aim to resolve intermittent test failures by adjusting cache paths, improving cache key specificity with a new REPO_NAME variable, and updating branch references for testing purposes.

Key changes:

  • Updated cache paths from thunder/ prefix to direct paths (build/, install/)
  • Added REPO_NAME environment variable to make cache keys more specific
  • Updated repository branch references to feature/test branches for entservices-testframework, entservices-casting, and entservices-apis
  • Added cache-hit conditionals to patch application steps
  • Removed redundant Thunder/Source include paths from build commands

repository: rdkcentral/entservices-testframework
path: entservices-testframework
ref: develop
ref: feature/workflow-test
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entservices-testframework repository is being checked out from a feature branch 'feature/workflow-test' instead of the production branch. This should use a stable branch reference like 'develop' or a specific release tag to ensure consistent and reliable CI/CD pipeline execution.

Suggested change
ref: feature/workflow-test
ref: develop

Copilot uses AI. Check for mistakes.
repository: rdkcentral/entservices-casting
path: entservices-casting
ref: develop
ref: feature/workflowtest_L1-L2
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entservices-casting repository is being checked out from a feature branch 'feature/workflowtest_L1-L2' instead of a stable branch. This should reference a production-ready branch like 'develop' or a specific release tag for stable CI/CD execution.

Suggested change
ref: feature/workflowtest_L1-L2
ref: develop

Copilot uses AI. Check for mistakes.
repository: rdkcentral/entservices-apis
path: entservices-apis
ref: ${{env.INTERFACES_REF}}
ref: Test
Copy link

Copilot AI Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The entservices-apis repository is being checked out from a branch named 'Test' instead of using the environment variable INTERFACES_REF which points to 'develop'. This hardcoded test branch reference should be reverted to use the INTERFACES_REF variable for consistency and stability.

Suggested change
ref: Test
ref: ${{ env.INTERFACES_REF }}

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.

@@ -103,7 +104,6 @@ jobs:
sudo ninja -C build install

- name: Checkout Thunder
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Checkout Thunder' step no longer has the cache-hit condition guard. Since Thunder is always checked out regardless of cache status, but only built when cache misses (line 184), this could lead to wasted API calls and disk usage when the cache is hit. Consider adding back 'if: steps.cache.outputs.cache-hit != true' unless Thunder checkout is needed for other purposes when cache hits.

Suggested change
- name: Checkout Thunder
- name: Checkout Thunder
if: steps.cache.outputs.cache-hit != 'true'

Copilot uses AI. Check for mistakes.

- name: Checkout entservices-apis
if: steps.cache.outputs.cache-hit != 'true'
uses: actions/checkout@v3
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'Checkout entservices-apis' step removed the cache-hit condition guard, but the 'Build entservices-apis' step (line 217) does not have a cache-hit guard either. This means entservices-apis will be checked out and rebuilt every time, even when cached. Since the cache includes 'build/entservices-apis', this checkout should either have a cache-hit guard or the build should be conditional to avoid unnecessary work.

Copilot uses AI. Check for mistakes.
!install/usr/lib/pkgconfig/gtest.pc
!install/usr/lib/pkgconfig/gtest_main.pc
!install/usr/lib/wpeframework/plugins
key: ${{ runner.os }}-${{ env.REPO_NAME }}-${{ env.THUNDER_REF }}-${{ env.INTERFACES_REF }}-4
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cache key now includes REPO_NAME but removes it from the INTERFACES_REF which was changed to a hardcoded 'Test' branch (line 207). This breaks the cache key's ability to track interface changes. The key should continue to track the actual interfaces reference being used, not the hardcoded 'Test' branch.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant