-
Notifications
You must be signed in to change notification settings - Fork 3
Add cache changes for successful cache upload and cache hit, Add support for COMRPC L2Tests plugin #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
…to avoid duplicate definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request modifies the L1-tests workflow to improve caching behavior and updates several repository references. The changes aim to resolve intermittent test failures by adjusting cache paths, improving cache key specificity with a new REPO_NAME variable, and updating branch references for testing purposes.
Key changes:
- Updated cache paths from
thunder/prefix to direct paths (build/,install/) - Added REPO_NAME environment variable to make cache keys more specific
- Updated repository branch references to feature/test branches for entservices-testframework, entservices-casting, and entservices-apis
- Added cache-hit conditionals to patch application steps
- Removed redundant Thunder/Source include paths from build commands
| repository: rdkcentral/entservices-testframework | ||
| path: entservices-testframework | ||
| ref: develop | ||
| ref: feature/workflow-test |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entservices-testframework repository is being checked out from a feature branch 'feature/workflow-test' instead of the production branch. This should use a stable branch reference like 'develop' or a specific release tag to ensure consistent and reliable CI/CD pipeline execution.
| ref: feature/workflow-test | |
| ref: develop |
| repository: rdkcentral/entservices-casting | ||
| path: entservices-casting | ||
| ref: develop | ||
| ref: feature/workflowtest_L1-L2 |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entservices-casting repository is being checked out from a feature branch 'feature/workflowtest_L1-L2' instead of a stable branch. This should reference a production-ready branch like 'develop' or a specific release tag for stable CI/CD execution.
| ref: feature/workflowtest_L1-L2 | |
| ref: develop |
| repository: rdkcentral/entservices-apis | ||
| path: entservices-apis | ||
| ref: ${{env.INTERFACES_REF}} | ||
| ref: Test |
Copilot
AI
Jan 9, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The entservices-apis repository is being checked out from a branch named 'Test' instead of using the environment variable INTERFACES_REF which points to 'develop'. This hardcoded test branch reference should be reverted to use the INTERFACES_REF variable for consistency and stability.
| ref: Test | |
| ref: ${{ env.INTERFACES_REF }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 3 comments.
| @@ -103,7 +104,6 @@ jobs: | |||
| sudo ninja -C build install | |||
|
|
|||
| - name: Checkout Thunder | |||
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'Checkout Thunder' step no longer has the cache-hit condition guard. Since Thunder is always checked out regardless of cache status, but only built when cache misses (line 184), this could lead to wasted API calls and disk usage when the cache is hit. Consider adding back 'if: steps.cache.outputs.cache-hit != true' unless Thunder checkout is needed for other purposes when cache hits.
| - name: Checkout Thunder | |
| - name: Checkout Thunder | |
| if: steps.cache.outputs.cache-hit != 'true' |
|
|
||
| - name: Checkout entservices-apis | ||
| if: steps.cache.outputs.cache-hit != 'true' | ||
| uses: actions/checkout@v3 |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'Checkout entservices-apis' step removed the cache-hit condition guard, but the 'Build entservices-apis' step (line 217) does not have a cache-hit guard either. This means entservices-apis will be checked out and rebuilt every time, even when cached. Since the cache includes 'build/entservices-apis', this checkout should either have a cache-hit guard or the build should be conditional to avoid unnecessary work.
| !install/usr/lib/pkgconfig/gtest.pc | ||
| !install/usr/lib/pkgconfig/gtest_main.pc | ||
| !install/usr/lib/wpeframework/plugins | ||
| key: ${{ runner.os }}-${{ env.REPO_NAME }}-${{ env.THUNDER_REF }}-${{ env.INTERFACES_REF }}-4 |
Copilot
AI
Jan 15, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The cache key now includes REPO_NAME but removes it from the INTERFACES_REF which was changed to a hardcoded 'Test' branch (line 207). This breaks the cache key's ability to track interface changes. The key should continue to track the actual interfaces reference being used, not the hardcoded 'Test' branch.
Reason for change: Resolve intermittent failures while running tests on testframework repo
Test Procedure: Run L1, L2, L2-OOP(If applicable)
Risks: Low
Priority: P0
Version:minor