RDKEMW-4621: L1 test for Xcast plugin #121

yuvaramachandran-gurusamy · 2025-08-24T17:28:05Z

RDKEMW-4621: L1 test for Xcast plugin

Signed-off-by: yuvaramachandran_gurusamy yuvaramachandran_gurusamy@comcast.com

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

…rvices-casting into topic/RDKEMW-4621_Xcast

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

rdkcmf-jenkins · 2025-09-08T14:15:37Z

XCast/XCastImplementation.h

+                    void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
+                    {
+                        LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
+                        _parent.onIPAddressChange(interface, ipversion, ipaddress, status);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"interface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""interface"")" instead of "interface".

rdkcmf-jenkins · 2025-09-08T14:15:37Z

XCast/XCastImplementation.h

+                    void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
+                    {
+                        LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
+                        _parent.onIPAddressChange(interface, ipversion, ipaddress, status);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"ipaddress" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ipaddress"")" instead of "ipaddress".

rdkcmf-jenkins · 2025-09-08T14:15:37Z

XCast/XCastImplementation.h

+                    void onActiveInterfaceChange(const string prevActiveInterface, const string currentActiveinterface) override
+                    {
+                        LOGINFO("Active interface changed [%s] -- > [%s]",prevActiveInterface.c_str(), currentActiveinterface.c_str());
+                        _parent.onActiveInterfaceChange(prevActiveInterface, currentActiveinterface);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"currentActiveinterface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""currentActiveinterface"")" instead of "currentActiveinterface".

rdkcmf-jenkins · 2025-09-08T14:15:37Z

XCast/XCastImplementation.h

+                    void onIPAddressChange(const string interface, const string ipversion, const string ipaddress, const Exchange::INetworkManager::IPStatus status) override
+                    {
+                        LOGINFO("IP Address changed: Interface [%s] IP Version [%s] Address [%s] Status [%d]", interface.c_str(), ipversion.c_str(), ipaddress.c_str(), status);
+                        _parent.onIPAddressChange(interface, ipversion, ipaddress, status);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"ipversion" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""ipversion"")" instead of "ipversion".

rdkcmf-jenkins · 2025-09-08T14:15:37Z

XCast/XCastImplementation.h

+                    void onActiveInterfaceChange(const string prevActiveInterface, const string currentActiveinterface) override
+                    {
+                        LOGINFO("Active interface changed [%s] -- > [%s]",prevActiveInterface.c_str(), currentActiveinterface.c_str());
+                        _parent.onActiveInterfaceChange(prevActiveInterface, currentActiveinterface);


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Variable copied when it could be moved

"prevActiveInterface" is passed-by-value as parameter to "std::__cxx11::basic_string<char, std::char_traits, std::allocator >::basic_string(std::__cxx11::basic_string<char, std::char_traits, std::allocator > const &)", when it could be moved instead.

Low Impact, CWE-none
COPY_INSTEAD_OF_MOVE

How to fix

Use "std::move(""prevActiveInterface"")" instead of "prevActiveInterface".

rdkcmf-jenkins · 2025-09-08T14:15:38Z

Tests/L1Tests/tests/test_XCast.cpp

+        PluginHost::IFactories::Assign(&factoriesImplementation);
+        Core::IWorkerPool::Assign(&(*workerPool));
+        workerPool->Run();
+    }


Coverity issue no longer present as of: undefined

Show issue

Coverity Issue - Uninitialized pointer field

Non-static class member "dispatcher" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Rebase with Develop branch

rdkcmf-jenkins · 2025-09-12T08:01:21Z

Coverity Issue - Uninitialized pointer field

Non-static class member "mConfigure" is not initialized in this constructor nor in any functions that it calls.

Medium Impact, CWE-457
UNINIT_CTOR

Issue location

This issue was discovered outside the diff for this Pull Request. You can find it at:
XCast/XCast.cpp:52

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-4621: L1 test for Xcast plugin

b790dbf

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

yuvaramachandran-gurusamy requested a review from a team as a code owner August 24, 2025 17:28

yuvaramachandran-gurusamy and others added 27 commits August 24, 2025 23:29

RDKEMW-4621: Use custom branch for validation

31cfc92

RDKEMW-4621: Fix L1 test failures

a61062a

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Merge branch 'topic/RDKEMW-4621_Xcast' of github.com:rdkcentral/entse…

327f60a

…rvices-casting into topic/RDKEMW-4621_Xcast

RDKEMW-4621: Fix build errors

e58c8f1

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RDKEMW-4621: Fix Build failures

0788722

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix build errors

7723e7c

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Enable GDB

b873db0

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Use dispatcherImplMock

5b3fc24

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

f55e23f

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

dispatcherImplMock build error fix

5304b6e

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Added trace logs

a6a7e70

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Add logic

74247ad

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Logs

edabd94

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

8790394

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Adding Trace logs

15eb912

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Adding debugs

d8e13a0

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Trace prints

91d482d

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Add debugs

61574e0

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

bd85359

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Integrate NetworkManager

6f09b99

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

a17d035

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

8066aeb

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix build Error

7a9e119

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

faf4625

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

036443c

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix errors

348087e

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

98a19b9

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

rdkcmf-jenkins reviewed Sep 8, 2025

View reviewed changes

yuvaramachandran-gurusamy and others added 27 commits September 8, 2025 17:53

Event test

cc2eb76

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

695e430

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

8052989

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Disable unRegisterAllApplications Test

556a2d7

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Event update

8598eae

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

1d44b02

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

cbe156e

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix Testcase

95ee560

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix testcase failures

f946052

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

3398843

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

b76ac7b

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

f41694e

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

351d7d6

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

15303cc

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

3255f68

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

cbdc2ba

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Testcase

642c7a9

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

52acc29

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

RegisterApplication test

c7b035a

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix error

6c0a57b

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Fix testcase

bef299c

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

f02eef4

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Final

ce63ed2

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Testing

be55945

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

a805895

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Testing

9d89749

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Merge pull request #127 from rdkcentral/develop

28b11a5

Rebase with Develop branch

yuvaramachandran-gurusamy added 2 commits September 12, 2025 08:15

Fixing Coverity issues

1b89037

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Test

8863010

Signed-off-by: yuvaramachandran_gurusamy <yuvaramachandran_gurusamy@comcast.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RDKEMW-4621: L1 test for Xcast plugin #121

RDKEMW-4621: L1 test for Xcast plugin #121

Uh oh!

yuvaramachandran-gurusamy commented Aug 24, 2025

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

Uh oh!

rdkcmf-jenkins commented Sep 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RDKEMW-4621: L1 test for Xcast plugin #121

Are you sure you want to change the base?

RDKEMW-4621: L1 test for Xcast plugin #121

Uh oh!

Conversation

yuvaramachandran-gurusamy commented Aug 24, 2025

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Variable copied when it could be moved

How to fix

Uh oh!

rdkcmf-jenkins Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Coverity Issue - Uninitialized pointer field

Uh oh!

rdkcmf-jenkins commented Sep 12, 2025

Coverity Issue - Uninitialized pointer field

Issue location

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading

rdkcmf-jenkins Sep 8, 2025 •

edited

Loading