Updating Dockerfile for RDKB native build #36
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Dockerfile to support RDKB native build by reorganizing the package installation and adding necessary dependencies.
- Reformatted the
apt-get installcommand with alphabetically organized packages for better readability and maintainability - Added new packages required for RDKB native build including networking libraries (libnetfilter-queue-dev, libnfnetlink-dev, libnl-*), messaging libraries (libnanomsg-dev, libevent-dev), and utilities (iputils-ping, net-tools)
- Implemented Docker best practices by adding
apt-get cleanand removing apt cache to reduce image size
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| libglib2.0-dev libjansson-dev liblog4c-dev libmsgpack-dev libnetfilter-queue-dev libnfnetlink-dev libsqlite3-dev \ | ||
| libssl-dev libsystemd-dev libtirpc-dev libtool libunwind-dev libwebsocketpp-dev libxml2-utils libcunit1 libcunit1-dev \ | ||
| meson net-tools ninja-build openssl python3-distutils python3-pip ruby-full tar tcl-dev valgrind vim wget libmnl-dev \ | ||
| zlib1g-dev libupnp-dev libnanomsg-dev libevent-dev libnl-3-dev libnl-route-3-dev libnl-nf-3-dev \ |
There was a problem hiding this comment.
The package libboost-all-dev was removed from the previous version but is not present in the updated package list. If RDKB native build requires Boost libraries, this could break the build. Please verify whether Boost is still needed for RDKB components, and if so, add it back to the package list.
| zlib1g-dev libupnp-dev libnanomsg-dev libevent-dev libnl-3-dev libnl-route-3-dev libnl-nf-3-dev \ | |
| zlib1g-dev libupnp-dev libnanomsg-dev libevent-dev libnl-3-dev libnl-route-3-dev libnl-nf-3-dev libboost-all-dev \ |
| RUN apt-get update && apt-get install -y \ | ||
| automake build-essential clang curl g++ gcc gdb git git-lfs gperf iputils-ping jq lcov libavro-dev \ | ||
| libbsd-dev libc6-dev libcjson-dev libcap-dev libcurl4-openssl-dev libdbus-1-dev libgmock-dev libgtest-dev \ | ||
| libglib2.0-dev libjansson-dev liblog4c-dev libmsgpack-dev libnetfilter-queue-dev libnfnetlink-dev libsqlite3-dev \ | ||
| libssl-dev libsystemd-dev libtirpc-dev libtool libunwind-dev libwebsocketpp-dev libxml2-utils libcunit1 libcunit1-dev \ | ||
| meson net-tools ninja-build openssl python3-distutils python3-pip ruby-full tar tcl-dev valgrind vim wget libmnl-dev \ | ||
| zlib1g-dev libupnp-dev libnanomsg-dev libevent-dev libnl-3-dev libnl-route-3-dev libnl-nf-3-dev \ | ||
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
The package autotools-dev was removed from the previous version but is not present in the updated package list. This package provides configuration files for autotools and may be needed for building certain components. Please verify whether autotools-dev is still needed for RDKB native build, and if so, add it back to the package list.
1 participant
No description provided.