Rebase #33

Saranya2421 · 2025-12-19T09:11:14Z

No description provided.

Clone iarmmgrs repository and update test list

Copilot

Pull request overview

This PR adds comprehensive unit test infrastructure for the uploadSTBLogs component through a rebase operation. The changes include Google Test-based unit tests for multiple modules, mock implementations, build configuration, and several new source files.

Changes:

Adds 18 comprehensive unit test files covering all major modules (verification, validation, upload engine, strategy handlers, archive manager, etc.)
Implements mock classes for RDK utilities, RBUS, CURL, and file operations
Adds build system configuration (Makefile.am, configure.ac)
Includes several new source implementation files (verification.c, validation.c, uploadstblogs.c, etc.)

Reviewed changes

Copilot reviewed 86 out of 87 changed files in this pull request and generated 66 comments.

Show a summary per file

File	Description
uploadstblogs/unittest/*_gtest.cpp	18 unit test files with comprehensive test coverage for different modules
uploadstblogs/unittest/mocks/*.h/.cpp	Mock implementations for external dependencies (RDK utils, RBUS, CURL, file operations)
uploadstblogs/unittest/Makefile.am	Build configuration for compiling and linking test executables
uploadstblogs/unittest/configure.ac	Autoconf configuration for test build system
uploadstblogs/src/*.c	New source implementation files (verification, validation, uploadstblogs, upload_engine, strategy_handler)
uploadstblogs/include/md5_utils.h	Header file for MD5 utility functions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-13T18:18:49Z

uploadstblogs/unittest/strategy_handler_gtest.cpp

+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the Licesnse.


Corrected spelling of 'License' to 'Licesnse'

Copilot · 2026-01-13T18:18:50Z

uploadstblogs/unittest/verification_gtest.cpp

+const char* mock_curl_easy_strerror_impl(int curl_code) {
+    switch (curl_code) {
+        case 0: return "No error"; // CURLE_OK
+        case 7: return "Couldn't connect to server"; // CURLE_COULDNT_CONNECT  


Trailing whitespace at end of line 37 should be removed for code cleanliness.

Copilot · 2026-01-13T18:18:50Z

uploadstblogs/unittest/verification_gtest.cpp

+    EXPECT_FALSE(is_terminal_failure(403));
+}
+
+// Test is_curl_success function  


Trailing whitespace at end of line 144 should be removed for code cleanliness.

Copilot · 2026-01-13T18:18:50Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for configuration error detection
+        error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")


Variable error_logs is not used.

Suggested change

error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")

error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")

assert len(error_logs) > 0, f"Configuration error should be logged for corrupted properties, but found: {error_logs}"

Copilot · 2026-01-13T18:18:51Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+        create_test_log_files(count=1)
+
+        result = run_uploadstblogs()


Variable result is not used.

Suggested change

result = run_uploadstblogs()

run_uploadstblogs()

Copilot · 2026-01-13T18:19:08Z

test/functional-tests/tests/uploadstblogs_helper.py

+import os
+import time
+import re
+import json


Import of 'json' is not used.

Copilot · 2026-01-13T18:19:08Z

test/functional-tests/tests/uploadstblogs_helper.py

+    try:
+        subprocess.run(f"echo '' > {UPLOADSTB_LOG}", shell=True)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+        if os.path.exists(LOCK_FILE):
+            os.remove(LOCK_FILE)
+        return True
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+            for chunk in iter(lambda: f.read(4096), b""):
+                md5_hash.update(chunk)
+        return md5_hash.hexdigest()
+    except:


Except block directly handles BaseException.

Copilot · 2026-01-13T18:19:09Z

test/functional-tests/tests/uploadstblogs_helper.py

+    """Get file size in bytes"""
+    try:
+        return os.path.getsize(filepath)
+    except:


Except block directly handles BaseException.

…ts To C Implementation (#54) * Update cov_build.sh to enable the rdkcertselector feature in the common_utilities build configuration to support the migration of operation support log upload scripts to C implementation. The change is part of resolving L2 test failures.

Copilot

Pull request overview

Copilot reviewed 86 out of 87 changed files in this pull request and generated 23 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T19:06:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for size limit detection
+        size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")


Variable size_logs is not used.

Suggested change

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

size_logs = grep_uploadstb_logs_regex(r"size.*limit|too large|exceed")

assert size_logs, "Expected size limit detection logs"

Copilot · 2026-01-21T19:06:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for telemetry markers
+        telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")


Variable telemetry_logs is not used.

Suggested change

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

telemetry_logs = grep_uploadstb_logs_regex(r"telemetry|marker|warning")

# Ensure telemetry warning logs are present

assert telemetry_logs, "Expected telemetry warning logs to be present"

Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for no files detection
+        no_files_logs = grep_uploadstb_logs_regex(r"no.*file|empty|not found|no logs")


Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for informative message
+        logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")


Variable logs is not used.

Suggested change

logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")

logs = grep_uploadstb_logs_regex(r"no.*file|empty|nothing to upload")

assert logs, "Expected an informative 'no files' or 'empty logs' message in uploadSTBLogs logs"

Copilot · 2026-01-21T19:06:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+        # Should not attempt upload
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Might not see upload attempts


Variable upload_logs is not used.

Suggested change

# Might not see upload attempts

assert len(upload_logs) == 0, "Should not attempt upload when no log files exist"

Copilot · 2026-01-21T19:06:47Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        args = "'' 0 0 0 HTTP http://localhost:8080 0 0 ''"
+
+        result = run_uploadstblogs(args)
+


Variable result is not used.

Suggested change

# Ensure the upload process completes (0 or 1 are acceptable in other tests)

assert result.returncode in [0, 1], "DCM scheduled upload should complete"

Copilot · 2026-01-21T19:06:47Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        result = run_uploadstblogs(args)
+
+        # Check for log collection
+        collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")


Variable collection_logs is not used.

Suggested change

collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")

collection_logs = grep_uploadstb_logs_regex(r"collect|archive|DCM")

assert len(collection_logs) > 0, "DCM scheduled upload should collect or archive logs"

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+        result = run_uploadstblogs()
+
+        # Check for event publishing
+        event_logs = grep_uploadstb_logs_regex(r"event|publish|success")


Variable event_logs is not used.

Suggested change

event_logs = grep_uploadstb_logs_regex(r"event|publish|success")

_ = grep_uploadstb_logs_regex(r"event|publish|success")

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_upload_strategies.py

+
+        # Check for strategy selection
+        strategy_logs = grep_uploadstb_logs_regex(r"strategy|RRD|select")
+        assert result.returncode in [0, 1], "Should select appropriate strategy"


Variable strategy_logs is not used.

Suggested change

assert result.returncode in [0, 1], "Should select appropriate strategy"

assert result.returncode in [0, 1], "Should select appropriate strategy"

assert strategy_logs, "Expected strategy selection logs to be present"

Copilot · 2026-01-21T19:06:48Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+import pytest
+import time
+from uploadstblogs_helper import *


Import pollutes the enclosing namespace, as the imported module uploadstblogs_helper does not define 'all'.

Suggested change

from uploadstblogs_helper import *

from uploadstblogs_helper import (

clear_uploadstb_logs,

remove_lock_file,

cleanup_test_log_files,

restore_device_properties,

kill_uploadstblogs,

create_test_log_files,

run_uploadstblogs,

grep_uploadstb_logs_regex,

DEVICE_PROPERTIES,

)

…ts To C Implementation (#60)

Copilot

Pull request overview

Copilot reviewed 87 out of 88 changed files in this pull request and generated 25 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-03T09:04:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for configuration error detection
+        error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")


Variable error_logs is not used.

Suggested change

error_logs = grep_uploadstb_logs_regex(r"ERROR|error|fail.*properties|invalid")

Copilot · 2026-02-03T09:04:42Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        result = run_uploadstblogs()
+
+        # Check for size-related logs
+        logs = grep_uploadstb_logs_regex(r"size|large|limit|truncate")


Copilot · 2026-02-03T09:04:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+
+        # Should not attempt upload
+        upload_logs = grep_uploadstb_logs_regex(r"upload.*success|uploading|HTTP")
+        # Might not see upload attempts


Variable upload_logs is not used.

Suggested change

# Might not see upload attempts

# Ensure no upload-related entries are present in logs

assert len(upload_logs) == 0, "Should not attempt upload without files"

# Process return code should still be acceptable

Copilot · 2026-02-03T09:04:43Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+        # Process should complete
+        assert result.returncode in [0, 1], "Should handle empty logs with telemetry"
+


Variable telemetry_logs is not used.

Suggested change

# Process should complete

assert result.returncode in [0, 1], "Should handle empty logs with telemetry"

assert len(telemetry_logs) > 0, "Expected telemetry logs for empty logs case"

# Process should complete

assert result.returncode in [0, 1], "Should handle empty logs with telemetry"

Copilot · 2026-02-03T09:04:43Z

test/functional-tests/tests/test_uploadstblogs_resource_management.py

+        # Check archives before
+        archives_before = sp.run("ls /tmp/*.tgz 2>/dev/null | wc -l", 
+                                shell=True, capture_output=True, text=True)
+


Variable archives_before is not used.

Suggested change

# Check archives before

archives_before = sp.run("ls /tmp/*.tgz 2>/dev/null | wc -l",

shell=True, capture_output=True, text=True)

Copilot · 2026-02-03T09:04:48Z

test/functional-tests/tests/test_uploadstblogs_security.py

+import pytest
+import time
+import os
+from uploadstblogs_helper import *


Import pollutes the enclosing namespace, as the imported module uploadstblogs_helper does not define 'all'.

Suggested change

from uploadstblogs_helper import *

from uploadstblogs_helper import (

clear_uploadstb_logs,

remove_lock_file,

cleanup_mtls_certificates,

kill_uploadstblogs,

setup_mtls_certificates,

create_test_log_files,

run_uploadstblogs,

grep_uploadstb_logs_regex,

)

Copilot · 2026-02-03T09:04:49Z

test/functional-tests/tests/test_uploadstblogs_error_handling.py

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Suggested change

import time

Copilot · 2026-02-03T09:04:49Z

test/functional-tests/tests/test_uploadstblogs_normal_upload.py

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Suggested change

import time

Copilot · 2026-02-03T09:04:49Z

test/functional-tests/tests/test_uploadstblogs_security.py

+"""
+
+import pytest
+import time


Import of 'time' is not used.

Suggested change

import time

Copilot · 2026-02-03T09:04:49Z

test/functional-tests/tests/uploadstblogs_helper.py

+import os
+import time
+import re
+import json


Import of 'json' is not used.

Suggested change

import json

DCM Agent 2.0.1 release

* Create uploadlogsnow.h --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot

Pull request overview

Copilot reviewed 91 out of 94 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 91 out of 94 changed files in this pull request and generated 15 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-11T11:09:54Z

uploadstblogs/src/upload_engine.c

+            __FUNCTION__, __LINE__, archive_path, file_size);
+
+    // Set archive path in session for upload functions
+    strncpy(session->archive_file, archive_path, sizeof(session->archive_file) - 1);


strncpy() does not guarantee NUL-termination when the source is long. This can leave session->archive_file unterminated and cause incorrect logging/behavior later. Add an explicit terminator after the copy (e.g., set the last byte to '\0').

Suggested change

strncpy(session->archive_file, archive_path, sizeof(session->archive_file) - 1);

strncpy(session->archive_file, archive_path, sizeof(session->archive_file) - 1);

session->archive_file[sizeof(session->archive_file) - 1] = '\0';

Copilot · 2026-02-11T11:09:55Z

uploadstblogs/src/rbus_interface.c

+#include "rbus/rbus.h"
+#endif
+
+#define LOG_UPLOADSTB "LOG.RDK.UPLOADSTB"


LOG_UPLOADSTB is already defined in uploadstblogs_types.h (included broadly). Redefining it here risks macro redefinition warnings that can break builds under -Werror. Remove this local #define and rely on the shared definition.

Suggested change

#define LOG_UPLOADSTB "LOG.RDK.UPLOADSTB"

Copilot · 2026-02-11T11:09:55Z

uploadstblogs/src/strategy_selector.c

+    }
+
+    // Debug: Print all flag values
+    fprintf(stderr, "DEBUG: early_checks() - rrd_flag=%d, dcm_flag=%d, trigger_type=%d\n", 


This uses unconditional fprintf(stderr, ...) in production code, which bypasses the project logging system and can pollute stderr in embedded environments. Replace with RDK_LOG(RDK_LOG_DEBUG, ...) or guard it behind a compile-time debug flag.

Suggested change

fprintf(stderr, "DEBUG: early_checks() - rrd_flag=%d, dcm_flag=%d, trigger_type=%d\n",

RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB,

"early_checks() - rrd_flag=%d, dcm_flag=%d, trigger_type=%d\n",

Copilot · 2026-02-11T11:09:55Z

uploadstblogs/include/verification.h

+ * Verification logic:
+ * - HTTP 200 + curl success → UPLOADSTB_SUCCESS
+ * - HTTP 404 → UPLOADSTB_FAILED (terminal)
+ * - Other → UPLOADSTB_RETRY or UPLOADSTB_FAILED


The header documentation claims verify_upload() may return UPLOADSTB_RETRY, but the implementation in verification.c only returns UPLOADSTB_SUCCESS or UPLOADSTB_FAILED. Update the doc to match the implementation, or update verify_upload() to return UPLOADSTB_RETRY where appropriate (e.g., non-terminal failures).

Suggested change

* - Other → UPLOADSTB_RETRY or UPLOADSTB_FAILED

* - Other → UPLOADSTB_FAILED

Copilot · 2026-02-11T11:09:56Z

uploadstblogs/include/validation.h

+ * @brief Check if required binaries are available
+ * @return true if all binaries exist, false otherwise
+ */
+bool validate_binaries(void);
+
+/**


validate_binaries() is declared in the public header but there is no implementation in uploadstblogs/src/validation.c in this PR. Either implement it (if it’s part of the public API) or remove it from the header to avoid exposing an API surface that cannot be linked/used reliably.

Suggested change

* @brief Check if required binaries are available

* @return true if all binaries exist, false otherwise

*/

bool validate_binaries(void);

/**

Copilot · 2026-02-11T11:09:57Z

uploadstblogs/unittest/uploadlogsnow_gtest.cpp

+    EXPECT_EQ(-1, result);
+
+    // Reset and test archive creation failure
+    SetUp(); // Reset all mocks


Calling the fixture lifecycle method SetUp() manually inside a test is not recommended and can lead to inconsistent state (and bypasses TearDown() expectations). Extract the “reset mock state” logic into a dedicated helper (e.g., ResetMocksAndContext()) that both SetUp() and the test can call.

Copilot · 2026-02-11T11:09:57Z

uploadstblogs/unittest/uploadlogsnow_gtest.cpp

+    EXPECT_EQ(-1, result);
+
+    // Reset and test upload failure
+    SetUp(); // Reset all mocks


Calling the fixture lifecycle method SetUp() manually inside a test is not recommended and can lead to inconsistent state (and bypasses TearDown() expectations). Extract the “reset mock state” logic into a dedicated helper (e.g., ResetMocksAndContext()) that both SetUp() and the test can call.

Copilot · 2026-02-11T11:09:57Z

uploadstblogs/unittest/mocks/mock_rbus.h

+#ifdef __cplusplus
+extern "C" {
+#endif
+
+// RBUS function declarations
+bool rbus_init();
+void rbus_cleanup();
+bool rbus_get_string_param(const char* param, char* value, size_t size);
+bool rbus_get_bool_param(const char* param, bool* value);
+


The MockRbus C++ class is defined inside an extern "C" block, which is not appropriate and can cause toolchain-specific issues. Keep extern "C" only around the C function declarations, and move the mock class (and other C++ constructs) outside the extern "C" region.

Copilot · 2026-02-11T11:09:58Z

uploadstblogs/unittest/mocks/mock_rbus.h

+// Mock class for RBUS functions
+class MockRbus {
+public:
+    MOCK_METHOD0(rbus_init, bool());
+    MOCK_METHOD0(rbus_cleanup, void());
+    MOCK_METHOD3(rbus_get_string_param, bool(const char* param, char* value, size_t size));
+    MOCK_METHOD2(rbus_get_bool_param, bool(const char* param, bool* value));
+};


The MockRbus C++ class is defined inside an extern "C" block, which is not appropriate and can cause toolchain-specific issues. Keep extern "C" only around the C function declarations, and move the mock class (and other C++ constructs) outside the extern "C" region.

Copilot · 2026-02-11T11:09:58Z

configure.ac

+        	 no) AC_MSG_ERROR([breakpad is disabled]) ;;
+        	 *) AC_MSG_ERROR([bad value ${enableval} for --enable-breakpad]) ;;
+        	 esac
+        	 ],
+    	    [echo "breakpad is disabled"])
+


The --enable-breakpad option claims “default is no”, but explicitly passing --enable-breakpad=no currently triggers AC_MSG_ERROR. The no branch should disable breakpad without error (and typically just leave BREAKPAD_CFLAGS/LFLAGS empty).

Suggested change

no) AC_MSG_ERROR([breakpad is disabled]) ;;

*) AC_MSG_ERROR([bad value ${enableval} for --enable-breakpad]) ;;

esac

],

[echo "breakpad is disabled"])

no) BREAKPAD_CFLAGS=" "

BREAKPAD_LFLAGS=" " ;;

*) AC_MSG_ERROR([bad value ${enableval} for --enable-breakpad]) ;;

esac

],

[echo "breakpad is disabled"])

DCM Agent release for 2.0.3

shibu-kv and others added 30 commits February 10, 2025 06:57

Merge branch 'release/1.1.0'

b12ff0c

Merge branch 'release/1.2.0'

0397413

Logupload - script migration

1128aaf

Update context_manager.c

81a7e47

Update path_handler.c

c67d58a

Update path_handler.c

a9a2e33

Logupload migration

f0f0918

Update L1-Test.yml

4f0a608

Update unit_test.sh to include new tests

9b4d346

Clone iarmmgrs repository and update test list

Add files via upload

9fb8d96

Add files via upload

1ae54b6

Delete uploadstblogs/src/strategy_selector_gtest.cpp

e082b1d

Update strategy_selector_gtest.cpp

642a75d

Update strategy_selector_gtest.cpp

d2185c8

Update mock_curl.h

50d4d0b

Update mock_curl.cpp

599cc7a

Update mock_rdk_utils.h

2c09efb

Update archive_manager_gtest.cpp

5fdc686

Update cleanup_manager_gtest.cpp

6a508b9

Update context_manager_gtest.cpp

a52b7a1

Update event_manager_gtest.cpp

34c5372

Update log_collector_gtest.cpp

7abc8bb

Update md5_utils_gtest.cpp

e79c549

Update path_handler_gtest.cpp

f073ad9

Update rbus_interface_gtest.cpp

3b5a101

Delete uploadstblogs/unittest/run_retry_logic_test.sh

1b28d45

Update verification_gtest.cpp

4e70b3b

Update validation_gtest.cpp

d518bb3

Update uploadstblogs_gtest.cpp

157828c

Updating copyright header

6f493a6

Copilot AI review requested due to automatic review settings January 13, 2026 18:09

Copilot started reviewing on behalf of shibu-kv January 13, 2026 18:09 View session

Copilot AI reviewed Jan 13, 2026

View reviewed changes

Abhinavpv28 added 2 commits January 14, 2026 08:57

Enable breakpad support for analyzing any crashes

d68ca8c

Copilot AI review requested due to automatic review settings January 21, 2026 18:58

Copilot started reviewing on behalf of shibu-kv January 21, 2026 18:59 View session

Changelog updates for 2.0.0 release

6e7c40d

Copilot AI reviewed Jan 21, 2026

View reviewed changes

shibu-kv and others added 3 commits January 21, 2026 11:18

Merge branch 'release/2.0.0'

99acb75

Merge branch 'release/2.0.0' into develop

8696fdc

RDK-57502 - [RDKE] Migrate Operation Support Log Upload Related Scrip…

52ad7e1

…ts To C Implementation (#60)

Copilot AI review requested due to automatic review settings February 3, 2026 08:55

Copilot started reviewing on behalf of tdeva14 February 3, 2026 08:55 View session

Copilot AI reviewed Feb 3, 2026

View reviewed changes

naveenkumarhanasi and others added 4 commits February 3, 2026 19:04

DCM Agent 2.0.1 release changelog updates

c4a4a53

Merge branch 'release/2.0.1'

6af7b08

Merge tag '2.0.1' into develop

835a632

DCM Agent 2.0.1 release

RDK-59919 : [RDKE] Port Ops Support Upload Scripts to Source code (#59)

9a67596

* Create uploadlogsnow.h --------- Co-authored-by: nhanasi <navihansi@gmail.com>

Copilot AI review requested due to automatic review settings February 10, 2026 20:53

Copilot AI reviewed Feb 10, 2026

View reviewed changes

shibu-kv and others added 4 commits February 10, 2026 13:04

Changelog updates for 2.0.2 release

24893c3

Merge branch 'release/2.0.2'

0c95175

Merge branch 'release/2.0.2' into develop

f6aea55

Update context_manager.c (#73)

6097556

Copilot AI review requested due to automatic review settings February 11, 2026 11:06

Copilot AI reviewed Feb 11, 2026

View reviewed changes

naveenkumarhanasi added 3 commits February 11, 2026 16:45

DCM Agent 2.0.3 release changelog updates

45018b7

Merge branch 'release/2.0.3'

4489cc7

Merge tag '2.0.3' into develop

86c4755

DCM Agent release for 2.0.3

	error_logs = grep_uploadstb_logs_regex(r"ERROR\|error\|fail.*properties\|invalid")
	error_logs = grep_uploadstb_logs_regex(r"ERROR\|error\|fail.*properties\|invalid")
	assert len(error_logs) > 0, f"Configuration error should be logged for corrupted properties, but found: {error_logs}"

	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	size_logs = grep_uploadstb_logs_regex(r"size.*limit\|too large\|exceed")
	assert size_logs, "Expected size limit detection logs"

	no_files_logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|not found\|no logs")
	_ = grep_uploadstb_logs_regex(r"no.*file\|empty\|not found\|no logs")

	logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|nothing to upload")
	logs = grep_uploadstb_logs_regex(r"no.*file\|empty\|nothing to upload")
	assert logs, "Expected an informative 'no files' or 'empty logs' message in uploadSTBLogs logs"

	# Might not see upload attempts
	assert len(upload_logs) == 0, "Should not attempt upload when no log files exist"

		args = "'' 0 0 0 HTTP http://localhost:8080 0 0 ''"

		result = run_uploadstblogs(args)



	# Ensure the upload process completes (0 or 1 are acceptable in other tests)
	assert result.returncode in [0, 1], "DCM scheduled upload should complete"

	collection_logs = grep_uploadstb_logs_regex(r"collect\|archive\|DCM")
	collection_logs = grep_uploadstb_logs_regex(r"collect\|archive\|DCM")
	assert len(collection_logs) > 0, "DCM scheduled upload should collect or archive logs"

	event_logs = grep_uploadstb_logs_regex(r"event\|publish\|success")
	_ = grep_uploadstb_logs_regex(r"event\|publish\|success")

	assert result.returncode in [0, 1], "Should select appropriate strategy"
	assert result.returncode in [0, 1], "Should select appropriate strategy"
	assert strategy_logs, "Expected strategy selection logs to be present"

-from uploadstblogs_helper import *
+from uploadstblogs_helper import (
+    clear_uploadstb_logs,
+    remove_lock_file,
+    cleanup_test_log_files,
+    restore_device_properties,
+    kill_uploadstblogs,
+    create_test_log_files,
+    run_uploadstblogs,
+    grep_uploadstb_logs_regex,
+    DEVICE_PROPERTIES,
+)

	logs = grep_uploadstb_logs_regex(r"size\|large\|limit\|truncate")
	grep_uploadstb_logs_regex(r"size\|large\|limit\|truncate")

-        # Might not see upload attempts
+        # Ensure no upload-related entries are present in logs
+        assert len(upload_logs) == 0, "Should not attempt upload without files"
+        # Process return code should still be acceptable

		# Process should complete
		assert result.returncode in [0, 1], "Should handle empty logs with telemetry"

	strncpy(session->archive_file, archive_path, sizeof(session->archive_file) - 1);
	strncpy(session->archive_file, archive_path, sizeof(session->archive_file) - 1);
	session->archive_file[sizeof(session->archive_file) - 1] = '\0';

	fprintf(stderr, "DEBUG: early_checks() - rrd_flag=%d, dcm_flag=%d, trigger_type=%d\n",
	RDK_LOG(RDK_LOG_DEBUG, LOG_UPLOADSTB,
	"early_checks() - rrd_flag=%d, dcm_flag=%d, trigger_type=%d\n",

	* - Other → UPLOADSTB_RETRY or UPLOADSTB_FAILED
	* - Other → UPLOADSTB_FAILED

Rebase #33

Are you sure you want to change the base?

Rebase #33

Uh oh!

Conversation

Saranya2421 commented Dec 19, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 13, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!