RDKB-60656 : Available memory check for firmware downloads #23

bunnam988 · 2026-01-21T11:16:00Z

RDKB-60656 : Available memory check for firmware downloads

Reason for change: Before firmware download, we need to check if the device have enough memory
Test Procedure: 1. while firmware download, available memory check logs should be seen.
2. If available memory < required memory, firmware download should not start.
Risks: medium
Priority: P1

Gerrit meta-layer changes:
https://gerrit.teamccp.com/#/q/topic:RDKB-60656+(status:open+OR+status:merged)
List all dependent GitHub PRs:
rdkcentral/xconf-client#13
rdkcentral/provisioning-and-management#178
rdkcentral/utopia#182
rdkcentral/miscellaneous-broadband#37
https://github.com/rdk-gdcs/apparmor-profiles/pull/49

Copilot

Pull request overview

This pull request adds a memory availability check before initiating firmware downloads to prevent failures on devices with insufficient memory.

Changes:

Adds a pre-download memory check using an external library function can_proceed_fw_download()
Links against a new external library -lfw_download_chk to provide memory checking functionality
Returns failure with error logging when insufficient memory is detected

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.

File	Description
source/TR-181/integration_src.shared/cosa_device_info_apis.c	Added header include and memory check before firmware download thread creation
source/TR-181/integration_src.shared/Makefile.am	Added linker flag for new external library dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-21T11:20:55Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c

+    if(can_proceed_fw_download() == 0){
+        CcspTraceError(("CosaDmlDIDownloadNow : Not enough memory to proceed firmware download\n"));
+        return ANSC_STATUS_FAILURE;
+    }


Tests exist for CosaDmlDIDownloadNow() but there is no test coverage for the new memory check failure path. Add tests to verify the behavior when can_proceed_fw_download() returns 0, ensuring the function properly returns ANSC_STATUS_FAILURE and logs the appropriate error message.

Copilot · 2026-01-21T11:20:55Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c

 	}   */
+
+    if(can_proceed_fw_download() == 0){
+        CcspTraceError(("CosaDmlDIDownloadNow : Not enough memory to proceed firmware download\n"));


The error message lacks specific information about how much memory is available versus how much is required. Consider enhancing the error message to include actual memory values, which would be more helpful for debugging and troubleshooting in production environments.

Copilot · 2026-01-21T11:20:56Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c

 #include "safec_lib_common.h"
 #include <syscfg/syscfg.h>
 #include "secure_wrapper.h"
+#include "fw_download_check.h"


The header file "fw_download_check.h" is included but doesn't appear to exist in the repository. This will cause compilation failures. Ensure the header file is either added to the repository or is available in an external dependency that's properly configured in the build system.

Copilot · 2026-01-21T11:20:56Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c


 	}   */
+
+    if(can_proceed_fw_download() == 0){


The function can_proceed_fw_download() is called but its implementation is not found in the codebase. This will cause linker errors unless it's provided by the external library. The function should be declared in the fw_download_check.h header file with clear documentation of its expected return values (the code assumes 0 means insufficient memory, non-zero means sufficient memory).

Copilot · 2026-01-21T11:20:56Z

source/TR-181/integration_src.shared/Makefile.am


 libCcspCMAgent_integration_src_shared_la_SOURCES = cosa_x_cisco_com_cablemodem_apis.c cosa_device_info_apis.c cosa_x_rdkcentral_com_cablemodem_apis.c
-libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper
+libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper -lfw_download_chk


The library "-lfw_download_chk" is added as a dependency but there's no verification that this library exists or is available in the build environment. Consider adding appropriate configuration checks (e.g., PKG_CHECK_MODULES or AC_CHECK_LIB in configure.ac) to ensure the library is available before attempting to link against it.

Suggested change

libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper -lfw_download_chk

libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper @FW_DOWNLOAD_CHK_LIBS@

Copilot · 2026-01-21T11:20:56Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c


 	}   */
+
+    if(can_proceed_fw_download() == 0){


The return value convention of can_proceed_fw_download() is unclear and potentially confusing. The function returns 0 to indicate failure (not enough memory), which is contrary to common C conventions where 0 typically indicates success. Consider using a more explicit return type (e.g., a boolean or named enum) or reversing the logic to align with standard conventions, and add a comment explaining the return value semantics.

Suggested change

if(can_proceed_fw_download() == 0){

/* can_proceed_fw_download() returns non-zero when it is safe to proceed,

* and 0 on failure (e.g. not enough memory). */

if (!can_proceed_fw_download()){

Copilot · 2026-01-21T11:20:57Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c


 	}   */
+
+    if(can_proceed_fw_download() == 0){


The memory check is performed after several other validation steps and resource allocations. If the intent is to prevent firmware download when memory is insufficient, this check should be moved earlier in the function (before cm_hal_Set_HTTP_Download_Url and cm_hal_Set_HTTP_Download_Interface calls) to avoid unnecessary operations when the download will fail anyway.

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Adding t2 init

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

Comments suppressed due to low confidence (1)

source/TR-181/integration_src.shared/cosa_device_info_apis.c:507

The return value of pthread_create is assigned to variable 'res' but is never checked. If the memory check passes but thread creation fails, the function still returns ANSC_STATUS_SUCCESS, which is misleading. This issue exists in the original code as well, but the new memory check makes it more critical - if memory is low enough to fail thread creation, it should be caught. Consider checking 'res' after the memory check and returning ANSC_STATUS_FAILURE if thread creation fails.

	pthread_t FWDL_Thread;
	res = pthread_create(&FWDL_Thread, NULL, FWDL_ThreadFunc, "FWDL_ThreadFunc"); 
	if(res != 0)
	{
		CcspTraceError(("Create FWDL_Thread error %d\n", res));
	}	
	
	return ANSC_STATUS_SUCCESS;

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-27T12:42:39Z

source/CMAgentSsp/ssp_main.c

 //#include <docsis_ext_interface.h>
 #include "safec_lib_common.h"
 #include "syscfg/syscfg.h"
+#include "telemetry_busmessage_sender.h"


The addition of telemetry_busmessage_sender.h include and the corresponding t2_init call on line 964 appear unrelated to the stated PR objective of adding available memory check for firmware downloads. If telemetry is needed for reporting memory check failures or firmware download metrics, this should be mentioned in the PR description. Otherwise, this change should be in a separate PR to maintain clear separation of concerns.

Copilot · 2026-01-27T12:42:40Z

source/CMAgentSsp/ssp_main.c

    CcspTraceInfo(("pthread create docsis registration\n"));
    pthread_create(&docsisclbk_tid, NULL, GWP_docsisregistration_threadfunc, NULL);
 #endif
+	t2_init("CcspCMAgent");


The addition of t2_init call appears unrelated to the stated PR objective of adding available memory check for firmware downloads. If telemetry is needed for reporting memory check failures or firmware download metrics, this should be mentioned in the PR description. Otherwise, this change should be in a separate PR to maintain clear separation of concerns.

Copilot · 2026-01-27T12:42:40Z

source/TR-181/integration_src.shared/cosa_device_info_apis.c

+    if(can_proceed_fw_download() == 0){
+        CcspTraceError(("CosaDmlDIDownloadNow : Not enough memory to proceed firmware download\n"));
+        return ANSC_STATUS_FAILURE;
+    }


The new memory check for firmware downloads lacks test coverage. The existing test cases for CosaDmlDIDownloadNow (lines 785 and 852 in CcspCMAgentDeviceInfoDmlTest.cpp) do not mock or test the can_proceed_fw_download() function. Add test cases to verify that the function correctly fails when can_proceed_fw_download() returns 0, and succeeds when it returns non-zero.

apattu200

looks ok for me

RDKB-60656 : Available memory check for firmware downloads Reason for change: Before firmware download, we need to check if the device have enough memory Test Procedure: 1. while firmware download, available memory check logs should be seen. 2. If available memory < required memory, firmware download should not start. Risks: medium Priority: P1 **Gerrit meta-layer changes:** https://gerrit.teamccp.com/#/q/topic:RDKB-60656+(status:open+OR+status:merged) **List all dependent GitHub PRs:** rdkcentral/provisioning-and-management#178 rdkcentral/utopia#182 rdkcentral/cable-modem-agent#23 rdkcentral/miscellaneous-broadband#37 https://github.com/rdk-gdcs/apparmor-profiles/pull/49

RDKB-60656 : Available memory check for firmware downloads Reason for change: Before firmware download, we need to check if the device have enough memory Test Procedure: 1. while firmware download, available memory check logs should be seen. 2. If available memory < required memory, firmware download should not start. Risks: medium Priority: P1 **Gerrit meta-layer changes:** https://gerrit.teamccp.com/#/q/topic:RDKB-60656+(status:open+OR+status:merged) **List all dependent GitHub PRs:** rdkcentral/xconf-client#13 rdkcentral/utopia#182 rdkcentral/cable-modem-agent#23 rdkcentral/miscellaneous-broadband#37 https://github.com/rdk-gdcs/apparmor-profiles/pull/49

RDKB-60656 : Available memory check for firmware downloads Reason for change: Before firmware download, we need to check if the device have enough memory Test Procedure: 1. while firmware download, available memory check logs should be seen. 2. If available memory < required memory, firmware download should not start. Risks: medium Priority: P1 **Gerrit meta-layer changes:** https://gerrit.teamccp.com/#/q/topic:RDKB-60656+(status:open+OR+status:merged) **List all dependent GitHub PRs:** rdkcentral/xconf-client#13 rdkcentral/provisioning-and-management#178 rdkcentral/cable-modem-agent#23 rdkcentral/miscellaneous-broadband#37 https://github.com/rdk-gdcs/apparmor-profiles/pull/49

bunnam988 requested review from a team as code owners January 21, 2026 11:16

Copilot AI review requested due to automatic review settings January 21, 2026 11:16

Copilot started reviewing on behalf of bunnam988 January 21, 2026 11:16 View session

bunnam988 added 5 commits January 21, 2026 16:46

Update cosa_device_info_apis.c

7e5c843

Update cosa_device_info_apis.c

a86f968

Update cosa_device_info_apis.c

f6505dd

removed function from here

abca33e

removed unnecessary headers

bb2a7d4

bunnam988 force-pushed the feature/RDKB-60656 branch from b0bed3b to bb2a7d4 Compare January 21, 2026 11:16

Copilot AI reviewed Jan 21, 2026

View reviewed changes

bunnam988 added 2 commits January 21, 2026 17:15

Update Makefile.am

3a15aaf

Update Makefile.am

7c4e0b9

Copilot AI review requested due to automatic review settings January 21, 2026 13:08

Copilot started reviewing on behalf of bunnam988 January 21, 2026 13:08 View session

Update cosa_device_info_apis.c

85113dc

Copilot AI reviewed Jan 21, 2026

View reviewed changes

bunnam988 added 2 commits January 21, 2026 19:27

Update cosa_device_info_apis.c

d8b4d95

Update ssp_main.c

3d92313

Adding t2 init

Copilot AI review requested due to automatic review settings January 27, 2026 12:37

Copilot started reviewing on behalf of bunnam988 January 27, 2026 12:37 View session

Copilot AI reviewed Jan 27, 2026

View reviewed changes

apattu200 reviewed Feb 2, 2026

View reviewed changes

Update cosa_device_info_apis.c

df7dba2

apattu200 approved these changes Feb 11, 2026

View reviewed changes

bunnam988 merged commit 45a0cd1 into develop Feb 11, 2026
6 of 8 checks passed

github-actions bot locked and limited conversation to collaborators Feb 11, 2026

	libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper -lfw_download_chk
	libCcspCMAgent_integration_src_shared_la_LDFLAGS = -lccsp_common -lcm_mgnt -lsysevent -lsecure_wrapper @FW_DOWNLOAD_CHK_LIBS@

-    if(can_proceed_fw_download() == 0){
+    /* can_proceed_fw_download() returns non-zero when it is safe to proceed,
+     * and 0 on failure (e.g. not enough memory). */
+    if (!can_proceed_fw_download()){

RDKB-60656 : Available memory check for firmware downloads #23

RDKB-60656 : Available memory check for firmware downloads #23

Conversation

bunnam988 commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

apattu200 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

bunnam988 commented Jan 21, 2026 •

edited

Loading