Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 22, 2025

Corrects an error in the test documentation where the comment stated "90000000 ticks at 90kHz = 1000000 seconds" but the correct calculation is 90000000 / 90000 = 1000 seconds.

Changes:

  • Updated comment in validateAampTimeOverloads.cpp line 566 to correctly state "90000000 ticks at 90kHz = 1000 seconds"
  • The test logic and expected value (1000000 ms) were already correct and unchanged
// Before:
// Value: 90000000 ticks at 90kHz
// Calculation: (90000000 * 1000) / 90000 = 90000000000 / 90000 = 1000000 ms

// After:
// Value: 90000000 ticks at 90kHz = 1000 seconds
// Calculation: (90000000 * 1000) / 90000 = 90000000000 / 90000 = 1000000 ms

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pstroffolino <20442081+pstroffolino@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from initial PR for AampTime overflow fix Fix incorrect calculation in AampTime test comment Dec 22, 2025
Copilot AI requested a review from pstroffolino December 22, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants