Skip to content

Set Listener Callback to Undefined for Specific Index #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
QuintinKruger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Set Listener Callback to Undefined for Specific Index #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e60d162
Set callback to undefined using index rather than splice which change…
QuintinKruger Jul 28, 2025
86dd353
Handle possiblity of undefined callback function
QuintinKruger Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions dist/thunderJS.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:
*
* Copyright 2024 Metrological
* Copyright 2025 Metrological
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,7 +58,7 @@ var notificationListener = data => {
const callbacks = listeners[data.method];
if (callbacks && Array.isArray(callbacks) && callbacks.length) {
callbacks.forEach(callback => {
callback(data.params);
if (callback) callback(data.params);
});
}
}
Expand Down Expand Up @@ -230,8 +230,8 @@ function listener(plugin, event, callback, errorCallback) {
dispose() {
const listener_id = makeListenerId(plugin, event);
if (listeners[listener_id] === undefined) return
listeners[listener_id].splice(index, 1);
if (listeners[listener_id].length === 0) {
listeners[listener_id][index] = undefined;
if (listeners[listener_id].every(item => item === undefined)) {
unregister.call(thunder, plugin, event, errorCallback);
}
},
Expand Down
4 changes: 2 additions & 2 deletions dist/thunderJS.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 4 additions & 4 deletions module/thunderJS.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
* If not stated otherwise in this file or this component's LICENSE file the
* following copyright and licenses apply:
*
* Copyright 2024 Metrological
* Copyright 2025 Metrological
*
* Licensed under the Apache License, Version 2.0 (the License);
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,7 +58,7 @@ var notificationListener = data => {
const callbacks = listeners[data.method];
if (callbacks && Array.isArray(callbacks) && callbacks.length) {
callbacks.forEach(callback => {
callback(data.params);
if (callback) callback(data.params);
});
}
}
Expand Down Expand Up @@ -230,8 +230,8 @@ function listener(plugin, event, callback, errorCallback) {
dispose() {
const listener_id = makeListenerId(plugin, event);
if (listeners[listener_id] === undefined) return
listeners[listener_id].splice(index, 1);
if (listeners[listener_id].length === 0) {
listeners[listener_id][index] = undefined;
if (listeners[listener_id].every(item => item === undefined)) {
unregister.call(thunder, plugin, event, errorCallback);
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/api/notificationListener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export default data => {
const callbacks = listeners[data.method]
if (callbacks && Array.isArray(callbacks) && callbacks.length) {
callbacks.forEach(callback => {
callback(data.params)
if (callback) callback(data.params)
})
}
}
Expand Down
6 changes: 3 additions & 3 deletions src/listener.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,9 @@ export default function(plugin, event, callback, errorCallback) {
//early return if the listener is already deleted and someone is calling dispose twice
if (listeners[listener_id] === undefined) return

listeners[listener_id].splice(index, 1)

if (listeners[listener_id].length === 0) {
// invalidate the callback with the given index to mark it as deleted without changing the array dimensions
listeners[listener_id][index] = undefined;
if (listeners[listener_id].every(item => item === undefined)) {
unregister.call(thunder, plugin, event, errorCallback)
}
},
Expand Down