RPPL-3824: Backporting fb marketplace app api changes.

[kvfasil]

What

discovery.launch() api's updated.

Why

For fb marketplace apps

How

Updated rules and api's

Test

Get subscription page from app

Checklist

• I have self-reviewed this PR
• I have added tests that prove the feature works or the fix is effective

[github-actions]

Package	Line Rate	Health
core.main.src.service.apps	25%	❌
core.sdk.src.api.gateway	69%	➖
core.sdk.src.api.firebolt	78%	✔
core.tdk.src.gateway	100%	✔
device.thunder_ripple_sdk.src	17%	❌
core.tdk.src.utils	0%	❌
core.main.src.broker.test	90%	✔
core.main.src.firebolt	2%	❌
device.thunder_ripple_sdk.src.processors.events	0%	❌
device.thunder_ripple_sdk.src.processors	17%	❌
core.sdk.src.api.device	77%	✔
core.sdk.src.extn.ffi	0%	❌
core.main.src.processor.storage	0%	❌
core.main.src.state.cap	43%	❌
core.sdk.src.manifest	0%	❌
device.thunder_ripple_sdk.src.events	4%	❌
core.main.src.broker.thunder	37%	❌
device.thunder_ripple_sdk.src.bootstrap	0%	❌
core.sdk.src.extn	77%	✔
core.main.src.bootstrap.manifest	0%	❌
core.main.src.broker.rules	78%	✔
core.main.src.broker	74%	➖
core.sdk.src.api.distributor	68%	➖
core.sdk.src.utils	60%	➖
device.thunder_ripple_sdk.src.client	67%	➖
core.sdk.src.service.mock_app_gw.appgw	0%	❌
core.main.src.firebolt.handlers	12%	❌
core.main.src.utils	30%	❌
core.sdk.src.service.mock_app_gw	0%	❌
core.main.src.bootstrap	0%	❌
core.main.src.state	37%	❌
core.main.src.processor	0%	❌
core.main.src.service	35%	❌
core.sdk.src.extn.client	82%	✔
core.main.src	0%	❌
core.main.src.service.extn	26%	❌
device.mock_device.src	57%	➖
core.sdk.src.api.observability	57%	➖
core.sdk.src.framework	64%	➖
core.sdk.src.processor	0%	❌
core.sdk.src.api	46%	❌
core.main.src.bootstrap.extn	0%	❌
core.sdk.src.api.manifest	76%	✔
Summary	49% (20168 / 41075)	➖

Minimum allowed line rate is 48%

[Copilot]

Pull request overview

This PR backports Facebook marketplace app API changes to the discovery.launch() method. The changes refactor the launch flow to use an internal broker-based approach for reserved apps instead of directly emitting navigation events or sending app requests.

Changes:

• Replaced the direct app event emission and AppRequest flow with BrokerUtils.process_internal_main_request for reserved apps
• Removed the update_intent_source function and its usage (now commented out)
• Removed handling for non-reserved apps

Comments suppressed due to low confidence (1)

core/main/src/firebolt/handlers/discovery_rpc.rs:300

• The logic change means that non-reserved apps (apps where get_reserved_application_id returns None) will always fail with the generic error message "Discovery.launch: some failure". This represents a breaking change in behavior. In the previous implementation, there was handling for non-reserved apps that would send an AppRequest through send_app_request. The new code only handles reserved apps and fails for all other cases. If this is intentional for the fb marketplace app changes, it should be clearly documented. Otherwise, the non-reserved app path should be restored or properly handled.

        Err(jsonrpsee::core::Error::Custom(String::from(
            "Discovery.launch: some failure",
        )))

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.