Skip to content

RPPL-3821: Backporting fb marketplace app api changes.#943

Merged
kvfasil merged 2 commits into3.0.rcfrom
RPPL-3821
Feb 5, 2026
Merged

RPPL-3821: Backporting fb marketplace app api changes.#943
kvfasil merged 2 commits into3.0.rcfrom
RPPL-3821

Conversation

@kvfasil
Copy link
Copy Markdown
Contributor

@kvfasil kvfasil commented Feb 3, 2026

What

discovery.launch() api's updated.

Why

For fb marketplace apps

How

Updated rules.

Test

launch hayu app.

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copilot AI review requested due to automatic review settings February 3, 2026 17:28
@kvfasil kvfasil requested review from Copilot and removed request for Copilot February 3, 2026 17:29
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports FB marketplace app API changes by simplifying the discovery.launch() implementation. The key change is removing the intent context source update logic that was previously modifying navigation intents before passing them to internal request handlers.

Changes:

  • Removed the update_intent function call and its usage, passing the original LaunchRequest directly to the internal handler
  • Corrected error message from "Failed to serialize SectionIntent" to "Failed to serialize LaunchIntent" to accurately reflect the type being serialized
  • Commented out the update_intent function and related code blocks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 3, 2026

Code Coverage

Package Line Rate Health
core.main.src 0%
core.main.src.utils 30%
core.sdk.src.api 46%
core.sdk.src.extn 77%
core.sdk.src.framework 64%
core.sdk.src.manifest 0%
core.sdk.src.service.mock_app_gw.appgw 0%
device.thunder_ripple_sdk.src.events 4%
core.main.src.bootstrap.extn 0%
core.sdk.src.api.firebolt 85%
core.sdk.src.extn.client 82%
core.sdk.src.service.mock_app_gw 0%
core.tdk.src.gateway 100%
core.sdk.src.api.device 76%
device.mock_device.src 55%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.extn.ffi 0%
core.main.src.bootstrap 0%
core.main.src.broker.test 90%
core.tdk.src.utils 0%
core.main.src.processor.storage 0%
core.main.src.broker.thunder 37%
device.thunder_ripple_sdk.src.bootstrap 0%
core.sdk.src.api.distributor 68%
core.main.src.broker.rules 78%
core.main.src.firebolt.handlers 12%
core.main.src.broker 70%
core.main.src.service.apps 25%
core.main.src.service 35%
core.sdk.src.api.gateway 69%
core.sdk.src.api.manifest 75%
core.sdk.src.processor 4%
core.main.src.service.extn 25%
core.main.src.processor 0%
core.sdk.src.service 35%
core.main.src.firebolt 2%
core.sdk.src.utils 63%
device.thunder_ripple_sdk.src.client 67%
core.sdk.src.api.observability 57%
core.main.src.state 36%
device.thunder_ripple_sdk.src.processors 17%
core.main.src.service.ripple_service 7%
core.main.src.bootstrap.manifest 0%
core.main.src.state.cap 43%
device.thunder_ripple_sdk.src 17%
Summary 50% (21873 / 44095)

Minimum allowed line rate is 48%

@kvfasil kvfasil merged commit 4e27372 into 3.0.rc Feb 5, 2026
8 checks passed
@kvfasil kvfasil deleted the RPPL-3821 branch February 5, 2026 16:14
@github-actions github-actions bot locked and limited conversation to collaborators Feb 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants