RPPL-3818 : Share_watch_history(), discovery.lauch() api added/updated(8.1).#941
RPPL-3818 : Share_watch_history(), discovery.lauch() api added/updated(8.1).#941brendanobra merged 10 commits into1.21.rcfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for sharing watch history settings via a new RPC endpoint and refactors the discovery.launch method to use internal broker request handling for reserved applications. The PR title "Hbomax 8.1" suggests this is part of HBO Max integration work, though the description lacks detail.
Changes:
- Added new
privacysettings.shareWatchHistoryRPC method to allow apps to control watch history sharing - Refactored
discovery.launchto useBrokerUtils.process_internal_main_requestfor reserved app launches - Added new enum variant
SetShareWatchHistoryCloudto handle cloud storage of watch history sharing preferences
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| core/sdk/src/api/distributor/distributor_usergrants.rs | Adds SetShareWatchHistoryCloud enum variant to UserGrantsCloudStoreRequest for handling watch history sharing grants |
| core/sdk/src/api/distributor/distributor_privacy.rs | Introduces ShareWatchHistoryRequest struct for RPC request payload |
| core/main/src/firebolt/handlers/privacy_rpc.rs | Implements new set_share_watch_history RPC method with cloud storage integration |
| core/main/src/firebolt/handlers/discovery_rpc.rs | Refactors launch method to use broker utilities for reserved apps; comments out previous implementation (70 lines) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Minimum allowed line rate is |
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist