Skip to content

RPPL-3818 : Share_watch_history(), discovery.lauch() api added/updated(8.1).#941

Merged
brendanobra merged 10 commits into1.21.rcfrom
hbomax_8.1
Feb 6, 2026
Merged

RPPL-3818 : Share_watch_history(), discovery.lauch() api added/updated(8.1).#941
brendanobra merged 10 commits into1.21.rcfrom
hbomax_8.1

Conversation

@kvfasil
Copy link
Copy Markdown
Contributor

@kvfasil kvfasil commented Jan 30, 2026

What

What does this PR add or remove?

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

Copilot AI review requested due to automatic review settings January 30, 2026 18:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for sharing watch history settings via a new RPC endpoint and refactors the discovery.launch method to use internal broker request handling for reserved applications. The PR title "Hbomax 8.1" suggests this is part of HBO Max integration work, though the description lacks detail.

Changes:

  • Added new privacysettings.shareWatchHistory RPC method to allow apps to control watch history sharing
  • Refactored discovery.launch to use BrokerUtils.process_internal_main_request for reserved app launches
  • Added new enum variant SetShareWatchHistoryCloud to handle cloud storage of watch history sharing preferences

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
core/sdk/src/api/distributor/distributor_usergrants.rs Adds SetShareWatchHistoryCloud enum variant to UserGrantsCloudStoreRequest for handling watch history sharing grants
core/sdk/src/api/distributor/distributor_privacy.rs Introduces ShareWatchHistoryRequest struct for RPC request payload
core/main/src/firebolt/handlers/privacy_rpc.rs Implements new set_share_watch_history RPC method with cloud storage integration
core/main/src/firebolt/handlers/discovery_rpc.rs Refactors launch method to use broker utilities for reserved apps; comments out previous implementation (70 lines)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

kvfasil and others added 3 commits January 30, 2026 16:31
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings January 30, 2026 21:53
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kvfasil kvfasil changed the title Hbomax 8.1 RPPL-3818 : Share_watch_history(), discovery.lauch() api added/updated(8.1). Jan 30, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 4, 2026

Code Coverage

Package Line Rate Health
core.sdk.src.api.distributor 84%
core.sdk.src.extn.ffi 80%
core.main.src.service 31%
device.mock_device.src 54%
core.main.src.service.extn 40%
core.main.src.broker.thunder 37%
core.main.src.bootstrap.manifest 0%
device.thunder_ripple_sdk.src.processors.events 0%
device.thunder_ripple_sdk.src.processors 13%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.device 78%
core.main.src.state.cap 42%
core.sdk.src.api.observability 73%
core.main.src.broker.test 90%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.client 67%
device.thunder_ripple_sdk.src 17%
core.main.src.bootstrap.extn 0%
core.tdk.src.utils 0%
core.main.src.firebolt.handlers 9%
core.main.src.utils 27%
core.sdk.src.extn.client 88%
device.thunder.src 0%
core.main.src 0%
core.main.src.bootstrap 0%
core.main.src.service.apps 46%
core.sdk.src.api.manifest 89%
core.sdk.src.extn 82%
openrpc_validator.src 67%
core.main.src.broker 56%
core.sdk.src.framework 76%
core.main.src.processor 0%
device.thunder.src.bootstrap 0%
core.sdk.src.processor 0%
core.main.src.firebolt 2%
core.sdk.src.utils 50%
core.main.src.processor.storage 0%
core.tdk.src.gateway 100%
distributor.general.src 2%
core.sdk.src.api.gateway 63%
core.sdk.src.api.firebolt 79%
core.main.src.state 22%
core.sdk.src.api 80%
Summary 46% (19525 / 42705)

Minimum allowed line rate is 48%

@brendanobra brendanobra merged commit 7875318 into 1.21.rc Feb 6, 2026
7 of 8 checks passed
@brendanobra brendanobra deleted the hbomax_8.1 branch February 6, 2026 20:56
@github-actions github-actions bot locked and limited conversation to collaborators Feb 6, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants