[Cleanup] Remove "LifecycleManagement" contracts and processors from Ripple#923
Open
Vinodsathyaseelan wants to merge 3 commits intomainfrom
Open
[Cleanup] Remove "LifecycleManagement" contracts and processors from Ripple#923Vinodsathyaseelan wants to merge 3 commits intomainfrom
Vinodsathyaseelan wants to merge 3 commits intomainfrom
Conversation
Minimum allowed line rate is |
brendanobra
approved these changes
Nov 11, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR removes the unused LifecycleManagement contracts and processors from Ripple, cleaning up infrastructure that was no longer needed. The changes consolidate lifecycle event handling to always use the AppEvents mechanism rather than routing through internal launcher processors.
- Removed
LifecycleManagementProcessorand its registration in the bootstrap process - Removed
ExtnPayloadProviderimplementations for lifecycle management types - Simplified lifecycle event routing to always emit via
AppEvents
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| core/sdk/src/api/firebolt/fb_lifecycle_management.rs | Removed ExtnPayloadProvider trait implementations and associated tests for lifecycle management request types |
| core/sdk/src/api/apps.rs | Removed ExtnPayloadProvider implementation for AppResponse and associated test |
| core/main/src/service/apps/provider_broker.rs | Removed lifecycle event sending logic when providers are added/removed |
| core/main/src/service/apps/delegated_launcher_handler.rs | Simplified to always emit lifecycle events via AppEvents, removing conditional routing logic |
| core/main/src/processor/mod.rs | Removed lifecycle_management_processor module declaration |
| core/main/src/bootstrap/start_app_manager_step.rs | Removed LifecycleManagementProcessor registration during bootstrap |
| core/main/src/processor/lifecycle_management_processor.rs | Deleted entire file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed the unused
LifecycleManagementcontracts and processors from RippleWhy
Unused code.
How
Removed the LifecycleManagementProcessor and its ExtnPayloadProvider plumbing
Startup no longer registers the lifecycle processor,
lifecycle-related Extn payload impls and tests in the SDK were removed,
ProviderBroker stops sending Add/Remove lifecycle events to the platform client
DelegatedLauncherHandler now always emits lifecycle events via AppEvents instead of routing them through the internal launcher
Test
How has this been tested? How can a reviewer test it?
Checklist