Skip to content

[Cleanup] Remove "LifecycleManagement" contracts and processors from Ripple#923

Open
Vinodsathyaseelan wants to merge 3 commits intomainfrom
RPPL-3566
Open

[Cleanup] Remove "LifecycleManagement" contracts and processors from Ripple#923
Vinodsathyaseelan wants to merge 3 commits intomainfrom
RPPL-3566

Conversation

@Vinodsathyaseelan
Copy link
Copy Markdown
Contributor

@Vinodsathyaseelan Vinodsathyaseelan commented Nov 11, 2025

What

Removed the unused LifecycleManagement contracts and processors from Ripple

Why

Unused code.

How

Removed the LifecycleManagementProcessor and its ExtnPayloadProvider plumbing
Startup no longer registers the lifecycle processor,
lifecycle-related Extn payload impls and tests in the SDK were removed,
ProviderBroker stops sending Add/Remove lifecycle events to the platform client
DelegatedLauncherHandler now always emits lifecycle events via AppEvents instead of routing them through the internal launcher

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@github-actions
Copy link
Copy Markdown

Code Coverage

Package Line Rate Health
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src 13%
core.main.src.processor 0%
core.main.src.broker.test 90%
core.main.src.service.apps 26%
core.main.src.service 32%
core.sdk.src.api 44%
core.sdk.src.extn 76%
core.sdk.src.api.observability 57%
core.sdk.src.processor 9%
core.sdk.src.service.mock_app_gw.appgw 0%
core.sdk.src.service 65%
core.sdk.src.utils 58%
core.sdk.src.extn.ffi 0%
core.main.src.processor.storage 0%
device.thunder_ripple_sdk.src.client 61%
core.main.src.broker 69%
device.thunder_ripple_sdk.src.processors 19%
core.main.src.utils 30%
core.main.src.firebolt.handlers 11%
core.main.src 0%
core.sdk.src.api.manifest 74%
core.tdk.src.utils 0%
core.sdk.src.api.firebolt 85%
core.main.src.bootstrap 0%
core.sdk.src.framework 64%
device.thunder_ripple_sdk.src.processors.events 0%
core.main.src.service.ripple_service 9%
core.main.src.bootstrap.extn 0%
core.sdk.src.api.gateway 69%
core.sdk.src.manifest 0%
core.main.src.state.cap 42%
core.main.src.broker.rules 78%
core.main.src.service.extn 25%
device.mock_device.src 56%
device.thunder_ripple_sdk.src.events 4%
core.main.src.broker.thunder 37%
core.main.src.state 35%
core.sdk.src.extn.client 81%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.distributor 29%
core.sdk.src.service.mock_app_gw 0%
core.main.src.firebolt 12%
core.sdk.src.api.device 76%
core.tdk.src.gateway 100%
Summary 49% (21423 / 43703)

Minimum allowed line rate is 48%

@Vinodsathyaseelan Vinodsathyaseelan requested review from a team and removed request for a team November 11, 2025 22:10
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the unused LifecycleManagement contracts and processors from Ripple, cleaning up infrastructure that was no longer needed. The changes consolidate lifecycle event handling to always use the AppEvents mechanism rather than routing through internal launcher processors.

  • Removed LifecycleManagementProcessor and its registration in the bootstrap process
  • Removed ExtnPayloadProvider implementations for lifecycle management types
  • Simplified lifecycle event routing to always emit via AppEvents

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
core/sdk/src/api/firebolt/fb_lifecycle_management.rs Removed ExtnPayloadProvider trait implementations and associated tests for lifecycle management request types
core/sdk/src/api/apps.rs Removed ExtnPayloadProvider implementation for AppResponse and associated test
core/main/src/service/apps/provider_broker.rs Removed lifecycle event sending logic when providers are added/removed
core/main/src/service/apps/delegated_launcher_handler.rs Simplified to always emit lifecycle events via AppEvents, removing conditional routing logic
core/main/src/processor/mod.rs Removed lifecycle_management_processor module declaration
core/main/src/bootstrap/start_app_manager_step.rs Removed LifecycleManagementProcessor registration during bootstrap
core/main/src/processor/lifecycle_management_processor.rs Deleted entire file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants