XB10-2061 Result string not available for preassoc and postassoc deny CAC cases #9
Conversation
Reason for change: for onboarding Test Procedure: Debug Priority: P0 Risks: Low Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
Reason for change: for onboarding Test Procedure: Debug Priority: P0 Risks: Low Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
Reason for change: for onboarding Test Procedure: Debug Priority: P0 Risks: Low Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
Reason for change: for onboarding Test Procedure: Debug Priority: P0 Risks: Low Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the CAC (Connection Admission Control) subdoc type to enable proper result string generation for preassoc and postassoc deny CAC test cases. The change addresses a debugging issue where result strings were not available during CAC testing.
Changes:
- Added CAC subdoc type handling to the VAP data update switch statement, treating it the same as xfinity hotspot
- Configured execution time to 40 seconds for CAC subdoc type, matching the xfinity configuration
- Added CAC to the subdoc type arrays in test configuration files
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/ui/wlan_emu_ui_mgr.cpp | Adds CAC case to switch statement for updating CCI subdoc VAP data, using the same hotspot VAP check as xfinity |
| src/tests/wlan_emu_test_param_vap.cpp | Sets execution time to 40 seconds for CAC subdoc type and maps CAC to VAP_PREFIX_HOTSPOT in subdoc string lookup |
| src/tests/wlan_emu_test_param_dml_reset.cpp | Adds webconfig_subdoc_type_cac to the subdoc array for DML reset operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case webconfig_subdoc_type_xfinity: | ||
| return VAP_PREFIX_HOTSPOT; | ||
| case webconfig_subdoc_type_cac: | ||
| return VAP_PREFIX_HOTSPOT; |
There was a problem hiding this comment.
The indentation is inconsistent with the surrounding code. The return statement uses a tab character for indentation instead of spaces. All other case statements in this switch use spaces for indentation (8 spaces for the return statement). Please change the tab to spaces to match the existing code style.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… CAC cases Reason for change: To debug Test Procedure: 1. Flash the build image 2. Run the CCI test case CAC0009 3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl Priority: P1 Risks: Low Signed-off-by: Samyuktha Karthikeyan <samyuktha_karthikeyan@comcast.com>
2 participants
Reason for change: To debug
Test Procedure:
1. Flash the build image
2. Run the CCI test case CAC0009
3. Check for the pre deny string in /rdklogs/logs/wifiConnAdmissionCtrl
Priority: P1
Risks: Low
Signed-off-by: Samyuktha Karthikeyan samyuktha_karthikeyan@comcast.com