Changes for Wifi Radio Capability data to be populated in OneWifi #857
+419
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
community contribution
source/webconfig/wifi_decoder.c
Outdated
| /* Decode radio capabilities (WiFi6/WiFi7) from JSON */ | ||
| webconfig_error_t decode_radio_capability(const cJSON *cap_obj, rdk_wifi_radio_capability_t *radio_cap) | ||
| { | ||
| #if 0 |
Contributor
There was a problem hiding this comment.
Why is this #if 0? How have you tested this functionality?
| mac_address_t ruid, | ||
| webconfig_external_easymesh_t *proto) | ||
| { | ||
| #if 0 |
Contributor
There was a problem hiding this comment.
Same comment as above.
source/webconfig/wifi_encoder.c
Outdated
| /* Encode radio capabilities (WiFi6/WiFi7) to JSON */ | ||
| webconfig_error_t encode_radio_capability(const rdk_wifi_radio_capability_t *radio_cap, cJSON *radio_object) | ||
| { | ||
| #if 0 |
Contributor
There was a problem hiding this comment.
same comment as above.
sriraaman-c
force-pushed
the
wifi_cap_data
branch
from
1c30071 to
4a0b14c
Compare
Reason for change: The OneWifi/Easymesh needs Radio Capabilities data which is missing. Hence implemented the method to pull the caps from Driver(Hostap) to OneWifi. Signed-off-by: sriraaman-c <sriraaman33@gmail.com>
sriraaman-c
force-pushed
the
wifi_cap_data
branch
from
4a0b14c to
56da623
Compare
amarnathhullur
requested changes
Feb 10, 2026
| UCHAR mac_cap[HE_MAX_MAC_CAPAB_SIZE]; /**< HE MAC capabilities (HE_MAX_MAC_CAPAB_SIZE = 4) */ | ||
| UCHAR mcs_nss_set[HE_MAX_MCS_CAPAB_SIZE]; /**< HE MCS NSS set (HE_MAX_MCS_CAPAB_SIZE = 6) */ | ||
| UCHAR ppet[HE_MAX_PPET_CAPAB_SIZE]; /**< HE PPE thresholds (HE_MAX_PPET_CAPAB_SIZE = 7) */ | ||
| //USHORT 6ghz_capa; /**< HE 6GHz capabilities */ |
Contributor
There was a problem hiding this comment.
Why is this commented?
| /* Populate radio capabilities from HAL */ | ||
| wifi_freq_bands_t band; | ||
| if (convert_radio_index_to_freq_band(&wifi_hal_cap_obj->wifi_prop, radio_index, &band) == RETURN_OK) { | ||
| wifi_radio_capability_data_t *hal_cap_data = (wifi_radio_capability_data_t *)malloc(sizeof(wifi_radio_capability_data_t)); |
Contributor
There was a problem hiding this comment.
No need of this structure, this should be folded into wifi_radio_capabilities_t
| rdk_wifi_vap_map_t vaps; | ||
| wifi_radio_feature_param_t feature; | ||
| radarInfo_t radarInfo; | ||
| rdk_wifi_radio_capability_t radio_capability; |
Contributor
There was a problem hiding this comment.
where is this structure getting populated?
| wifi_radio_capability_data_t *hal_cap_data = (wifi_radio_capability_data_t *)malloc(sizeof(wifi_radio_capability_data_t)); | ||
| memset(&hal_cap_data, 0, sizeof(hal_cap_data)); | ||
|
|
||
| if (wifi_getRadioCapabilityData(radio_index, band, hal_cap_data) == RETURN_OK) { |
Contributor
There was a problem hiding this comment.
Instead of calling this new API, the hal_cap_data should be part of the wifi_radio_capabilities_t structure itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for change: The OneWifi/Easymesh needs Radio Capabilities data which is missing. Hence implemented the method to pull the caps from Driver(Hostap) to OneWifi.