RDKBWIFI-202: Implementation of Traffic Separation in unified-wifi-mesh #848
Conversation
github-actions
bot
added
the
community contribution
| return webconfig_hal_vap_apply_by_name(ctrl, data, vap_names, num_vaps); | ||
| } | ||
|
|
||
| #ifdef EM_APP |
There was a problem hiding this comment.
Why is this defined under EM_APP?
There was a problem hiding this comment.
The encode, decode and translation functions are all defined under EM_APP in ccsp-one-wifi.
| wifi_util_error_print(WIFI_CTRL,"%s:%d: START : Number of VAPS =%d \n",__func__, __LINE__,getTotalNumberVAPs()); | ||
| char update_status[128]; | ||
| for(UINT index = 0; index < getTotalNumberVAPs(); index++) | ||
| { |
There was a problem hiding this comment.
not as per coding guideline.
There was a problem hiding this comment.
Multiple places the { is in the next line. It should be consistent with the coding guideline of having the { braces in the same line as that of for/if
source/core/wifi_ctrl_webconfig.c
Outdated
|
|
||
| if(isVapPrivate(apIdx)) | ||
| { | ||
| if((strncmp(vapInfo->u.bss_info.ssid,data->em_config.traffic_separation_policy.ssids[0].ssid,sizeof(data->em_config.traffic_separation_policy.ssids[0].ssid))==0) && (vapInfo->vlan_id == data->em_config.traffic_separation_policy.ssids[0].vlan_id)) |
There was a problem hiding this comment.
Multiple comparison in one line, break it up into multipe lines.
source/core/wifi_ctrl_webconfig.c
Outdated
| continue; | ||
| } | ||
| strncpy(vapInfo->u.bss_info.ssid,data->em_config.traffic_separation_policy.ssids[0].ssid,sizeof(data->em_config.traffic_separation_policy.ssids[0].ssid)); | ||
| strncpy(vapInfo->bridge_name,"brlan0",sizeof(vapInfo->bridge_name)); |
There was a problem hiding this comment.
why is the bridge_name hardcoded? Generic comment for all the change
Reason for change: Added traffic seperation TLV implementation Test Procedure: Verify build is successfull and check if traffic seperation is functional Risks: Medium Priority: P2
siddharth-nair-dtdl
force-pushed
the
RDKBWIFI-202
branch
from
062fbcd to
b1a9cc8
Compare
| wifi_util_error_print(WIFI_CTRL,"%s:%d: START : Number of VAPS =%d \n",__func__, __LINE__,getTotalNumberVAPs()); | ||
| char update_status[128]; | ||
| for(UINT index = 0; index < getTotalNumberVAPs(); index++) | ||
| { |
There was a problem hiding this comment.
Multiple places the { is in the next line. It should be consistent with the coding guideline of having the { braces in the same line as that of for/if
| wifi_util_info_print(WIFI_CTRL,"%s:%d: ssids_num =%d \n",__func__, __LINE__,data->em_config.traffic_separation_policy.ssids_num); | ||
|
|
||
| if(isVapPrivate(apIdx)) | ||
| { |
There was a problem hiding this comment.
Not correct coding guideline
There was a problem hiding this comment.
Please correct everywhere
3 participants
Reason for change: Added traffic seperation TLV implementation
Test Procedure: Verify build is successfull and check if traffic seperation is functional
Risks: Medium
Priority: P2