Skip to content

Conversation

@fwph
Copy link

@fwph fwph commented Nov 17, 2025

This PR creates a set of L1 unittests for limited set of functions in the file source/core/wifi_ctrl_webconfig.c

The tests emphasize pointer safety to capture inputs which are currently at risk for null pointer dereferences. In order to support the tests, the following changes have been made to the build:

  • .github/workflows/makefile.yml has been updated to add an additional platform (mockplatform) in the strategy matrix build/linux/bpi/makefile and build/linux/rpi/makefile have been updated to accommodate the split
  • source/test/platform_mocks.c has been added to implement platform-specific functions in lieu of the raspberrypi/bananapi functions from $(WIFI_RDK_HAL)/platform

This PR uses objcopy to create a version of the object file with the main symbol stripped out from wifi_mgr.o before linking the gtest binary.

Unit test notes:

on-behalf-of: @permanence-ai github-ai@permanence.ai

@fwph fwph requested a review from a team as a code owner November 17, 2025 17:49
@fwph fwph force-pushed the RDKBWIFI-206-unit-tests branch 2 times, most recently from c5f6155 to 193d72d Compare November 22, 2025 17:59
@pradeeptakdas pradeeptakdas changed the title RDKBWIFI-206: add mocks, build, and limited platform independent L1 tests RDKCOM-5487: RDKBWIFI-206: add mocks, build, and limited platform independent L1 tests Jan 6, 2026
@fwph fwph force-pushed the RDKBWIFI-206-unit-tests branch from 193d72d to 31ca56e Compare January 14, 2026 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant