Fix indentation and remove trailing semicolons#165
Merged
rcaloras merged 1 commit intorcaloras:masterfrom Jan 13, 2025
Merged
Conversation
Contributor
Author
|
@rcaloras Could you also check other PRs, if possible? I think this one is a trivial fix, so it shouldn't take time to review. Also, #160 would be another trivial one. I also want to bring #96, which I reviewed and approved before, to your attention. My other PRs are a bit non-trivial, so I understand that you would require some other reviewers. I think issues #100 and #130 can be closed as resolved. #104 may also be closed because this seems to have been an external issue (or compatibility with an external setting), and the details needed to prepare any precautions, if we would do, are missing. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few lines have the 2-space indentation. We fix them in this PR.
Also, several lines have suffix semicolons. Those semicolons might have been added by e.g.
bash --pretty-print bash-preexec.sh, but we currently don't have such a semicolon for most of the lines anyway. There are two options for consistency:In this PR, we choose the latter, the majority.