[Win] New Fixes for Finder Mods (2024-06)#867
[Win] New Fixes for Finder Mods (2024-06)#867RedBearAK wants to merge 3 commits intorbreaves:masterfrom
Conversation
Finder Mods for Windows Explorer had a number of issues that needed to be fixed, primarily coming from how the comparison was being made between the `ClassNN` attribute and a list of different possible strings to match on, for certain keys and shortcuts. All issues with Enter, Backspace, Cmd+Backspace (Delete) and the Delete key seem to have been resolved in my testing on Windows 11. Renaming with Enter works on the desktop, and Cmd+Backspace is properly blocked to prevent deleting files on the desktop. Tab navigation shortcuts still working.
|
And of course after jumping into a different account on the same Windows 11 machine, I ran into a few more issues, and inconsistent It looks like I can't completely block the accidental usage of the Delete key in the desired places, but at least the fix for accidentally deleting a bunch of files on the desktop with Cmd+Backspace should still be working. This PR should fix the same problem mentioned in issue #787, that was also something targeted by PR #795. I think I'll close that older PR, and also PR #769. They are obsoleted by this PR. Edit: And also PR #768 is included in this PR, so closed that too. |
|
Added another minor tweak that tries to get Cmd+Down to work on the desktop, for opening files and folders in place of the Enter key. I've noticed a lot of strange inconsistency in both Explorer windows and the desktop, where sometimes things just don't work as intended right away, but the later they do, as if the But once it starts working, it seems to keep working after that. I'm not aware of anything else I can improve upon with this PR at this time, and I'm done updating this Win11 machine, so I probably won't mess with this again. |
…#744, & rbreaves#867 from, respectively: RedBear/patch-46 (via donaldguy/661-on-forced-master), RedBear/patch-40 (via donaldguy/harmonize-724-and-719), RedBearAK/patch-59, RedBearAK/mac_numpad_feature (via donaldguy/harmonize-744-and-724) & RedBearAK/patch-70 w/ menu order of OptSpecialChars, then Mac Numpad, then Media Arrows Fix & kinto.ahk logic blocks in that same order. (Grand)parents are: - @^1 rbreaves/master@{2025-04-25 19:00} [= @^2^1 = @^3~4 = @^4~2 = @^5~3] (bed5f37~..4a3bfe7) - @^2^2 rbreaves#661: [Win] Enable Cmd+Grave (backtick) same application window switching (3799224~..66ccab5) - @^2 ^^ fixed for force push of rbreaves/master on 2022-05-14 (95e92b4) - @^3 rbreaves#732: [Win] Enhance OptSpecialChars dead keys processing (2a65285~..dab20fd) - @^4~^2 rbreaves#724: [Win] Optional fix for media arrow keys (new) (e3e912f~..cea4111) - @^4~ ^^ merge with rbreaves#719, choosing arrows fix after OptSpecialChars (3d9670b) - @^4^2 rbreaves#744: Mac Numpad Features (7f3c95e~..d0d0bd1) - @^4 ^^ merge with rbreaves#722+rbreaves#719, chosing numpad between arrows & chars (b0ee59a) - @^5 rbreaves#867: [Win] New Fixes for Finder Mods (2024-06)
…#744, & rbreaves#867 from, respectively: RedBear/patch-46 (via donaldguy/661-on-forced-master), RedBear/patch-40 (via donaldguy/harmonize-724-and-719), RedBearAK/patch-59, RedBearAK/mac_numpad_feature (via donaldguy/harmonize-744-and-724) & RedBearAK/patch-70 w/ menu order of OptSpecialChars, then Mac Numpad, then Media Arrows Fix & kinto.ahk logic blocks in that same order. Common branch point [except @^2^2] is (6aa5cc5, but in `windows/`): 7b3aba9: @^1~14 = @^2~15 = @^3~5 = @^4^1~15 = @^4^2~9 = @^5~17 > @^2^2 is common from @^2^2~2 = 648819f = 7b3aba9~20 (Grand)parents are: - @^1 rbreaves/HEAD@{2025-04-25 19:00} [@^2^ = @^4^^ = @^5~3] (7b3aba9~..4a3bfe7) - @^2 vvv fixed for push -f of rbreaves/master on 2022-5-14 (95e92b4) - @^2^2 rbreaves#661: [Win] Enable Cmd+` same app window switching (3799224~..66ccab5) - @^3 rbreaves#732: [Win] Enhance OptSpecialChars dead keys processing (5bf0cc2~..f0c2c00) - @^4 vvvv, chosing numpad between arrows & chars (b0ee59a) - @^4^2 rbreaves#744: Mac Numpad Features (7f3c95e~..d0d0bd1) - @^4^1 vvv w/ rbreaves#719, choosing arrows fix after OptSpecialChars (3d9670b) - @^4^1^2 rbreaves#724: [Win] Optional fix for media arrow keys (new) (e3e912f~..cea4111) - @^5 rbreaves#867: [Win] New Fixes for Finder Mods (2024-06) (8b8e399~..044017e)
1 participant
@rbreaves
Finder Mods for Windows Explorer had a number of issues that needed to be fixed, primarily coming from how the comparison was being made between the
ClassNNattribute and a list of different possible strings to match on, for certain keys and shortcuts.All issues with Enter, Backspace, Cmd+Backspace (Delete) and the Delete key seem to have been resolved in my testing on Windows 11. Renaming with Enter works on the desktop, and Cmd+Backspace is properly blocked to prevent deleting files on the desktop. Tab navigation shortcuts still working.