Add support for non-default XDG user dir in an install script for the Linux#767
Open
Toreno96 wants to merge 1 commit intorbreaves:masterfrom
Open
Conversation
In an install script for the Linux. According to the <https://wiki.archlinux.org/title/XDG_user_directories> and <https://www.freedesktop.org/wiki/Software/xdg-user-dirs/>, Linux users can customize their "user directories" to be in a different paths than the default `~/Downloads` etc. _However_, the install script hardcoded this path so far, which caused a failure for such users. This commit is supposed to fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the https://wiki.archlinux.org/title/XDG_user_directories and https://www.freedesktop.org/wiki/Software/xdg-user-dirs/, Linux users can customize their "user directories" to be in a different paths than the default
~/Downloadsetc. However, the install script hardcoded this path so far, which caused a failure for such users, e.g.This PR is supposed to fix that.
In case the fallback hardcoded path is used, there will be an error message written to the
STDERR:This is the default error message that
bashshows in case it cannot find a specific command, I think it's clear enough not to require implementing any custom handling. Let me know if you agree or not 🙂