[Win] Enhance OptSpecialChars dead keys processing#731
Closed
RedBearAK wants to merge 1 commit intorbreaves:masterfrom
Closed
[Win] Enhance OptSpecialChars dead keys processing#731RedBearAK wants to merge 1 commit intorbreaves:masterfrom
RedBearAK wants to merge 1 commit intorbreaves:masterfrom
Conversation
Adds more accurate and intuitive behavior to the process of using dead keys, to match macOS more closely, and fixes some of the Switch/Case lines that weren't working as expected (Escape, Space were not actually activating). Dead keys sequences will now place the pending accent diacritic character in a highlight, then either replace it with an accented character if there is a match, or deselect the diacritic character and exit the dead keys sequence, leaving the diacritic character visible. Any input other than Escape or Space or a matching letter will be passed through. This is a match for how dead keys work in macOS. Includes the updated comments and typo fixes, so I'll close PR rbreaves#726.
RedBearAK
changed the title
Contributor
Author
|
Closed due to some previously unnoticed behavior from editing keys that don't generate characters, and capital accented characters not working correctly. Reworked and replaced with PR #732. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more accurate and intuitive behavior to the process of using dead keys, to match macOS more closely, and fixes some of the Switch/Case lines that weren't working as expected (Escape, Space were not actually activating).
Dead keys sequences will now place the pending accent diacritic character in a highlight, then either replace it with an accented character if there is a match, or deselect the diacritic character and exit the dead keys sequence, leaving the diacritic character visible. Any input other than Escape or Space or a matching letter will be passed through. This is a match for how dead keys work in macOS.
Includes the updated comments and typo fixes, so I'll close PR #726.