[Win] Optional fix for media arrow keys (new)#724
Open
RedBearAK wants to merge 2 commits intorbreaves:masterfrom
Open
[Win] Optional fix for media arrow keys (new)#724RedBearAK wants to merge 2 commits intorbreaves:masterfrom
RedBearAK wants to merge 2 commits intorbreaves:masterfrom
Conversation
Replacement for PR rbreaves#722. This does the same thing but in a much smarter way with fewer lines. Apple laptop keyboards have the PgUp/PgDn/Home/End navigation functions on Fn+arrow keys (even if not explicitly labeled on the keys). Most PC laptops also have these functions on the arrow keys, but some PC laptop keyboards have media functions (Play_Pause/Stop/Prev/Next) on the arrow keys instead. This makes it impossible to use the Fn+arrow keys for shortcuts like text selection (with Shift), or general navigation. This optional fix for this issue (disabled by default) will cause media arrow keys to behave like an Apple keyboard when used with the Fn key. All possible modifier combinations are mapped to what they would have been without Kinto's modifier remap. This PR creates a new tray menu item that will toggle the fix on and off, and it can be toggled with Shift+Opt+Cmd+M. The tray menu item will update with a check mark when the fix is active, and a MsgBox alerts the user when it is toggled on and off. If desired the user can set the fix to be enabled by default by changing a single variable value near the top of kinto.ahk. The toggles to disable/enable will still function. Companion to part of PR rbreaves#499 which is for Linux.
donaldguy
added a commit
to donaldguy/kinto
that referenced
this pull request
Apr 26, 2025
[Win] Optional fix for media arrow keys (new) Conflict: Branched prior to rbreaves#719 's: 1. addition to tray menu of OptSpecialChars 2. extension of Alt+[various] handling by 270 lines (while making togglable by above) Resolution: 1. Order menu as OptSpecialChar, then Media Arrows Fix, per expected use/interest (also chronological) 2. Move toggle_media_arrows_fix logic below `#If ... optspecialchars = 1` block - to keep file block order respective to menu order Non-conflicting intermin changes to master: - rbreaves#652 (Landed: f342ee4) - Anydesk (bab7660)
donaldguy
added a commit
to donaldguy/kinto
that referenced
this pull request
Apr 26, 2025
Mac Numpad feature Conflicts w/ rbreaves#724 (as 3d9670b <- master [4a3bfe7 , windows: bab7660]): 1. Addition of "Media Arrows Fix" to same slot in menu (below OptSpecialChars, above Close) 2. no `toggle_media_arrows_fix` block (obviously) 3. inserts a `toggle_mac_numpad` block above `#If ... optspecialchars = 1` block Resolution: 1. Order is OptSpecialChars, then Mac Numpad, then Media Arrows Fix - in order of expected user interest 2. toggle_media_arrows_fix is retained as in 3d9670b 3. relocates insertion of `toggle_mac_numpad` below `optspecialchars` but above `toggle_media_arrows_fix` - in order respective to menu order
donaldguy
added a commit
to donaldguy/kinto
that referenced
this pull request
Apr 26, 2025
…breaves#885 from, respectively: RedBear/patch-40 (via donaldguy/harmonize-724-and-719), RedBearAK/patch-59, RedBearAK/mac_numpad_feature (via donaldguy/harmonize-744-and-724) & RedBearAK/patch-70 w/ menu order of OptSpecialChars, then Mac Numpad, then Media Arrows Fix & kinto.ahk logic blocks in that same order.
donaldguy
added a commit
to donaldguy/kinto
that referenced
this pull request
Apr 26, 2025
…#744, & rbreaves#867 from, respectively: RedBear/patch-46 (via donaldguy/661-on-forced-master), RedBear/patch-40 (via donaldguy/harmonize-724-and-719), RedBearAK/patch-59, RedBearAK/mac_numpad_feature (via donaldguy/harmonize-744-and-724) & RedBearAK/patch-70 w/ menu order of OptSpecialChars, then Mac Numpad, then Media Arrows Fix & kinto.ahk logic blocks in that same order. (Grand)parents are: - @^1 rbreaves/master@{2025-04-25 19:00} [= @^2^1 = @^3~4 = @^4~2 = @^5~3] (bed5f37~..4a3bfe7) - @^2^2 rbreaves#661: [Win] Enable Cmd+Grave (backtick) same application window switching (3799224~..66ccab5) - @^2 ^^ fixed for force push of rbreaves/master on 2022-05-14 (95e92b4) - @^3 rbreaves#732: [Win] Enhance OptSpecialChars dead keys processing (2a65285~..dab20fd) - @^4~^2 rbreaves#724: [Win] Optional fix for media arrow keys (new) (e3e912f~..cea4111) - @^4~ ^^ merge with rbreaves#719, choosing arrows fix after OptSpecialChars (3d9670b) - @^4^2 rbreaves#744: Mac Numpad Features (7f3c95e~..d0d0bd1) - @^4 ^^ merge with rbreaves#722+rbreaves#719, chosing numpad between arrows & chars (b0ee59a) - @^5 rbreaves#867: [Win] New Fixes for Finder Mods (2024-06)
donaldguy
added a commit
to donaldguy/kinto
that referenced
this pull request
Apr 26, 2025
…#744, & rbreaves#867 from, respectively: RedBear/patch-46 (via donaldguy/661-on-forced-master), RedBear/patch-40 (via donaldguy/harmonize-724-and-719), RedBearAK/patch-59, RedBearAK/mac_numpad_feature (via donaldguy/harmonize-744-and-724) & RedBearAK/patch-70 w/ menu order of OptSpecialChars, then Mac Numpad, then Media Arrows Fix & kinto.ahk logic blocks in that same order. Common branch point [except @^2^2] is (6aa5cc5, but in `windows/`): 7b3aba9: @^1~14 = @^2~15 = @^3~5 = @^4^1~15 = @^4^2~9 = @^5~17 > @^2^2 is common from @^2^2~2 = 648819f = 7b3aba9~20 (Grand)parents are: - @^1 rbreaves/HEAD@{2025-04-25 19:00} [@^2^ = @^4^^ = @^5~3] (7b3aba9~..4a3bfe7) - @^2 vvv fixed for push -f of rbreaves/master on 2022-5-14 (95e92b4) - @^2^2 rbreaves#661: [Win] Enable Cmd+` same app window switching (3799224~..66ccab5) - @^3 rbreaves#732: [Win] Enhance OptSpecialChars dead keys processing (5bf0cc2~..f0c2c00) - @^4 vvvv, chosing numpad between arrows & chars (b0ee59a) - @^4^2 rbreaves#744: Mac Numpad Features (7f3c95e~..d0d0bd1) - @^4^1 vvv w/ rbreaves#719, choosing arrows fix after OptSpecialChars (3d9670b) - @^4^1^2 rbreaves#724: [Win] Optional fix for media arrow keys (new) (e3e912f~..cea4111) - @^5 rbreaves#867: [Win] New Fixes for Finder Mods (2024-06) (8b8e399~..044017e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for PR #722. This does the same thing but in a much smarter way with fewer lines.
Apple laptop keyboards have the PgUp/PgDn/Home/End navigation functions on Fn+arrow keys (even if not explicitly labeled on the keys). Most PC laptops also have these functions on the arrow keys, but some PC laptop keyboards have media functions (Play_Pause/Stop/Prev/Next) on the arrow keys instead. This makes it impossible to use the Fn+arrow keys for shortcuts like text selection (with Shift), or general navigation.
This optional fix for this issue (disabled by default) will cause media arrow keys to behave like an Apple keyboard when used with the Fn key. All possible modifier combinations are mapped to what they would have been without Kinto's modifier remap.
This PR creates a new tray menu item that will toggle the fix on and off, and it can be toggled with Shift+Opt+Cmd+M. The tray menu item will update with a check mark when the fix is active, and a MsgBox alerts the user when it is toggled on and off.
If desired the user can set the fix to be enabled by default by changing a single variable value near the top of kinto.ahk. The toggles to disable/enable will still function.
Companion to part of PR #725 which is the same thing for Linux.