Skip to content

Fix "Show Unread Badge" functionality #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix "Show Unread Badge" functionality #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions source/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ if (!is.development && config.get('autoUpdate')) {
let mainWindow: BrowserWindow;
let isQuitting = false;
let previousMessageCount = 0;
let currentMessageCount = 0;
let dockMenu: Menu;
let isDNDEnabled = false;

Expand Down Expand Up @@ -424,9 +425,14 @@ function createMainWindow(): BrowserWindow {

// Update badge on conversations change
ipc.answerRenderer('update-tray-icon', async (messageCount: number) => {
currentMessageCount = messageCount;
updateBadge(messageCount);
});

config.onDidChange('showUnreadBadge', () => {
updateBadge(currentMessageCount);
});

enableHiresResources();

const {webContents} = mainWindow;
Expand Down
5 changes: 0 additions & 5 deletions source/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,16 +315,11 @@ Press Command/Ctrl+R in Caprine to see your changes.
},
},
{
// TODO: Fix notification badge.
// ESTABLISHED FIX: Tray icon updates are handled by `updateTrayIcon` in `source/browser/conversation-list.ts`.
// This toggle controls the config state.
label: 'Show Unread Badge',
type: 'checkbox',
visible: is.development,
checked: config.get('showUnreadBadge'),
click(menuItem) {
config.set('showUnreadBadge', menuItem.checked);
sendAction('reload');
},
},
{
Expand Down