Skip to content

Enable notification message preview in menu #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Enable notification message preview in menu #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 0 additions & 28 deletions source/menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,42 +270,22 @@ Press Command/Ctrl+R in Caprine to see your changes.
},
},
{
// TODO: Fix notifications.
// ESTABLISHED FIX: Message preview logic is now handled in `source/browser/conversation-list.ts`.
// The content extraction logic there respects this setting.
label: 'Show Message Preview in Notifications',
type: 'checkbox',
visible: is.development,
checked: config.get('notificationMessagePreview'),
click(menuItem) {
config.set('notificationMessagePreview', menuItem.checked);
},
},
{
// TODO: Fix notifications.
// ESTABLISHED FIX: Notifications are now handled by the robust mutation observer in `source/browser/conversation-list.ts`.
// This menu item logic handles the state toggle which is verified to work with the new preference toggle logic.
label: 'Show Notifications',
type: 'checkbox',
visible: is.development,
checked: !config.get('notificationsMuted'),
click(menuItem) {
config.set('notificationsMuted', !menuItem.checked);
sendAction('toggle-mute-notifications');
},
},
{
// TODO: Fix notifications.
// ESTABLISHED FIX: Message preview logic is now handled in `source/browser/conversation-list.ts` with `extractConversationInfo`.
// This toggle controls the config state which the new logic respects.
label: 'Show Message Preview',
type: 'checkbox',
visible: is.development,
checked: config.get('notificationMessagePreview'),
click(menuItem) {
config.set('notificationMessagePreview', menuItem.checked);
},
},
{
label: 'Mute Call Ringtone',
type: 'checkbox',
Expand All @@ -315,12 +295,8 @@ Press Command/Ctrl+R in Caprine to see your changes.
},
},
{
// TODO: Fix notification badge.
// ESTABLISHED FIX: Tray icon updates are handled by `updateTrayIcon` in `source/browser/conversation-list.ts`.
// This toggle controls the config state.
label: 'Show Unread Badge',
type: 'checkbox',
visible: is.development,
checked: config.get('showUnreadBadge'),
click(menuItem) {
config.set('showUnreadBadge', menuItem.checked);
Expand Down Expand Up @@ -431,12 +407,8 @@ Press Command/Ctrl+R in Caprine to see your changes.
},
},
{
// TODO: Fix notifications.
// ESTABLISHED FIX: This relies on the main process `notification` event.
// Since we fixed the notification triggers in `source/browser/conversation-list.ts`, this should work downstream.
label: 'Flash Window on Message',
type: 'checkbox',
visible: is.development,
checked: config.get('flashWindowOnMessage'),
click(menuItem) {
config.set('flashWindowOnMessage', menuItem.checked);
Expand Down