fix: remove unnecessary stopOnDomReady option to prevent hangs#18
fix: remove unnecessary stopOnDomReady option to prevent hangs#18google-labs-jules[bot] wants to merge 1 commit intomainfrom
Conversation
This change removes the `stopOnDomReady: false` option from the `elementReady` call in `isNewSidebar`. Previously, this option caused the application to wait indefinitely if the new sidebar selector was not found (e.g., for users on the old design), preventing the fallback logic from executing. By reverting to the default behavior (or essentially `stopOnDomReady: true`), the check will fail fast if the element is not found when the DOM is ready, allowing the application to correctly detect and handle the old design. The associated TODO comment has also been removed.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Removed
stopOnDomReady: falsefromisNewSidebarto prevent potential hangs when detecting the sidebar version. This ensures that if the new sidebar is not present, the function returns false immediately instead of waiting indefinitely, allowing fallback logic to proceed.PR created automatically by Jules for task 9776901405644087799 started by @raztronaut