Skip to content

⚡ Optimize isUnread to reduce layout thrashing #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

⚡ Optimize isUnread to reduce layout thrashing #15

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions source/browser/conversation-list.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,14 +113,16 @@ function isUnread(element: HTMLElement): boolean {
// Secondary check: Bold text
// This covers cases where the button is hidden (responsive/maximized view)
// We look for any text container that has semi-bold/bold font weight
const candidates = element.querySelectorAll('span, div');
for (const candidate of candidates) {
// Optimization: Skip elements with children to focus on leaf/text nodes
if (candidate.childElementCount > 0) {
const walker = document.createTreeWalker(element, NodeFilter.SHOW_TEXT);
let node: Node | undefined;

while ((node = walker.nextNode()!)) {
const parent = node.parentElement;
if (!parent) {
continue;
}

const {fontWeight} = getComputedStyle(candidate);
const {fontWeight} = getComputedStyle(parent);
const weight = Number.parseInt(fontWeight, 10);
// 600 is usually semi-bold, 700 is bold. Facebook often uses 600 for unread text.
if (!Number.isNaN(weight) && weight >= 600) {
Expand Down