Skip to content

Refactor: Remove vibrancy migration code #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
google-labs-jules wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Refactor: Remove vibrancy migration code #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions source/config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,45 +218,6 @@ const schema: Store.Schema<StoreType> = {
},
};

function updateVibrancySetting(store: Store<StoreType>): void {
const vibrancy = store.get('vibrancy');

if (!is.macos || !vibrancy) {
store.set('vibrancy', 'none');
} else {
// TODO: This can be removed in a future version.
// Migration for the `vibrancy` config.
switch (store.get('vibrancy') as any) {
case true: {
store.set('vibrancy', 'full');
break;
}

case false: {
store.set('vibrancy', 'sidebar');
break;
}

case 'sidebar':
case 'full': {
break;
}

case 'none': {
// 'none' is already handled by the `!vibrancy` check above,
// but keeping this case for completeness if the initial check changes.
break;
}

default: {
// Handle any unexpected values safely
store.set('vibrancy', 'sidebar');
break;
}
}
}
}

function updateSidebarSetting(store: Store<StoreType>): void {
if (store.get('sidebarHidden')) {
store.set('sidebar', 'hidden');
Expand Down Expand Up @@ -291,7 +252,6 @@ function updateThemeSetting(store: Store<StoreType>): void {
}

function migrate(store: Store<StoreType>): void {
updateVibrancySetting(store);
updateSidebarSetting(store);
updateThemeSetting(store);
}
Expand Down